From 0cc7444ea9870c11b6ce0c61e4c761609f295f69 Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Sat, 21 Aug 2010 02:45:15 +0000 Subject: [PATCH] speed hack can be implemented more cleanly by directly calling __new__ --- Lib/hmac.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/Lib/hmac.py b/Lib/hmac.py index 5572751f6ec..e878e1a8096 100644 --- a/Lib/hmac.py +++ b/Lib/hmac.py @@ -12,10 +12,6 @@ trans_36 = bytes((x ^ 0x36) for x in range(256)) # hashing module used. Use digest_size from the instance of HMAC instead. digest_size = None -# A unique object passed by HMAC.copy() to the HMAC constructor, in order -# that the latter return very quickly. HMAC("") in contrast is quite -# expensive. -_secret_backdoor_key = object() class HMAC: """RFC 2104 HMAC class. Also complies with RFC 4231. @@ -36,9 +32,6 @@ class HMAC: Note: key and msg must be bytes objects. """ - if key is _secret_backdoor_key: # cheap - return - if not isinstance(key, bytes): raise TypeError("expected bytes, but got %r" % type(key).__name__) @@ -89,7 +82,8 @@ class HMAC: An update to this copy won't affect the original object. """ - other = self.__class__(_secret_backdoor_key) + # Call __new__ directly to avoid the expensive __init__. + other = self.__class__.__new__(self.__class__) other.digest_cons = self.digest_cons other.digest_size = self.digest_size other.inner = self.inner.copy()