bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074)
Join the thread to prevent leaking a running thread and leaking a reference. Cleanup also the test: * asyncioWindowsProactorEventLoopPolicy became the default policy, there is no need to set it manually. * Only start the thread once the loop is running. * Use a shorter sleep in the thread (100 ms rather than 1 sec). * Use close_loop(loop) rather than loop.close(). * Use longer variable names.
This commit is contained in:
parent
b2f94730d9
commit
07559450b2
|
@ -45,20 +45,21 @@ class ProactorLoopCtrlC(test_utils.TestCase):
|
|||
def test_ctrl_c(self):
|
||||
|
||||
def SIGINT_after_delay():
|
||||
time.sleep(1)
|
||||
time.sleep(0.1)
|
||||
signal.raise_signal(signal.SIGINT)
|
||||
|
||||
asyncio.set_event_loop_policy(asyncio.WindowsProactorEventLoopPolicy())
|
||||
l = asyncio.get_event_loop()
|
||||
thread = threading.Thread(target=SIGINT_after_delay)
|
||||
loop = asyncio.get_event_loop()
|
||||
try:
|
||||
t = threading.Thread(target=SIGINT_after_delay)
|
||||
t.start()
|
||||
l.run_forever()
|
||||
# only start the loop once the event loop is running
|
||||
loop.call_soon(thread.start)
|
||||
loop.run_forever()
|
||||
self.fail("should not fall through 'run_forever'")
|
||||
except KeyboardInterrupt:
|
||||
pass
|
||||
finally:
|
||||
l.close()
|
||||
self.close_loop(loop)
|
||||
thread.join()
|
||||
|
||||
|
||||
class ProactorTests(test_utils.TestCase):
|
||||
|
|
|
@ -0,0 +1,2 @@
|
|||
Fix test_asyncio ProactorLoopCtrlC: join the thread to prevent leaking a
|
||||
running thread and leaking a reference.
|
Loading…
Reference in New Issue