Test cases and fixes for bugs described in patch #873418: email/Message.py:

del_param fails when specifying a header.
This commit is contained in:
Barry Warsaw 2004-08-16 15:47:34 +00:00
parent d4ff206906
commit 06fa042034
2 changed files with 14 additions and 2 deletions

View File

@ -664,7 +664,7 @@ class Message:
if not self.has_key(header):
return
new_ctype = ''
for p, v in self.get_params(header, unquote=requote):
for p, v in self.get_params(header=header, unquote=requote):
if p.lower() <> param.lower():
if not new_ctype:
new_ctype = _formatparam(p, v, requote)
@ -700,7 +700,7 @@ class Message:
if not self.has_key(header):
self[header] = type
return
params = self.get_params(header, unquote=requote)
params = self.get_params(header=header, unquote=requote)
del self[header]
self[header] = type
# Skip the first param; it's the old type.

View File

@ -354,6 +354,12 @@ class TestMessageAPI(TestEmailBase):
('boundary', 'D1690A7AC1.996856090/mail.example.com'),
('report-type', old_val)])
def test_del_param_on_other_header(self):
msg = Message()
msg.add_header('Content-Disposition', 'attachment', filename='bud.gif')
msg.del_param('filename', 'content-disposition')
self.assertEqual(msg['content-disposition'], 'attachment')
def test_set_type(self):
eq = self.assertEqual
msg = Message()
@ -365,6 +371,12 @@ class TestMessageAPI(TestEmailBase):
msg.set_type('text/html')
eq(msg['content-type'], 'text/html; charset="us-ascii"')
def test_set_type_on_other_header(self):
msg = Message()
msg['X-Content-Type'] = 'text/plain'
msg.set_type('application/octet-stream', 'X-Content-Type')
self.assertEqual(msg['x-content-type'], 'application/octet-stream')
def test_get_content_type_missing(self):
msg = Message()
self.assertEqual(msg.get_content_type(), 'text/plain')