From 023654fa68c73e34da01610cad330f98d2db79cf Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 23 Mar 2016 17:48:22 +0100 Subject: [PATCH] get_warnings_attr(): Fix coverity warning Don't check if the dict key exists before getting the key. Instead get the key and handle error. --- Python/_warnings.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Python/_warnings.c b/Python/_warnings.c index 41eaf5310ae..40f5c8ecfcd 100644 --- a/Python/_warnings.c +++ b/Python/_warnings.c @@ -45,7 +45,6 @@ get_warnings_attr(const char *attr, int try_import) static PyObject *warnings_str = NULL; PyObject *all_modules; PyObject *warnings_module, *obj; - int result; if (warnings_str == NULL) { warnings_str = PyUnicode_InternFromString("warnings"); @@ -65,11 +64,11 @@ get_warnings_attr(const char *attr, int try_import) } else { all_modules = PyImport_GetModuleDict(); - result = PyDict_Contains(all_modules, warnings_str); - if (result == -1 || result == 0) - return NULL; warnings_module = PyDict_GetItem(all_modules, warnings_str); + if (warnings_module == NULL) + return NULL; + Py_INCREF(warnings_module); }