From f3533d31f8c7709a5ea93f60706803352ddea398 Mon Sep 17 00:00:00 2001
From: Daniel Agar <daniel@agar.ca>
Date: Tue, 12 Mar 2019 20:46:04 -0400
Subject: [PATCH] mavlink update to latest and enable address-of-packed-member
 warning

---
 cmake/px4_add_common_flags.cmake           |  5 -----
 mavlink/include/mavlink/v2.0               |  2 +-
 src/modules/mavlink/mavlink_parameters.cpp | 10 +++++++---
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/cmake/px4_add_common_flags.cmake b/cmake/px4_add_common_flags.cmake
index a486089d8f..feeaa7bdae 100644
--- a/cmake/px4_add_common_flags.cmake
+++ b/cmake/px4_add_common_flags.cmake
@@ -99,7 +99,6 @@ function(px4_add_common_flags)
 			add_compile_options(
 				-Qunused-arguments
 
-				-Wno-address-of-packed-member # TODO: fix and enable (mavlink, etc)
 				-Wno-unknown-warning-option
 				-Wno-unused-const-variable
 				-Wno-varargs
@@ -113,10 +112,6 @@ function(px4_add_common_flags)
 			add_compile_options(-fdiagnostics-color=always)
 		endif()
 
-		if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 9)
-			add_compile_options(-Wno-address-of-packed-member) # TODO: fix and enable (mavlink, etc)
-		endif()
-
 		add_compile_options(
 			-fno-builtin-printf
 			-fno-strength-reduce
diff --git a/mavlink/include/mavlink/v2.0 b/mavlink/include/mavlink/v2.0
index 2a47f11e73..b32bd3f004 160000
--- a/mavlink/include/mavlink/v2.0
+++ b/mavlink/include/mavlink/v2.0
@@ -1 +1 @@
-Subproject commit 2a47f11e73eef6d817af7934692b1223d7fb434f
+Subproject commit b32bd3f004b971c03711617c79e5dc67e720e864
diff --git a/src/modules/mavlink/mavlink_parameters.cpp b/src/modules/mavlink/mavlink_parameters.cpp
index cbfdf75f2d..0f1afcb77f 100644
--- a/src/modules/mavlink/mavlink_parameters.cpp
+++ b/src/modules/mavlink/mavlink_parameters.cpp
@@ -450,8 +450,7 @@ MavlinkParametersManager::send_uavcan()
 			msg.param_value = value.real_value;
 
 		} else {
-			int32_t val;
-			val = (int32_t)value.int_value;
+			int32_t val = (int32_t)value.int_value;
 			memcpy(&msg.param_value, &val, sizeof(int32_t));
 			msg.param_type = MAVLINK_TYPE_INT32_T;
 		}
@@ -545,14 +544,19 @@ MavlinkParametersManager::send_param(param_t param, int component_id)
 	 * get param value, since MAVLink encodes float and int params in the same
 	 * space during transmission, copy param onto float val_buf
 	 */
-	if (param_get(param, &msg.param_value) != OK) {
+	float param_value{};
+
+	if (param_get(param, &param_value) != OK) {
 		return 2;
 	}
 
+	msg.param_value = param_value;
+
 	msg.param_count = param_count_used();
 	msg.param_index = param_get_used_index(param);
 
 #if defined(__GNUC__) && __GNUC__ >= 8
+#pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wstringop-truncation"
 #endif
 	/*