From eb43b86a4b5d2db5f69abc44b9ba0bc433974f73 Mon Sep 17 00:00:00 2001
From: Lorenz Meier <lorenz@px4.io>
Date: Mon, 1 Jan 2018 16:36:35 +0100
Subject: [PATCH] Load mon: Also monitor file descriptors

It is important that tasks do not run out of them and this addition will provide a warning and log evidence if it goes wrong.
---
 src/modules/load_mon/load_mon.cpp | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/src/modules/load_mon/load_mon.cpp b/src/modules/load_mon/load_mon.cpp
index df756f9d72..a53a034d2d 100644
--- a/src/modules/load_mon/load_mon.cpp
+++ b/src/modules/load_mon/load_mon.cpp
@@ -1,6 +1,6 @@
 /****************************************************************************
  *
- *   Copyright (c) 2012-2016 PX4 Development Team. All rights reserved.
+ *   Copyright (c) 2012-2018 PX4 Development Team. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -62,6 +62,7 @@
 extern struct system_load_s system_load;
 
 #define STACK_LOW_WARNING_THRESHOLD 300 ///< if free stack space falls below this, print a warning
+#define FDS_LOW_WARNING_THRESHOLD 10 ///< if free file descriptors fall below this, print a warning
 
 namespace load_mon
 {
@@ -263,6 +264,7 @@ void LoadMon::_stack_usage()
 	for (int i = _stack_task_index; i < _stack_task_index + num_tasks_per_cycle; i++) {
 		task_index = i % CONFIG_MAX_TASKS;
 		unsigned stack_free = 0;
+		unsigned fds_free = 0;
 		bool checked_task = false;
 
 		perf_begin(_stack_perf);
@@ -275,6 +277,23 @@ void LoadMon::_stack_usage()
 			strncpy((char *)_task_stack_info.task_name, system_load.tasks[task_index].tcb->name,
 				task_stack_info_s::MAX_REPORT_TASK_NAME_LEN);
 
+#if CONFIG_NFILE_DESCRIPTORS > 0
+			FAR struct task_group_s *group = system_load.tasks[i].tcb->group;
+
+			unsigned tcb_num_used_fds = 0;
+
+			if (group) {
+				for (int fd_index = 0; fd_index < CONFIG_NFILE_DESCRIPTORS; ++fd_index) {
+					if (group->tg_filelist.fl_files[fd_index].f_inode) {
+						++tcb_num_used_fds;
+					}
+				}
+
+				fds_free = CONFIG_NFILE_DESCRIPTORS - tcb_num_used_fds;
+			}
+
+#endif
+
 			checked_task = true;
 		}
 
@@ -301,6 +320,14 @@ void LoadMon::_stack_usage()
 				break;
 			}
 
+			/*
+			 * Found task low on file descriptors, report and exit. Continue here in next cycle.
+			 */
+			if (fds_free < FDS_LOW_WARNING_THRESHOLD) {
+				PX4_WARN("%s low on FDs! (%i FDs left)", _task_stack_info.task_name, fds_free);
+				break;
+			}
+
 		} else {
 			/* No task here, check one more task in same cycle. */
 			_stack_task_index++;