From c0084ab24d9f5993ce4dea28e0aed85747d8a959 Mon Sep 17 00:00:00 2001 From: Jukka Laitinen Date: Wed, 9 Aug 2023 12:16:14 +0300 Subject: [PATCH] Fix maximum rotation value in GetBoardRotation() Fix a memory overflow in case SENS_BOARD_ROT is set to Rotation::ROTATION_MAX (41) which is not a valid value Signed-off-by: Jukka Laitinen --- src/lib/sensor_calibration/Utilities.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/sensor_calibration/Utilities.cpp b/src/lib/sensor_calibration/Utilities.cpp index ca3a238838..f1c864bf3f 100644 --- a/src/lib/sensor_calibration/Utilities.cpp +++ b/src/lib/sensor_calibration/Utilities.cpp @@ -222,7 +222,7 @@ enum Rotation GetBoardRotation() int32_t board_rot = -1; param_get(param_find("SENS_BOARD_ROT"), &board_rot); - if (board_rot >= 0 && board_rot <= Rotation::ROTATION_MAX) { + if (board_rot >= 0 && board_rot < Rotation::ROTATION_MAX) { return static_cast(board_rot); } else {