dark0707
/
px4-firmware
forked from Archive/PX4-Autopilot
1
0
Fork 0
Code Pull Requests Activity

Matrix: remove unsafe copyToRaw method 

It used a pointer and could therefore not do correct type checking
for index out of bound or struct memebr order.
Has to be considered unsafe and bad practise.
We should switch to arrays as representation for vectors
inside the messages instead of foo_x, foo_y, foo_z fields.
This commit is contained in:
Matthias Grob 2018-11-20 17:33:30 +01:00 committed by Lorenz Meier
parent 0d3bff5e00
commit 9c0acfba36
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
matrix/Matrix.hpp
View File

@ -87,11 +87,6 @@ public:
memcpy(dst, _data, sizeof(dst));
}
void copyToRaw(Type *dst) const
{
memcpy(dst, _data, sizeof(_data));
}
void copyToColumnMajor(Type (&dst)[M*N]) const
{
const Matrix<Type, M, N> &self = *this;

7
test/copyto.cpp
View File

@ -38,13 +38,6 @@ int main()
TEST(fabs(array_A[i] - array_row[i]) < eps);
}
// Matrix copyTo with a pointer
A.copyToRaw(static_cast <float *> (array_A));
float array_row_p[6] = {1, 2, 3, 4, 5, 6};
for (size_t i = 0; i < 6; i++) {
TEST(fabs(array_A[i] - array_row_p[i]) < eps);
}
// Matrix copyToColumnMajor
A.copyToColumnMajor(array_A);
float array_column[6] = {1, 4, 2, 5, 3, 6};