dark0707
/
px4-firmware
forked from Archive/PX4-Autopilot
1
0
Fork 0
Code Pull Requests Activity

clang-tidy performance-unnecessary-copy-initialization

This commit is contained in:
Daniel Agar 2017-01-30 23:24:04 -05:00
parent 7e5f09f408
commit 6f05fec335
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.clang-tidy
View File

@ -165,7 +165,7 @@ Checks: 'clang-diagnostic-*,clang-analyzer-*,-*,
performance-implicit-cast-in-loop,
## TODO: fix code and enable # performance-inefficient-string-concatenation,
## TODO: fix code and enable # performance-type-promotion-in-math-fn,
## TODO: fix code and enable # performance-unnecessary-copy-initialization,
performance-unnecessary-copy-initialization,
performance-unnecessary-value-param,
## TODO: fix code and enable # readability-avoid-const-params-in-decls,
readability-braces-around-statements,

4
src/modules/unit_test/unit_test.h
View File

@ -110,7 +110,7 @@ protected:
/// @brief To assert specifically to true.
#define ut_assert_true(test) \
do { \
if (test != true) { \
if ((test) != true) { \
_print_assert("result not true", #test, __FILE__, __LINE__); \
return false; \
} else { \
@ -121,7 +121,7 @@ protected:
/// @brief To assert specifically to true.
#define ut_assert_false(test) \
do { \
if (test != false) { \
if ((test) != false) { \
_print_assert("result not false", #test, __FILE__, __LINE__); \
return false; \
} else { \

8
src/systemcmds/tests/test_mathlib.cpp
View File

@ -87,7 +87,7 @@ bool MathlibTest::testVector2()
Vector<2> v2(1.0f, -1.0f);
float data[2] = {1.0f, 2.0f};
TEST_OP("Constructor Vector<2>()", Vector<2> v3);
TEST_OP("Constructor Vector<2>(Vector<2>)", Vector<2> v3(v1));
TEST_OP("Constructor Vector<2>(Vector<2>)", Vector<2> v3(v1); ut_assert_true(v3 == v1); v3.zero());
TEST_OP("Constructor Vector<2>(float[])", Vector<2> v3(data));
TEST_OP("Constructor Vector<2>(float, float)", Vector<2> v3(1.0f, 2.0f));
TEST_OP("Vector<2> = Vector<2>", v = v1);
@ -110,7 +110,7 @@ bool MathlibTest::testVector3()
Vector<3> v2(1.0f, -1.0f, 2.0f);
float data[3] = {1.0f, 2.0f, 3.0f};
TEST_OP("Constructor Vector<3>()", Vector<3> v3);
TEST_OP("Constructor Vector<3>(Vector<3>)", Vector<3> v3(v1));
TEST_OP("Constructor Vector<3>(Vector<3>)", Vector<3> v3(v1); ut_assert_true(v3 == v1); v3.zero());
TEST_OP("Constructor Vector<3>(float[])", Vector<3> v3(data));
TEST_OP("Constructor Vector<3>(float, float, float)", Vector<3> v3(1.0f, 2.0f, 3.0f));
TEST_OP("Vector<3> = Vector<3>", v = v1);
@ -147,7 +147,7 @@ bool MathlibTest::testVector4()
Vector<4> v2(1.0f, -1.0f, 2.0f, 0.0f);
float data[4] = {1.0f, 2.0f, 3.0f, 4.0f};
TEST_OP("Constructor Vector<4>()", Vector<4> v3);
TEST_OP("Constructor Vector<4>(Vector<4>)", Vector<4> v3(v1));
TEST_OP("Constructor Vector<4>(Vector<4>)", Vector<4> v3(v1); ut_assert_true(v3 == v1); v3.zero());
TEST_OP("Constructor Vector<4>(float[])", Vector<4> v3(data));
TEST_OP("Constructor Vector<4>(float, float, float, float)", Vector<4> v3(1.0f, 2.0f, 3.0f, 4.0f));
TEST_OP("Vector<4> = Vector<4>", v = v1);
@ -167,7 +167,7 @@ bool MathlibTest::testVector10()
v1.zero();
float data[10];
TEST_OP("Constructor Vector<10>()", Vector<10> v3);
TEST_OP("Constructor Vector<10>(Vector<10>)", Vector<10> v3(v1));
TEST_OP("Constructor Vector<10>(Vector<10>)", Vector<10> v3(v1); ut_assert_true(v3 == v1); v3.zero());
TEST_OP("Constructor Vector<10>(float[])", Vector<10> v3(data));
}
return true;