cleanup module callback registration failed errors

src/drivers/tone_alarm/ToneAlarm.cpp

@@ -62,7 +62,7 @@ bool ToneAlarm::Init()
 	_tune_control_sub.set_interval_us(10_ms);
 
 	if (!_tune_control_sub.registerCallback()) {
-		PX4_ERR("tune_control callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return PX4_ERROR;
 	}
 

src/examples/work_item/WorkItemExample.cpp

@@ -49,7 +49,7 @@ bool WorkItemExample::init()
 {
 	// execute Run() on every sensor_accel publication
 	if (!_sensor_accel_sub.registerCallback()) {
-		PX4_ERR("sensor_accel callback registration failed");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/airship_att_control/airship_att_control_main.cpp

@@ -59,7 +59,7 @@ bool
 AirshipAttitudeControl::init()
 {
 	if (!_vehicle_angular_velocity_sub.registerCallback()) {
-		PX4_ERR("vehicle_angular_velocity callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/angular_velocity_controller/AngularVelocityController.cpp

@@ -62,7 +62,7 @@ bool
 AngularVelocityController::init()
 {
 	if (!_vehicle_angular_velocity_sub.registerCallback()) {
-		PX4_ERR("vehicle_angular_velocity callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/attitude_estimator_q/attitude_estimator_q_main.cpp

@@ -181,7 +181,7 @@ bool
 AttitudeEstimatorQ::init()
 {
 	if (!_sensors_sub.registerCallback()) {
-		PX4_ERR("sensor combined callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/camera_feedback/CameraFeedback.cpp

@@ -48,7 +48,7 @@ bool
 CameraFeedback::init()
 {
 	if (!_trigger_sub.registerCallback()) {
-		PX4_ERR("camera_trigger callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/control_allocator/ControlAllocator.cpp

@@ -89,12 +89,12 @@ bool
 ControlAllocator::init()
 {
 	if (!_vehicle_torque_setpoint_sub.registerCallback()) {
-		PX4_ERR("vehicle_torque_setpoint callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 
 	if (!_vehicle_thrust_setpoint_sub.registerCallback()) {
-		PX4_ERR("vehicle_thrust_setpoint callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/esc_battery/EscBattery.cpp

@@ -46,7 +46,7 @@ bool
 EscBattery::init()
 {
 	if (!_esc_status_sub.registerCallback()) {
-		PX4_ERR("esc_status callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/flight_mode_manager/FlightModeManager.cpp

@@ -67,7 +67,7 @@ FlightModeManager::~FlightModeManager()
 bool FlightModeManager::init()
 {
 	if (!_vehicle_local_position_sub.registerCallback()) {
-		PX4_ERR("vehicle_local_position callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/fw_att_control/FixedwingAttitudeControl.cpp

@@ -78,7 +78,7 @@ bool
 FixedwingAttitudeControl::init()
 {
 	if (!_att_sub.registerCallback()) {
-		PX4_ERR("vehicle attitude callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/fw_autotune_attitude_control/fw_autotune_attitude_control.cpp

@@ -59,7 +59,7 @@ FwAutotuneAttitudeControl::~FwAutotuneAttitudeControl()
 bool FwAutotuneAttitudeControl::init()
 {
 	if (!_parameter_update_sub.registerCallback()) {
-		PX4_ERR("parameter_update callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 
@@ -434,7 +434,7 @@ void FwAutotuneAttitudeControl::updateStateMachine(hrt_abstime now)
 bool FwAutotuneAttitudeControl::registerActuatorControlsCallback()
 {
 	if (!_actuator_controls_sub.registerCallback()) {
-		PX4_ERR("actuator_controls callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/fw_pos_control_l1/FixedwingPositionControl.cpp

@@ -89,7 +89,7 @@ bool
 FixedwingPositionControl::init()
 {
 	if (!_local_pos_sub.registerCallback()) {
-		PX4_ERR("vehicle local position callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/local_position_estimator/BlockLocalPositionEstimator.cpp

@@ -138,7 +138,7 @@ bool
 BlockLocalPositionEstimator::init()
 {
 	if (!_sensors_sub.registerCallback()) {
-		PX4_ERR("sensor combined callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/mc_att_control/mc_att_control_main.cpp

@@ -78,7 +78,7 @@ bool
 MulticopterAttitudeControl::init()
 {
 	if (!_vehicle_attitude_sub.registerCallback()) {
-		PX4_ERR("vehicle_attitude callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/mc_autotune_attitude_control/mc_autotune_attitude_control.cpp

@@ -57,7 +57,7 @@ McAutotuneAttitudeControl::~McAutotuneAttitudeControl()
 bool McAutotuneAttitudeControl::init()
 {
 	if (!_parameter_update_sub.registerCallback()) {
-		PX4_ERR("parameter_update callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 
@@ -499,7 +499,7 @@ void McAutotuneAttitudeControl::revertParamGains()
 bool McAutotuneAttitudeControl::registerActuatorControlsCallback()
 {
 	if (!_actuator_controls_sub.registerCallback()) {
-		PX4_ERR("actuator_controls callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/mc_hover_thrust_estimator/MulticopterHoverThrustEstimator.cpp

@@ -60,7 +60,7 @@ MulticopterHoverThrustEstimator::~MulticopterHoverThrustEstimator()
 bool MulticopterHoverThrustEstimator::init()
 {
 	if (!_vehicle_local_position_sub.registerCallback()) {
-		PX4_ERR("vehicle_local_position_setpoint callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/mc_pos_control/MulticopterPositionControl.cpp

@@ -65,7 +65,7 @@ MulticopterPositionControl::~MulticopterPositionControl()
 bool MulticopterPositionControl::init()
 {
 	if (!_local_pos_sub.registerCallback()) {
-		PX4_ERR("vehicle_local_position callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/mc_rate_control/MulticopterRateControl.cpp

@@ -64,7 +64,7 @@ bool
 MulticopterRateControl::init()
 {
 	if (!_vehicle_angular_velocity_sub.registerCallback()) {
-		PX4_ERR("vehicle_angular_velocity callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/rc_update/rc_update.cpp

@@ -115,7 +115,7 @@ RCUpdate::~RCUpdate()
 bool RCUpdate::init()
 {
 	if (!_input_rc_sub.registerCallback()) {
-		PX4_ERR("input_rc callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/rover_pos_control/RoverPositionControl.cpp

@@ -73,7 +73,7 @@ bool
 RoverPositionControl::init()
 {
 	if (!_vehicle_angular_velocity_sub.registerCallback()) {
-		PX4_ERR("vehicle angular velocity callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/sensors/vehicle_acceleration/VehicleAcceleration.cpp

@@ -63,7 +63,7 @@ bool VehicleAcceleration::Start()
 
 	// sensor_selection needed to change the active sensor if the primary stops updating
 	if (!_sensor_selection_sub.registerCallback()) {
-		PX4_ERR("sensor_selection callback registration failed");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/sensors/vehicle_angular_velocity/VehicleAngularVelocity.cpp

@@ -75,7 +75,7 @@ bool VehicleAngularVelocity::Start()
 
 	// sensor_selection needed to change the active sensor if the primary stops updating
 	if (!_sensor_selection_sub.registerCallback()) {
-		PX4_ERR("sensor_selection callback registration failed");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/uuv_att_control/uuv_att_control.cpp

@@ -73,7 +73,7 @@ UUVAttitudeControl::~UUVAttitudeControl()
 bool UUVAttitudeControl::init()
 {
 	if (!_vehicle_attitude_sub.registerCallback()) {
-		PX4_ERR("vehicle_attitude callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/uuv_pos_control/uuv_pos_control.cpp

@@ -70,7 +70,7 @@ UUVPOSControl::~UUVPOSControl()
 bool UUVPOSControl::init()
 {
 	if (!_vehicle_local_position_sub.registerCallback()) {
-		PX4_ERR("vehicle_pos callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 

src/modules/vtol_att_control/vtol_att_control_main.cpp

@@ -141,12 +141,12 @@ bool
 VtolAttitudeControl::init()
 {
 	if (!_actuator_inputs_mc.registerCallback()) {
-		PX4_ERR("MC actuator controls callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}
 
 	if (!_actuator_inputs_fw.registerCallback()) {
-		PX4_ERR("FW actuator controls callback registration failed!");
+		PX4_ERR("callback registration failed");
 		return false;
 	}