clang-tidy remove redundant init

src/examples/ekf_att_pos_estimator/estimator_22states.cpp

@@ -88,21 +88,7 @@ AttPosEKF::AttPosEKF() :
     statesAtVtasMeasTime{},
     statesAtRngTime{},
     statesAtFlowTime{},
-    correctedDelAng(),
-    correctedDelVel(),
-    summedDelAng(),
-    summedDelVel(),
-    prevDelAng(),
     accNavMag(),
-    earthRateNED(),
-    angRate(),
-    lastGyroOffset(),
-    delAngTotal(),
-    Tbn(),
-    Tnb(),
-    accel(),
-    dVelIMU(),
-    dAngIMU(),
     dtIMU(0.005f),
     dtIMUfilt(0.005f),
     dtVelPos(0.01f),
@@ -119,7 +105,6 @@ AttPosEKF::AttPosEKF() :
     rngMea(0.0f),
     innovMag{},
     varInnovMag{},
-    magData{},
     innovVtas(0.0f),
     innovRng(0.0f),
     innovOptFlow{},
@@ -132,7 +117,6 @@ AttPosEKF::AttPosEKF() :
     lonRef(-M_PI_F),
     hgtRef(0.0f),
     refSet(false),
-    magBias(),
     covSkipCount(0),
     lastFixTime_ms(0),
     globalTimeStamp_ms(0),
@@ -176,7 +160,6 @@ AttPosEKF::AttPosEKF() :
     auxFlowObsInnov{},
     auxFlowObsInnovVar{},
     fScaleFactorVar(0.0f),
-    Tnb_flow{},
     R_LOS(0.0f),
     auxFlowTestRatio{},
     auxRngTestRatio(0.0f),

src/lib/controllib/block/Block.cpp

@@ -53,9 +53,7 @@ namespace control
 Block::Block(SuperBlock *parent, const char *name) :
 	_name(name),
 	_parent(parent),
-	_dt(0),
+	_dt(0)
-	_subscriptions(),
-	_params()
 {
 	if (getParent() != nullptr) {
 		getParent()->getChildren().add(this);

src/lib/controllib/block/Block.hpp

@@ -103,11 +103,7 @@ class __EXPORT SuperBlock :
 public:
 	friend class Block;
 // methods
-	SuperBlock(SuperBlock *parent, const char *name) :
+	SuperBlock(SuperBlock *parent, const char *name) : Block(parent, name) {}
-		Block(parent, name),
-		_children()
-	{
-	}
 	virtual ~SuperBlock() {};
 	virtual void setDt(float dt);
 	virtual void updateParams()

src/lib/runway_takeoff/RunwayTakeoff.cpp

@@ -59,7 +59,6 @@ RunwayTakeoff::RunwayTakeoff() :
 	_init_yaw(0),
 	_climbout(false),
 	_throttle_ramp_time(2 * 1e6),
-	_start_wp(),
 	_runway_takeoff_enabled(this, "TKOFF"),
 	_heading_mode(this, "HDG"),
 	_nav_alt(this, "NAV_ALT"),

src/modules/ekf2/ekf2_main.cpp

@@ -339,7 +339,6 @@ Ekf2::Ekf2():
 	_lp_roll_rate(250.0f, 30.0f),
 	_lp_pitch_rate(250.0f, 30.0f),
 	_lp_yaw_rate(250.0f, 20.0f),
-	_ekf(),
 	_params(_ekf.getParamHandle()),
 	_obs_dt_min_ms(this, "EKF2_MIN_OBS_DT", false, _params->sensor_interval_min_ms),
 	_mag_delay_ms(this, "EKF2_MAG_DELAY", false, _params->mag_delay_ms),

src/modules/land_detector/FixedwingLandDetector.cpp

@@ -50,7 +50,7 @@
 namespace land_detector
 {
 
-FixedwingLandDetector::FixedwingLandDetector() : LandDetector(),
+FixedwingLandDetector::FixedwingLandDetector() :
 	_paramHandle(),
 	_params(),
 	_controlStateSub(-1),

src/modules/land_detector/MulticopterLandDetector.cpp

@@ -49,7 +49,7 @@
 namespace land_detector
 {
 
-MulticopterLandDetector::MulticopterLandDetector() : LandDetector(),
+MulticopterLandDetector::MulticopterLandDetector() :
 	_paramHandle(),
 	_params(),
 	_vehicleLocalPositionSub(-1),

src/modules/land_detector/RoverLandDetector.cpp

@@ -46,7 +46,7 @@
 namespace land_detector
 {
 
-RoverLandDetector::RoverLandDetector() : LandDetector()
+RoverLandDetector::RoverLandDetector()
 {
 }
 

src/modules/land_detector/VtolLandDetector.cpp

@@ -46,7 +46,7 @@
 namespace land_detector
 {
 
-VtolLandDetector::VtolLandDetector() : MulticopterLandDetector(),
+VtolLandDetector::VtolLandDetector() :
 	_paramHandle(),
 	_params(),
 	_airspeedSub(-1),

src/modules/local_position_estimator/BlockLocalPositionEstimator.cpp

@@ -148,10 +148,7 @@ BlockLocalPositionEstimator::BlockLocalPositionEstimator() :
 	// masks
 	_sensorTimeout(255),
 	_sensorFault(0),
-	_estimatorInitialized(0),
+	_estimatorInitialized(0)
-
-	// kf matrices
-	_x(), _u(), _P(), _R_att(), _eul()
 {
 	// assign distance subs to array
 	_dist_subs[0] = &_sub_dist0;

src/modules/sensors/sensors.cpp

@@ -248,7 +248,6 @@ Sensors	*g_sensors = nullptr;
 }
 
 Sensors::Sensors(bool hil_enabled) :
-	_h_adc(),
 	_last_adc(0),
 
 	_task_should_exit(true),
@@ -270,7 +269,6 @@ Sensors::Sensors(bool hil_enabled) :
 
 	/* performance counters */
 	_loop_perf(perf_alloc(PC_ELAPSED, "sensors")),
-	_airspeed_validator(),
 
 	_rc_update(_parameters),
 	_voted_sensors_update(_parameters, hil_enabled)

src/platforms/posix/drivers/gyrosim/gyrosim.cpp

@@ -312,7 +312,6 @@ GYROSIM::GYROSIM(const char *path_accel, const char *path_gyro, enum Rotation ro
 	VirtDevObj("GYROSIM", path_accel, ACCEL_BASE_DEVICE_PATH, 1e6 / 400),
 	_gyro(new GYROSIM_gyro(this, path_gyro)),
 	_product(GYROSIMES_REV_C4),
-	_call{},
 	_accel_reports(nullptr),
 	_accel_scale{},
 	_accel_range_scale(0.0f),

src/systemcmds/tests/test_mixer.cpp

@@ -123,7 +123,7 @@ private:
 	MixerGroup mixer_group;
 };
 
-MixerTest::MixerTest() : UnitTest(),
+MixerTest::MixerTest() :
 	mixer_group(mixer_callback, 0)
 {
 }