dark0707
/
px4-firmware
forked from Archive/PX4-Autopilot
1
0
Fork 0
Code Pull Requests Activity

ROMFS pruner: Detect spurious tabs 

This is necessary to make sure that users cannot insert tabs into shell commands.
This commit is contained in:
Lorenz Meier 2021-03-13 00:22:39 +01:00
parent 21f5f9fba0
commit 3c19853f6c
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Tools/px_romfs_pruner.py
View File

@ -61,6 +61,8 @@ def main():
help="Board architecture for this run") help="Board architecture for this run")
args = parser.parse_args() args = parser.parse_args()
err_count = 0
# go through temp folder # go through temp folder
for (root, dirs, files) in os.walk(args.folder): for (root, dirs, files) in os.walk(args.folder):
for file in files: for file in files:
@ -90,8 +92,17 @@ def main():
# read file line by line # read file line by line
pruned_content = "" pruned_content = ""
board_excluded = False board_excluded = False
with io.open(file_path, "r", newline=None) as f: with io.open(file_path, "r", newline=None) as f:
for line in f: for line in f:
# abort if spurious tabs are found
if re.search(r"[a-zA-Z0-9]+\t.+", line):
file_local = re.sub(args.folder, '', file_path)
print("ERROR: Spurious TAB character in file " + file_local)
print("Line: " + line)
err_count += 1
# find excluded boards
if re.search(r'\b{0} exclude\b'.format(args.board), line): if re.search(r'\b{0} exclude\b'.format(args.board), line):
board_excluded = True board_excluded = True
# handle mixer files differently than startup files # handle mixer files differently than startup files
@ -116,6 +127,9 @@ def main():
else: else:
os.remove(file_path) os.remove(file_path)
if (err_count > 0):
exit(1)
if __name__ == '__main__': if __name__ == '__main__':
main() main()