aepko/Ardupilot2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AP_Mission: limit memcpy to constant 12 bytes

Browse Source 
... essentially to make static analyzers happy
This commit is contained in:
Peter Barker 2019-02-20 15:25:54 +11:00 committed by Peter Barker
parent 556e836a66
commit c594e51922
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/AP_Mission/AP_Mission.cpp
View File

@ -611,7 +611,9 @@ bool AP_Mission::write_cmd_to_storage(uint16_t index, const Mission_Command& cmd
packed.location.lng = cmd.content.location.lng; packed.location.lng = cmd.content.location.lng;
} else { } else {
// all other options in Content are assumed to be packed: // all other options in Content are assumed to be packed:
memcpy(packed.bytes, &cmd.content.jump, sizeof(packed.bytes)); static_assert(sizeof(packed.bytes) >= 12,
"packed.bytes is big enough to take content");
memcpy(packed.bytes, &cmd.content, 12);
} }
// calculate where in storage the command should be placed // calculate where in storage the command should be placed