aepko/Ardupilot2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AP_HAL: Device: remove unused function to read registers

Browse Source 
Callers can use be16toh(), be32toh(), etc. There's no need to have a
special function here for each type.
This commit is contained in:
Lucas De Marchi 2017-01-13 09:36:11 -08:00
parent f6a4a4dbe8
commit a73c1daa2e
2 changed files with 1 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
libraries/AP_HAL/Device.cpp
View File

@ -14,6 +14,7 @@
*/
#include "Device.h"
#include <stdio.h>
/*
@ -107,29 +108,3 @@ bool AP_HAL::Device::check_next_register(void)
_checked.next = (_checked.next+1) % _checked.n_set;
return true;
}
/**
* read 16 bit unsigned integer, little endian
*
* Return: true on a successful transfer, false on failure.
*/
bool AP_HAL::Device::read_uint16_le(uint8_t first_reg, uint16_t &value)
{
// assume we are on a LE platform
return read_registers(first_reg, (uint8_t *)&value, 2);
}
/**
* read 16 bit unsigned integer, big endian
*
* Return: true on a successful transfer, false on failure.
*/
bool AP_HAL::Device::read_uint16_be(uint8_t first_reg, uint16_t &value)
{
if (!read_uint16_le(first_reg, value)) {
return false;
}
uint8_t *b = (uint8_t *)&value;
value = (((uint16_t)b[0])<<8) | b[1];
return true;
}

14
libraries/AP_HAL/Device.h
View File

@ -110,20 +110,6 @@ public:
return transfer(&first_reg, 1, recv, recv_len);
}
/**
* read 16 bit unsigned integer, little endian
*
* Return: true on a successful transfer, false on failure.
*/
bool read_uint16_le(uint8_t first_reg, uint16_t &value);
/**
* read 16 bit unsigned integer, big endian
*
* Return: true on a successful transfer, false on failure.
*/
bool read_uint16_be(uint8_t first_reg, uint16_t &value);
/**
* Wrapper function over #transfer() to write a byte to the register reg.
* The transfer is done by sending reg and val in that order.