From 9959f6b2df68176c713b10732087f7dbb0df5411 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Wed, 10 Jul 2013 11:51:40 +1000 Subject: [PATCH] AP_Camera: removed incorrect mavlink sends these sends did nothing, as MAVLINK_COMM_3 is not connected to anything. If it was connected they would be dangerous, as a blocking serial write could cause the stabilization of a copter not to run. If the serial port was non-blocking it would corrupt the packet. If we needed something like this it would have to use the MAVLink packet queueing logic we use elsewhere --- libraries/AP_Camera/AP_Camera.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/libraries/AP_Camera/AP_Camera.cpp b/libraries/AP_Camera/AP_Camera.cpp index 434146346a..0e702afc71 100644 --- a/libraries/AP_Camera/AP_Camera.cpp +++ b/libraries/AP_Camera/AP_Camera.cpp @@ -177,10 +177,6 @@ AP_Camera::configure_msg(mavlink_message_t* msg) * packet.mode * packet.shutter_speed */ - // echo the message to the ArduCam OSD camera control board - // for more info see: http://code.google.com/p/arducam-osd/ - // TODO is it connected to MAVLINK_COMM_3 ? - mavlink_msg_digicam_configure_send(MAVLINK_COMM_3, packet.target_system, packet.target_component, packet.mode, packet.shutter_speed, packet.aperture, packet.iso, packet.exposure_type, packet.command_id, packet.engine_cut_off, packet.extra_param, packet.extra_value); } /// decode MavLink that controls camera @@ -209,10 +205,6 @@ AP_Camera::control_msg(mavlink_message_t* msg) { trigger_pic(); } - // echo the message to the ArduCam OSD camera control board - // for more info see: http://code.google.com/p/arducam-osd/ - // TODO is it connected to MAVLINK_COMM_3 ? - mavlink_msg_digicam_control_send(MAVLINK_COMM_3, packet.target_system, packet.target_component, packet.session, packet.zoom_pos, packet.zoom_step, packet.focus_lock, packet.shot, packet.command_id, packet.extra_param, packet.extra_value); }