aepko/Ardupilot2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GCS_MAVLink: add nullptr check in gcs_out_of_space_to_send

Browse Source 
If a library were to send on a channel for which we have not allocated a GCS_MAVLINK this could lead to a nullptr dereference.  We do some odd things in uAvionix in terms of which channel to send on, so worth a check.
This commit is contained in:
Peter Barker 2022-12-22 17:31:50 +11:00 committed by Andrew Tridgell
parent 26d714e9a9
commit 74978ac577
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libraries/GCS_MAVLink/GCS.cpp
View File

@ -355,7 +355,11 @@ bool GCS::out_of_time() const
void gcs_out_of_space_to_send(mavlink_channel_t chan)
{
gcs().chan(chan)->out_of_space_to_send();
GCS_MAVLINK *link = gcs().chan(chan);
if (link == nullptr) {
return;
}
link->out_of_space_to_send();
}
/*