aepko/Ardupilot2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AP_Mount: removed create() method for objects

Browse Source 
See discussion here:

  https://github.com/ArduPilot/ardupilot/issues/7331

we were getting some uninitialised variables. While it only showed up in
AP_SbusOut, it means we can't be sure it won't happen on other objects,
so safest to remove the approach

Thanks to assistance from Lucas, Peter and Francisco
This commit is contained in:
Andrew Tridgell 2017-12-13 12:06:13 +11:00
parent c72c1de99e
commit 3d2c81ff05
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libraries/AP_Mount/AP_Mount.h
View File

@ -55,11 +55,7 @@ class AP_Mount
friend class AP_Mount_SToRM32_serial;
public:
static AP_Mount create(const AP_AHRS_TYPE &ahrs, const struct Location &current_loc) {
return AP_Mount{ahrs, current_loc};
}
constexpr AP_Mount(AP_Mount &&other) = default;
AP_Mount(const AP_AHRS_TYPE &ahrs, const struct Location &current_loc);
/* Do not allow copies */
AP_Mount(const AP_Mount &other) = delete;
@ -143,8 +139,6 @@ public:
static const struct AP_Param::GroupInfo var_info[];
protected:
AP_Mount(const AP_AHRS_TYPE &ahrs, const struct Location &current_loc);
// private members
const AP_AHRS_TYPE &_ahrs;
const struct Location &_current_loc; // reference to the vehicle's current location