From 224c32edf06faa1f41562a4eb4629fb0ebfbe0e8 Mon Sep 17 00:00:00 2001 From: Peter Barker Date: Fri, 4 Mar 2022 14:57:14 +1100 Subject: [PATCH] AR_WPNav: stop libraries including AP_Logger.h in .h files AP_Logger.h is a nexus of includes; while this is being improved over time, there's no reason for the library headers to include AP_Logger.h as the logger itself is access by singleton and the structures are in LogStructure.h This necessitated moving The PID_Info structure out of AP_Logger's namespace. This cleans up a pretty nasty bit - that structure is definitely not simply used for logging, but also used to pass pid information around to controllers! There are a lot of patches in here because AP_Logger.h, acting as a nexus, was providing transitive header file inclusion in many (some unlikely!) places. --- libraries/AR_WPNav/AR_PivotTurn.cpp | 1 + libraries/AR_WPNav/AR_WPNav.cpp | 1 + libraries/AR_WPNav/AR_WPNav_OA.cpp | 1 + 3 files changed, 3 insertions(+) diff --git a/libraries/AR_WPNav/AR_PivotTurn.cpp b/libraries/AR_WPNav/AR_PivotTurn.cpp index 5c1965b63c..cc82d9bb82 100644 --- a/libraries/AR_WPNav/AR_PivotTurn.cpp +++ b/libraries/AR_WPNav/AR_PivotTurn.cpp @@ -13,6 +13,7 @@ along with this program. If not, see . */ +#include #include #include #include "AR_PivotTurn.h" diff --git a/libraries/AR_WPNav/AR_WPNav.cpp b/libraries/AR_WPNav/AR_WPNav.cpp index 1d4bbb5b6e..8372180efd 100644 --- a/libraries/AR_WPNav/AR_WPNav.cpp +++ b/libraries/AR_WPNav/AR_WPNav.cpp @@ -13,6 +13,7 @@ along with this program. If not, see . */ +#include #include #include #include "AR_WPNav.h" diff --git a/libraries/AR_WPNav/AR_WPNav_OA.cpp b/libraries/AR_WPNav/AR_WPNav_OA.cpp index 9bbb7ea8c5..97e7b77c58 100644 --- a/libraries/AR_WPNav/AR_WPNav_OA.cpp +++ b/libraries/AR_WPNav/AR_WPNav_OA.cpp @@ -13,6 +13,7 @@ along with this program. If not, see . */ +#include #include #include #include "AR_WPNav_OA.h"