mirror of https://github.com/python/cpython
4d70c3d9dd
merge in bad ways, so I'll have to merge that extra-carefully (probably manually.) Merged revisions 46495-46605 via svnmerge from svn+ssh://pythondev@svn.python.org/python/trunk ........ r46495 | tim.peters | 2006-05-28 03:52:38 +0200 (Sun, 28 May 2006) | 2 lines Added missing svn:eol-style property to text files. ........ r46497 | tim.peters | 2006-05-28 12:41:29 +0200 (Sun, 28 May 2006) | 3 lines PyErr_Display(), PyErr_WriteUnraisable(): Coverity found a cut-and-paste bug in both: `className` was referenced before being checked for NULL. ........ r46499 | fredrik.lundh | 2006-05-28 14:06:46 +0200 (Sun, 28 May 2006) | 5 lines needforspeed: added Py_MEMCPY macro (currently tuned for Visual C only), and use it for string copy operations. this gives a 20% speedup on some string benchmarks. ........ r46501 | michael.hudson | 2006-05-28 17:51:40 +0200 (Sun, 28 May 2006) | 26 lines Quality control, meet exceptions.c. Fix a number of problems with the need for speed code: One is doing this sort of thing: Py_DECREF(self->field); self->field = newval; Py_INCREF(self->field); without being very sure that self->field doesn't start with a value that has a __del__, because that almost certainly can lead to segfaults. As self->args is constrained to be an exact tuple we may as well exploit this fact consistently. This leads to quite a lot of simplification (and, hey, probably better performance). Add some error checking in places lacking it. Fix some rather strange indentation in the Unicode code. Delete some trailing whitespace. More to come, I haven't fixed all the reference leaks yet... ........ r46502 | george.yoshida | 2006-05-28 18:39:09 +0200 (Sun, 28 May 2006) | 3 lines Patch #1080727: add "encoding" parameter to doctest.DocFileSuite Contributed by Bjorn Tillenius. ........ r46503 | martin.v.loewis | 2006-05-28 18:57:38 +0200 (Sun, 28 May 2006) | 4 lines Rest of patch #1490384: Commit icon source, remove claim that Erik von Blokland is the author of the installer picture. ........ r46504 | michael.hudson | 2006-05-28 19:40:29 +0200 (Sun, 28 May 2006) | 16 lines Quality control, meet exceptions.c, round two. Make some functions that should have been static static. Fix a bunch of refleaks by fixing the definition of MiddlingExtendsException. Remove all the __new__ implementations apart from BaseException_new. Rewrite most code that needs it to cope with NULL fields (such code could get excercised anyway, the __new__-removal just makes it more likely). This involved editing the code for WindowsError, which I can't test. This fixes all the refleaks in at least the start of a regrtest -R :: run. ........ r46505 | marc-andre.lemburg | 2006-05-28 19:46:58 +0200 (Sun, 28 May 2006) | 10 lines Initial version of systimes - a module to provide platform dependent performance measurements. The module is currently just a proof-of-concept implementation, but will integrated into pybench once it is stable enough. License: pybench license. Author: Marc-Andre Lemburg. ........ r46507 | armin.rigo | 2006-05-28 21:13:17 +0200 (Sun, 28 May 2006) | 15 lines ("Forward-port" of r46506) Remove various dependencies on dictionary order in the standard library tests, and one (clearly an oversight, potentially critical) in the standard library itself - base64.py. Remaining open issues: * test_extcall is an output test, messy to make robust * tarfile.py has a potential bug here, but I'm not familiar enough with this code. Filed in as SF bug #1496501. * urllib2.HTTPPasswordMgr() returns a random result if there is more than one matching root path. I'm asking python-dev for clarification... ........ r46508 | georg.brandl | 2006-05-28 22:11:45 +0200 (Sun, 28 May 2006) | 4 lines The empty string is a valid import path. (fixes #1496539) ........ r46509 | georg.brandl | 2006-05-28 22:23:12 +0200 (Sun, 28 May 2006) | 3 lines Patch #1496206: urllib2 PasswordMgr ./. default ports ........ r46510 | georg.brandl | 2006-05-28 22:57:09 +0200 (Sun, 28 May 2006) | 3 lines Fix refleaks in UnicodeError get and set methods. ........ r46511 | michael.hudson | 2006-05-28 23:19:03 +0200 (Sun, 28 May 2006) | 3 lines use the UnicodeError traversal and clearing functions in UnicodeError subclasses. ........ r46512 | thomas.wouters | 2006-05-28 23:32:12 +0200 (Sun, 28 May 2006) | 4 lines Make last patch valid C89 so Windows compilers can deal with it. ........ r46513 | georg.brandl | 2006-05-28 23:42:54 +0200 (Sun, 28 May 2006) | 3 lines Fix ref-antileak in _struct.c which eventually lead to deallocating None. ........ r46514 | georg.brandl | 2006-05-28 23:57:35 +0200 (Sun, 28 May 2006) | 4 lines Correct None refcount issue in Mac modules. (Are they still used?) ........ r46515 | armin.rigo | 2006-05-29 00:07:08 +0200 (Mon, 29 May 2006) | 3 lines A clearer error message when passing -R to regrtest.py with release builds of Python. ........ r46516 | georg.brandl | 2006-05-29 00:14:04 +0200 (Mon, 29 May 2006) | 3 lines Fix C function calling conventions in _sre module. ........ r46517 | georg.brandl | 2006-05-29 00:34:51 +0200 (Mon, 29 May 2006) | 3 lines Convert audioop over to METH_VARARGS. ........ r46518 | georg.brandl | 2006-05-29 00:38:57 +0200 (Mon, 29 May 2006) | 3 lines METH_NOARGS functions do get called with two args. ........ r46519 | georg.brandl | 2006-05-29 11:46:51 +0200 (Mon, 29 May 2006) | 4 lines Fix refleak in socketmodule. Replace bogus Py_BuildValue calls. Fix refleak in exceptions. ........ r46520 | nick.coghlan | 2006-05-29 14:43:05 +0200 (Mon, 29 May 2006) | 7 lines Apply modified version of Collin Winter's patch #1478788 Renames functional extension module to _functools and adds a Python functools module so that utility functions like update_wrapper can be added easily. ........ r46522 | georg.brandl | 2006-05-29 15:53:16 +0200 (Mon, 29 May 2006) | 3 lines Convert fmmodule to METH_VARARGS. ........ r46523 | georg.brandl | 2006-05-29 16:13:21 +0200 (Mon, 29 May 2006) | 3 lines Fix #1494605. ........ r46524 | georg.brandl | 2006-05-29 16:28:05 +0200 (Mon, 29 May 2006) | 3 lines Handle PyMem_Malloc failure in pystrtod.c. Closes #1494671. ........ r46525 | georg.brandl | 2006-05-29 16:33:55 +0200 (Mon, 29 May 2006) | 3 lines Fix compiler warning. ........ r46526 | georg.brandl | 2006-05-29 16:39:00 +0200 (Mon, 29 May 2006) | 3 lines Fix #1494787 (pyclbr counts whitespace as superclass name) ........ r46527 | bob.ippolito | 2006-05-29 17:47:29 +0200 (Mon, 29 May 2006) | 1 line simplify the struct code a bit (no functional changes) ........ r46528 | armin.rigo | 2006-05-29 19:59:47 +0200 (Mon, 29 May 2006) | 2 lines Silence a warning. ........ r46529 | georg.brandl | 2006-05-29 21:39:45 +0200 (Mon, 29 May 2006) | 3 lines Correct some value converting strangenesses. ........ r46530 | nick.coghlan | 2006-05-29 22:27:44 +0200 (Mon, 29 May 2006) | 1 line When adding a module like functools, it helps to let SVN know about the file. ........ r46531 | georg.brandl | 2006-05-29 22:52:54 +0200 (Mon, 29 May 2006) | 4 lines Patches #1497027 and #972322: try HTTP digest auth first, and watch out for handler name collisions. ........ r46532 | georg.brandl | 2006-05-29 22:57:01 +0200 (Mon, 29 May 2006) | 3 lines Add News entry for last commit. ........ r46533 | georg.brandl | 2006-05-29 23:04:52 +0200 (Mon, 29 May 2006) | 4 lines Make use of METH_O and METH_NOARGS where possible. Use Py_UnpackTuple instead of PyArg_ParseTuple where possible. ........ r46534 | georg.brandl | 2006-05-29 23:58:42 +0200 (Mon, 29 May 2006) | 3 lines Convert more modules to METH_VARARGS. ........ r46535 | georg.brandl | 2006-05-30 00:00:30 +0200 (Tue, 30 May 2006) | 3 lines Whoops. ........ r46536 | fredrik.lundh | 2006-05-30 00:42:07 +0200 (Tue, 30 May 2006) | 4 lines fixed "abc".count("", 100) == -96 error (hopefully, nobody's relying on the current behaviour ;-) ........ r46537 | bob.ippolito | 2006-05-30 00:55:48 +0200 (Tue, 30 May 2006) | 1 line struct: modulo math plus warning on all endian-explicit formats for compatibility with older struct usage (ugly) ........ r46539 | bob.ippolito | 2006-05-30 02:26:01 +0200 (Tue, 30 May 2006) | 1 line Add a length check to aifc to ensure it doesn't write a bogus file ........ r46540 | tim.peters | 2006-05-30 04:25:25 +0200 (Tue, 30 May 2006) | 10 lines deprecated_err(): Stop bizarre warning messages when the tests are run in the order: test_genexps (or any other doctest-based test) test_struct test_doctest The `warnings` module needs an advertised way to save/restore its internal filter list. ........ r46541 | tim.peters | 2006-05-30 04:26:46 +0200 (Tue, 30 May 2006) | 2 lines Whitespace normalization. ........ r46542 | tim.peters | 2006-05-30 04:30:30 +0200 (Tue, 30 May 2006) | 2 lines Set a binary svn:mime-type property on this UTF-8 encoded file. ........ r46543 | neal.norwitz | 2006-05-30 05:18:50 +0200 (Tue, 30 May 2006) | 1 line Simplify further by using AddStringConstant ........ r46544 | tim.peters | 2006-05-30 06:16:25 +0200 (Tue, 30 May 2006) | 6 lines Convert relevant dict internals to Py_ssize_t. I don't have a box with nearly enough RAM, or an OS, that could get close to tickling this, though (requires a dict w/ at least 2**31 entries). ........ r46545 | neal.norwitz | 2006-05-30 06:19:21 +0200 (Tue, 30 May 2006) | 1 line Remove stray | in comment ........ r46546 | neal.norwitz | 2006-05-30 06:25:05 +0200 (Tue, 30 May 2006) | 1 line Use Py_SAFE_DOWNCAST for safety. Fix format strings. Remove 2 more stray | in comment ........ r46547 | neal.norwitz | 2006-05-30 06:43:23 +0200 (Tue, 30 May 2006) | 1 line No DOWNCAST is required since sizeof(Py_ssize_t) >= sizeof(int) and Py_ReprEntr returns an int ........ r46548 | tim.peters | 2006-05-30 07:04:59 +0200 (Tue, 30 May 2006) | 3 lines dict_print(): Explicitly narrow the return value from a (possibly) wider variable. ........ r46549 | tim.peters | 2006-05-30 07:23:59 +0200 (Tue, 30 May 2006) | 5 lines dict_print(): So that Neal & I don't spend the rest of our lives taking turns rewriting code that works ;-), get rid of casting illusions by declaring a new variable with the obvious type. ........ r46550 | georg.brandl | 2006-05-30 09:04:55 +0200 (Tue, 30 May 2006) | 3 lines Restore exception pickle support. #1497319. ........ r46551 | georg.brandl | 2006-05-30 09:13:29 +0200 (Tue, 30 May 2006) | 3 lines Add a test case for exception pickling. args is never NULL. ........ r46552 | neal.norwitz | 2006-05-30 09:21:10 +0200 (Tue, 30 May 2006) | 1 line Don't fail if the (sub)pkgname already exist. ........ r46553 | georg.brandl | 2006-05-30 09:34:45 +0200 (Tue, 30 May 2006) | 3 lines Disallow keyword args for exceptions. ........ r46554 | neal.norwitz | 2006-05-30 09:36:54 +0200 (Tue, 30 May 2006) | 5 lines I'm impatient. I think this will fix a few more problems with the buildbots. I'm not sure this is the best approach, but I can't think of anything better. If this creates problems, feel free to revert, but I think it's safe and should make things a little better. ........ r46555 | georg.brandl | 2006-05-30 10:17:00 +0200 (Tue, 30 May 2006) | 4 lines Do the check for no keyword arguments in __init__ so that subclasses of Exception can be supplied keyword args ........ r46556 | georg.brandl | 2006-05-30 10:47:19 +0200 (Tue, 30 May 2006) | 3 lines Convert test_exceptions to unittest. ........ r46557 | andrew.kuchling | 2006-05-30 14:52:01 +0200 (Tue, 30 May 2006) | 1 line Add SoC name, and reorganize this section a bit ........ r46559 | tim.peters | 2006-05-30 17:53:34 +0200 (Tue, 30 May 2006) | 11 lines PyLong_FromString(): Continued fraction analysis (explained in a new comment) suggests there are almost certainly large input integers in all non-binary input bases for which one Python digit too few is initally allocated to hold the final result. Instead of assert-failing when that happens, allocate more space. Alas, I estimate it would take a few days to find a specific such case, so this isn't backed up by a new test (not to mention that such a case may take hours to run, since conversion time is quadratic in the number of digits, and preliminary attempts suggested that the smallest such inputs contain at least a million digits). ........ r46560 | fredrik.lundh | 2006-05-30 19:11:48 +0200 (Tue, 30 May 2006) | 3 lines changed find/rfind to return -1 for matches outside the source string ........ r46561 | bob.ippolito | 2006-05-30 19:37:54 +0200 (Tue, 30 May 2006) | 1 line Change wrapping terminology to overflow masking ........ r46562 | fredrik.lundh | 2006-05-30 19:39:58 +0200 (Tue, 30 May 2006) | 3 lines changed count to return 0 for slices outside the source string ........ r46568 | tim.peters | 2006-05-31 01:28:02 +0200 (Wed, 31 May 2006) | 2 lines Whitespace normalization. ........ r46569 | brett.cannon | 2006-05-31 04:19:54 +0200 (Wed, 31 May 2006) | 5 lines Clarify wording on default values for strptime(); defaults are used when better values cannot be inferred. Closes bug #1496315. ........ r46572 | neal.norwitz | 2006-05-31 09:43:27 +0200 (Wed, 31 May 2006) | 1 line Calculate smallest properly (it was off by one) and use proper ssize_t types for Win64 ........ r46573 | neal.norwitz | 2006-05-31 10:01:08 +0200 (Wed, 31 May 2006) | 1 line Revert last checkin, it is better to do make distclean ........ r46574 | neal.norwitz | 2006-05-31 11:02:44 +0200 (Wed, 31 May 2006) | 3 lines On 64-bit platforms running test_struct after test_tarfile would fail since the deprecation warning wouldn't be raised. ........ r46575 | thomas.heller | 2006-05-31 13:37:58 +0200 (Wed, 31 May 2006) | 3 lines PyTuple_Pack is not available in Python 2.3, but ctypes must stay compatible with that. ........ r46576 | andrew.kuchling | 2006-05-31 15:18:56 +0200 (Wed, 31 May 2006) | 1 line 'functional' module was renamed to 'functools' ........ r46577 | kristjan.jonsson | 2006-05-31 15:35:41 +0200 (Wed, 31 May 2006) | 1 line Fixup the PCBuild8 project directory. exceptions.c have moved to Objects, and the functionalmodule.c has been replaced with _functoolsmodule.c. Other minor changes to .vcproj files and .sln to fix compilation ........ r46578 | andrew.kuchling | 2006-05-31 16:08:48 +0200 (Wed, 31 May 2006) | 15 lines [Bug #1473048] SimpleXMLRPCServer and DocXMLRPCServer don't look at the path of the HTTP request at all; you can POST or GET from / or /RPC2 or /blahblahblah with the same results. Security scanners that look for /cgi-bin/phf will therefore report lots of vulnerabilities. Fix: add a .rpc_paths attribute to the SimpleXMLRPCServer class, and report a 404 error if the path isn't on the allowed list. Possibly-controversial aspect of this change: the default makes only '/' and '/RPC2' legal. Maybe this will break people's applications (though I doubt it). We could just set the default to an empty tuple, which would exactly match the current behaviour. ........ r46579 | andrew.kuchling | 2006-05-31 16:12:47 +0200 (Wed, 31 May 2006) | 1 line Mention SimpleXMLRPCServer change ........ r46580 | tim.peters | 2006-05-31 16:28:07 +0200 (Wed, 31 May 2006) | 2 lines Trimmed trailing whitespace. ........ r46581 | tim.peters | 2006-05-31 17:33:22 +0200 (Wed, 31 May 2006) | 4 lines _range_error(): Speed and simplify (there's no real need for loops here). Assert that size_t is actually big enough, and that f->size is at least one. Wrap a long line. ........ r46582 | tim.peters | 2006-05-31 17:34:37 +0200 (Wed, 31 May 2006) | 2 lines Repaired error in new comment. ........ r46584 | neal.norwitz | 2006-06-01 07:32:49 +0200 (Thu, 01 Jun 2006) | 4 lines Remove ; at end of macro. There was a compiler recently that warned about extra semi-colons. It may have been the HP C compiler. This file will trigger a bunch of those warnings now. ........ r46585 | georg.brandl | 2006-06-01 08:39:19 +0200 (Thu, 01 Jun 2006) | 3 lines Correctly unpickle 2.4 exceptions via __setstate__ (patch #1498571) ........ r46586 | georg.brandl | 2006-06-01 10:27:32 +0200 (Thu, 01 Jun 2006) | 3 lines Correctly allocate complex types with tp_alloc. (bug #1498638) ........ r46587 | georg.brandl | 2006-06-01 14:30:46 +0200 (Thu, 01 Jun 2006) | 2 lines Correctly dispatch Faults in loads (patch #1498627) ........ r46588 | georg.brandl | 2006-06-01 15:00:49 +0200 (Thu, 01 Jun 2006) | 3 lines Some code style tweaks, and remove apply. ........ r46589 | armin.rigo | 2006-06-01 15:19:12 +0200 (Thu, 01 Jun 2006) | 5 lines [ 1497053 ] Let dicts propagate the exceptions in user __eq__(). [ 1456209 ] dictresize() vulnerability ( <- backport candidate ). ........ r46590 | tim.peters | 2006-06-01 15:41:46 +0200 (Thu, 01 Jun 2006) | 2 lines Whitespace normalization. ........ r46591 | tim.peters | 2006-06-01 15:49:23 +0200 (Thu, 01 Jun 2006) | 2 lines Record bugs 1275608 and 1456209 as being fixed. ........ r46592 | tim.peters | 2006-06-01 15:56:26 +0200 (Thu, 01 Jun 2006) | 5 lines Re-enable a new empty-string test added during the NFS sprint, but disabled then because str and unicode strings gave different results. The implementations were repaired later during the sprint, but the new test remained disabled. ........ r46594 | tim.peters | 2006-06-01 17:50:44 +0200 (Thu, 01 Jun 2006) | 7 lines Armin committed his patch while I was reviewing it (I'm sure he didn't know this), so merged in some changes I made during review. Nothing material apart from changing a new `mask` local from int to Py_ssize_t. Mostly this is repairing comments that were made incorrect, and adding new comments. Also a few minor code rewrites for clarity or helpful succinctness. ........ r46599 | neal.norwitz | 2006-06-02 06:45:53 +0200 (Fri, 02 Jun 2006) | 1 line Convert docstrings to comments so regrtest -v prints method names ........ r46600 | neal.norwitz | 2006-06-02 06:50:49 +0200 (Fri, 02 Jun 2006) | 2 lines Fix memory leak found by valgrind. ........ r46601 | neal.norwitz | 2006-06-02 06:54:52 +0200 (Fri, 02 Jun 2006) | 1 line More memory leaks from valgrind ........ r46602 | neal.norwitz | 2006-06-02 08:23:00 +0200 (Fri, 02 Jun 2006) | 11 lines Patch #1357836: Prevent an invalid memory read from test_coding in case the done flag is set. In that case, the loop isn't entered. I wonder if rather than setting the done flag in the cases before the loop, if they should just exit early. This code looks like it should be refactored. Backport candidate (also the early break above if decoding_fgets fails) ........ r46603 | martin.blais | 2006-06-02 15:03:43 +0200 (Fri, 02 Jun 2006) | 1 line Fixed struct test to not use unittest. ........ r46605 | tim.peters | 2006-06-03 01:22:51 +0200 (Sat, 03 Jun 2006) | 10 lines pprint functions used to sort a dict (by key) if and only if the output required more than one line. "Small" dicts got displayed in seemingly random order (the hash-induced order produced by dict.__repr__). None of this was documented. Now pprint functions always sort dicts by key, and the docs promise it. This was proposed and agreed to during the PyCon 2006 core sprint -- I just didn't have time for it before now. ........ |
||
---|---|---|
.. | ||
crashers | ||
decimaltestdata | ||
leakers | ||
output | ||
185test.db | ||
README | ||
__init__.py | ||
audiotest.au | ||
autotest.py | ||
bad_coding.py | ||
bad_coding2.py | ||
badsyntax_future3.py | ||
badsyntax_future4.py | ||
badsyntax_future5.py | ||
badsyntax_future6.py | ||
badsyntax_future7.py | ||
badsyntax_future8.py | ||
badsyntax_future9.py | ||
badsyntax_nocaret.py | ||
cfgparser.1 | ||
check_soundcard.vbs | ||
cjkencodings_test.py | ||
doctest_aliases.py | ||
double_const.py | ||
empty.vbs | ||
exception_hierarchy.txt | ||
fork_wait.py | ||
greyrgb.uue | ||
inspect_fodder.py | ||
inspect_fodder2.py | ||
list_tests.py | ||
mapping_tests.py | ||
outstanding_bugs.py | ||
pickletester.py | ||
pyclbr_input.py | ||
pydocfodder.py | ||
pystone.py | ||
re_tests.py | ||
regex_tests.py | ||
regrtest.py | ||
reperf.py | ||
sample_doctest.py | ||
seq_tests.py | ||
sortperf.py | ||
string_tests.py | ||
test.xml | ||
test.xml.out | ||
test_MimeWriter.py | ||
test_StringIO.py | ||
test___all__.py | ||
test___future__.py | ||
test__locale.py | ||
test_aepack.py | ||
test_al.py | ||
test_anydbm.py | ||
test_applesingle.py | ||
test_array.py | ||
test_ast.py | ||
test_asynchat.py | ||
test_atexit.py | ||
test_audioop.py | ||
test_augassign.py | ||
test_base64.py | ||
test_bastion.py | ||
test_bigmem.py | ||
test_binascii.py | ||
test_binhex.py | ||
test_binop.py | ||
test_bisect.py | ||
test_bool.py | ||
test_bsddb.py | ||
test_bsddb3.py | ||
test_bsddb185.py | ||
test_bufio.py | ||
test_builtin.py | ||
test_bytes.py | ||
test_bz2.py | ||
test_cProfile.py | ||
test_calendar.py | ||
test_call.py | ||
test_capi.py | ||
test_cd.py | ||
test_cfgparser.py | ||
test_cgi.py | ||
test_charmapcodec.py | ||
test_cl.py | ||
test_class.py | ||
test_cmath.py | ||
test_cmd_line.py | ||
test_code.py | ||
test_codeccallbacks.py | ||
test_codecencodings_cn.py | ||
test_codecencodings_hk.py | ||
test_codecencodings_jp.py | ||
test_codecencodings_kr.py | ||
test_codecencodings_tw.py | ||
test_codecmaps_cn.py | ||
test_codecmaps_hk.py | ||
test_codecmaps_jp.py | ||
test_codecmaps_kr.py | ||
test_codecmaps_tw.py | ||
test_codecs.py | ||
test_codeop.py | ||
test_coding.py | ||
test_colorsys.py | ||
test_commands.py | ||
test_compare.py | ||
test_compile.py | ||
test_compiler.py | ||
test_complex.py | ||
test_contains.py | ||
test_contextlib.py | ||
test_cookie.py | ||
test_cookielib.py | ||
test_copy.py | ||
test_copy_reg.py | ||
test_cpickle.py | ||
test_crypt.py | ||
test_csv.py | ||
test_ctypes.py | ||
test_curses.py | ||
test_datetime.py | ||
test_dbm.py | ||
test_decimal.py | ||
test_decorators.py | ||
test_defaultdict.py | ||
test_deque.py | ||
test_descr.py | ||
test_descrtut.py | ||
test_dict.py | ||
test_difflib.py | ||
test_difflib_expect.html | ||
test_dircache.py | ||
test_dis.py | ||
test_distutils.py | ||
test_dl.py | ||
test_doctest.py | ||
test_doctest.txt | ||
test_doctest2.py | ||
test_doctest2.txt | ||
test_doctest3.txt | ||
test_doctest4.txt | ||
test_dumbdbm.py | ||
test_dummy_thread.py | ||
test_dummy_threading.py | ||
test_email.py | ||
test_email_codecs.py | ||
test_email_renamed.py | ||
test_enumerate.py | ||
test_eof.py | ||
test_errno.py | ||
test_exception_variations.py | ||
test_exceptions.py | ||
test_extcall.py | ||
test_fcntl.py | ||
test_file.py | ||
test_filecmp.py | ||
test_fileinput.py | ||
test_float.py | ||
test_fnmatch.py | ||
test_fork1.py | ||
test_format.py | ||
test_fpformat.py | ||
test_frozen.py | ||
test_funcattrs.py | ||
test_functools.py | ||
test_future.py | ||
test_future1.py | ||
test_future2.py | ||
test_future3.py | ||
test_gc.py | ||
test_gdbm.py | ||
test_generators.py | ||
test_genexps.py | ||
test_getargs.py | ||
test_getargs2.py | ||
test_getopt.py | ||
test_gettext.py | ||
test_gl.py | ||
test_glob.py | ||
test_global.py | ||
test_grammar.py | ||
test_grp.py | ||
test_gzip.py | ||
test_hash.py | ||
test_hashlib.py | ||
test_heapq.py | ||
test_hexoct.py | ||
test_hmac.py | ||
test_hotshot.py | ||
test_htmllib.py | ||
test_htmlparser.py | ||
test_httplib.py | ||
test_imageop.py | ||
test_imaplib.py | ||
test_imgfile.py | ||
test_imp.py | ||
test_import.py | ||
test_importhooks.py | ||
test_index.py | ||
test_inspect.py | ||
test_ioctl.py | ||
test_isinstance.py | ||
test_iter.py | ||
test_iterlen.py | ||
test_itertools.py | ||
test_largefile.py | ||
test_linuxaudiodev.py | ||
test_list.py | ||
test_locale.py | ||
test_logging.py | ||
test_long.py | ||
test_long_future.py | ||
test_longexp.py | ||
test_macfs.py | ||
test_macostools.py | ||
test_macpath.py | ||
test_mailbox.py | ||
test_marshal.py | ||
test_math.py | ||
test_md5.py | ||
test_mhlib.py | ||
test_mimetools.py | ||
test_mimetypes.py | ||
test_minidom.py | ||
test_mmap.py | ||
test_module.py | ||
test_multibytecodec.py | ||
test_multibytecodec_support.py | ||
test_multifile.py | ||
test_mutants.py | ||
test_netrc.py | ||
test_new.py | ||
test_nis.py | ||
test_normalization.py | ||
test_ntpath.py | ||
test_old_mailbox.py | ||
test_opcodes.py | ||
test_openpty.py | ||
test_operations.py | ||
test_operator.py | ||
test_optparse.py | ||
test_os.py | ||
test_ossaudiodev.py | ||
test_parser.py | ||
test_peepholer.py | ||
test_pep247.py | ||
test_pep263.py | ||
test_pep277.py | ||
test_pep292.py | ||
test_pep352.py | ||
test_pickle.py | ||
test_pickletools.py | ||
test_pkg.py | ||
test_pkgimport.py | ||
test_platform.py | ||
test_plistlib.py | ||
test_poll.py | ||
test_popen.py | ||
test_popen2.py | ||
test_posix.py | ||
test_posixpath.py | ||
test_pow.py | ||
test_pprint.py | ||
test_profile.py | ||
test_profilehooks.py | ||
test_pty.py | ||
test_pwd.py | ||
test_pyclbr.py | ||
test_pyexpat.py | ||
test_queue.py | ||
test_quopri.py | ||
test_random.py | ||
test_re.py | ||
test_repr.py | ||
test_resource.py | ||
test_rfc822.py | ||
test_rgbimg.py | ||
test_richcmp.py | ||
test_robotparser.py | ||
test_runpy.py | ||
test_sax.py | ||
test_scope.py | ||
test_scriptpackages.py | ||
test_select.py | ||
test_set.py | ||
test_sets.py | ||
test_sgmllib.py | ||
test_sha.py | ||
test_shelve.py | ||
test_shlex.py | ||
test_shutil.py | ||
test_signal.py | ||
test_site.py | ||
test_slice.py | ||
test_socket.py | ||
test_socket_ssl.py | ||
test_socketserver.py | ||
test_softspace.py | ||
test_sort.py | ||
test_sqlite.py | ||
test_startfile.py | ||
test_str.py | ||
test_strftime.py | ||
test_string.py | ||
test_stringprep.py | ||
test_strop.py | ||
test_strptime.py | ||
test_struct.py | ||
test_structseq.py | ||
test_subprocess.py | ||
test_sunaudiodev.py | ||
test_sundry.py | ||
test_support.py | ||
test_symtable.py | ||
test_syntax.py | ||
test_sys.py | ||
test_tarfile.py | ||
test_tcl.py | ||
test_tempfile.py | ||
test_textwrap.py | ||
test_thread.py | ||
test_threaded_import.py | ||
test_threadedtempfile.py | ||
test_threading.py | ||
test_threading_local.py | ||
test_threadsignals.py | ||
test_time.py | ||
test_timeout.py | ||
test_tokenize.py | ||
test_trace.py | ||
test_traceback.py | ||
test_transformer.py | ||
test_tuple.py | ||
test_types.py | ||
test_ucn.py | ||
test_unary.py | ||
test_unicode.py | ||
test_unicode_file.py | ||
test_unicodedata.py | ||
test_unittest.py | ||
test_univnewlines.py | ||
test_unpack.py | ||
test_urllib.py | ||
test_urllib2.py | ||
test_urllib2net.py | ||
test_urllibnet.py | ||
test_urlparse.py | ||
test_userdict.py | ||
test_userlist.py | ||
test_userstring.py | ||
test_uu.py | ||
test_wait3.py | ||
test_wait4.py | ||
test_warnings.py | ||
test_wave.py | ||
test_weakref.py | ||
test_whichdb.py | ||
test_winreg.py | ||
test_winsound.py | ||
test_with.py | ||
test_xdrlib.py | ||
test_xml_etree.py | ||
test_xml_etree_c.py | ||
test_xmllib.py | ||
test_xmlrpc.py | ||
test_xpickle.py | ||
test_xrange.py | ||
test_zipfile.py | ||
test_zipimport.py | ||
test_zlib.py | ||
testall.py | ||
testcodec.py | ||
testimg.uue | ||
testimgr.uue | ||
testrgb.uue | ||
testtar.tar | ||
tf_inherit_check.py | ||
threaded_import_hangers.py | ||
time_hashlib.py | ||
tokenize_tests.txt | ||
xmltests.py |
README
+++++++++++++++++++++++++++++++ Writing Python Regression Tests +++++++++++++++++++++++++++++++ :Author: Skip Montanaro :Contact: skip@mojam.com Introduction ============ If you add a new module to Python or modify the functionality of an existing module, you should write one or more test cases to exercise that new functionality. There are different ways to do this within the regression testing facility provided with Python; any particular test should use only one of these options. Each option requires writing a test module using the conventions of the selected option: - PyUnit_ based tests - doctest_ based tests - "traditional" Python test modules Regardless of the mechanics of the testing approach you choose, you will be writing unit tests (isolated tests of functions and objects defined by the module) using white box techniques. Unlike black box testing, where you only have the external interfaces to guide your test case writing, in white box testing you can see the code being tested and tailor your test cases to exercise it more completely. In particular, you will be able to refer to the C and Python code in the CVS repository when writing your regression test cases. .. _PyUnit: .. _unittest: http://www.python.org/doc/current/lib/module-unittest.html .. _doctest: http://www.python.org/doc/current/lib/module-doctest.html PyUnit based tests ------------------ The PyUnit_ framework is based on the ideas of unit testing as espoused by Kent Beck and the `Extreme Programming`_ (XP) movement. The specific interface provided by the framework is tightly based on the JUnit_ Java implementation of Beck's original SmallTalk test framework. Please see the documentation of the unittest_ module for detailed information on the interface and general guidelines on writing PyUnit based tests. The test_support helper module provides two functions for use by PyUnit based tests in the Python regression testing framework: - ``run_unittest()`` takes a ``unittest.TestCase`` derived class as a parameter and runs the tests defined in that class - ``run_suite()`` takes a populated ``TestSuite`` instance and runs the tests ``run_suite()`` is preferred because unittest files typically grow multiple test classes, and you might as well be prepared. All test methods in the Python regression framework have names that start with "``test_``" and use lower-case names with words separated with underscores. Test methods should *not* have docstrings! The unittest module prints the docstring if there is one, but otherwise prints the function name and the full class name. When there's a problem with a test, the latter information makes it easier to find the source for the test than the docstring. All PyUnit-based tests in the Python test suite use boilerplate that looks like this (with minor variations):: import unittest from test import test_support class MyTestCase1(unittest.TestCase): # Define setUp and tearDown only if needed def setUp(self): unittest.TestCase.setUp(self) ... additional initialization... def tearDown(self): ... additional finalization... unittest.TestCase.tearDown(self) def test_feature_one(self): # Testing feature one ...unit test for feature one... def test_feature_two(self): # Testing feature two ...unit test for feature two... ...etc... class MyTestCase2(unittest.TestCase): ...same structure as MyTestCase1... ...etc... def test_main(): suite = unittest.TestSuite() suite.addTest(unittest.makeSuite(MyTestCase1)) suite.addTest(unittest.makeSuite(MyTestCase2)) ...add more suites... test_support.run_suite(suite) if __name__ == "__main__": test_main() This has the advantage that it allows the unittest module to be used as a script to run individual tests as well as working well with the regrtest framework. .. _Extreme Programming: http://www.extremeprogramming.org/ .. _JUnit: http://www.junit.org/ doctest based tests ------------------- Tests written to use doctest_ are actually part of the docstrings for the module being tested. Each test is written as a display of an interactive session, including the Python prompts, statements that would be typed by the user, and the output of those statements (including tracebacks, although only the exception msg needs to be retained then). The module in the test package is simply a wrapper that causes doctest to run over the tests in the module. The test for the difflib module provides a convenient example:: import difflib from test import test_support test_support.run_doctest(difflib) If the test is successful, nothing is written to stdout (so you should not create a corresponding output/test_difflib file), but running regrtest with -v will give a detailed report, the same as if passing -v to doctest. A second argument can be passed to run_doctest to tell doctest to search ``sys.argv`` for -v instead of using test_support's idea of verbosity. This is useful for writing doctest-based tests that aren't simply running a doctest'ed Lib module, but contain the doctests themselves. Then at times you may want to run such a test directly as a doctest, independent of the regrtest framework. The tail end of test_descrtut.py is a good example:: def test_main(verbose=None): from test import test_support, test_descrtut test_support.run_doctest(test_descrtut, verbose) if __name__ == "__main__": test_main(1) If run via regrtest, ``test_main()`` is called (by regrtest) without specifying verbose, and then test_support's idea of verbosity is used. But when run directly, ``test_main(1)`` is called, and then doctest's idea of verbosity is used. See the documentation for the doctest module for information on writing tests using the doctest framework. "traditional" Python test modules --------------------------------- The mechanics of how the "traditional" test system operates are fairly straightforward. When a test case is run, the output is compared with the expected output that is stored in .../Lib/test/output. If the test runs to completion and the actual and expected outputs match, the test succeeds, if not, it fails. If an ``ImportError`` or ``test_support.TestSkipped`` error is raised, the test is not run. Executing Test Cases ==================== If you are writing test cases for module spam, you need to create a file in .../Lib/test named test_spam.py. In addition, if the tests are expected to write to stdout during a successful run, you also need to create an expected output file in .../Lib/test/output named test_spam ("..." represents the top-level directory in the Python source tree, the directory containing the configure script). If needed, generate the initial version of the test output file by executing:: ./python Lib/test/regrtest.py -g test_spam.py from the top-level directory. Any time you modify test_spam.py you need to generate a new expected output file. Don't forget to desk check the generated output to make sure it's really what you expected to find! All in all it's usually better not to have an expected-out file (note that doctest- and unittest-based tests do not). To run a single test after modifying a module, simply run regrtest.py without the -g flag:: ./python Lib/test/regrtest.py test_spam.py While debugging a regression test, you can of course execute it independently of the regression testing framework and see what it prints:: ./python Lib/test/test_spam.py To run the entire test suite: - [UNIX, + other platforms where "make" works] Make the "test" target at the top level:: make test - [WINDOWS] Run rt.bat from your PCBuild directory. Read the comments at the top of rt.bat for the use of special -d, -O and -q options processed by rt.bat. - [OTHER] You can simply execute the two runs of regrtest (optimized and non-optimized) directly:: ./python Lib/test/regrtest.py ./python -O Lib/test/regrtest.py But note that this way picks up whatever .pyc and .pyo files happen to be around. The makefile and rt.bat ways run the tests twice, the first time removing all .pyc and .pyo files from the subtree rooted at Lib/. Test cases generate output based upon values computed by the test code. When executed, regrtest.py compares the actual output generated by executing the test case with the expected output and reports success or failure. It stands to reason that if the actual and expected outputs are to match, they must not contain any machine dependencies. This means your test cases should not print out absolute machine addresses (e.g. the return value of the id() builtin function) or floating point numbers with large numbers of significant digits (unless you understand what you are doing!). Test Case Writing Tips ====================== Writing good test cases is a skilled task and is too complex to discuss in detail in this short document. Many books have been written on the subject. I'll show my age by suggesting that Glenford Myers' `"The Art of Software Testing"`_, published in 1979, is still the best introduction to the subject available. It is short (177 pages), easy to read, and discusses the major elements of software testing, though its publication predates the object-oriented software revolution, so doesn't cover that subject at all. Unfortunately, it is very expensive (about $100 new). If you can borrow it or find it used (around $20), I strongly urge you to pick up a copy. The most important goal when writing test cases is to break things. A test case that doesn't uncover a bug is much less valuable than one that does. In designing test cases you should pay attention to the following: * Your test cases should exercise all the functions and objects defined in the module, not just the ones meant to be called by users of your module. This may require you to write test code that uses the module in ways you don't expect (explicitly calling internal functions, for example - see test_atexit.py). * You should consider any boundary values that may tickle exceptional conditions (e.g. if you were writing regression tests for division, you might well want to generate tests with numerators and denominators at the limits of floating point and integer numbers on the machine performing the tests as well as a denominator of zero). * You should exercise as many paths through the code as possible. This may not always be possible, but is a goal to strive for. In particular, when considering if statements (or their equivalent), you want to create test cases that exercise both the true and false branches. For loops, you should create test cases that exercise the loop zero, one and multiple times. * You should test with obviously invalid input. If you know that a function requires an integer input, try calling it with other types of objects to see how it responds. * You should test with obviously out-of-range input. If the domain of a function is only defined for positive integers, try calling it with a negative integer. * If you are going to fix a bug that wasn't uncovered by an existing test, try to write a test case that exposes the bug (preferably before fixing it). * If you need to create a temporary file, you can use the filename in ``test_support.TESTFN`` to do so. It is important to remove the file when done; other tests should be able to use the name without cleaning up after your test. .. _"The Art of Software Testing": http://www.amazon.com/exec/obidos/ISBN=0471043281 Regression Test Writing Rules ============================= Each test case is different. There is no "standard" form for a Python regression test case, though there are some general rules (note that these mostly apply only to the "classic" tests; unittest_- and doctest_- based tests should follow the conventions natural to those frameworks):: * If your test case detects a failure, raise ``TestFailed`` (found in ``test.test_support``). * Import everything you'll need as early as possible. * If you'll be importing objects from a module that is at least partially platform-dependent, only import those objects you need for the current test case to avoid spurious ``ImportError`` exceptions that prevent the test from running to completion. * Print all your test case results using the ``print`` statement. For non-fatal errors, print an error message (or omit a successful completion print) to indicate the failure, but proceed instead of raising ``TestFailed``. * Use ``assert`` sparingly, if at all. It's usually better to just print what you got, and rely on regrtest's got-vs-expected comparison to catch deviations from what you expect. ``assert`` statements aren't executed at all when regrtest is run in -O mode; and, because they cause the test to stop immediately, can lead to a long & tedious test-fix, test-fix, test-fix, ... cycle when things are badly broken (and note that "badly broken" often includes running the test suite for the first time on new platforms or under new implementations of the language). Miscellaneous ============= There is a test_support module in the test package you can import for your test case. Import this module using either:: import test.test_support or:: from test import test_support test_support provides the following useful objects: * ``TestFailed`` - raise this exception when your regression test detects a failure. * ``TestSkipped`` - raise this if the test could not be run because the platform doesn't offer all the required facilities (like large file support), even if all the required modules are available. * ``ResourceDenied`` - this is raised when a test requires a resource that is not available. Primarily used by 'requires'. * ``verbose`` - you can use this variable to control print output. Many modules use it. Search for "verbose" in the test_*.py files to see lots of examples. * ``forget(module_name)`` - attempts to cause Python to "forget" that it loaded a module and erase any PYC files. * ``is_resource_enabled(resource)`` - Returns a boolean based on whether the resource is enabled or not. * ``requires(resource [, msg])`` - if the required resource is not available the ResourceDenied exception is raised. * ``verify(condition, reason='test failed')``. Use this instead of:: assert condition[, reason] ``verify()`` has two advantages over ``assert``: it works even in -O mode, and it raises ``TestFailed`` on failure instead of ``AssertionError``. * ``have_unicode`` - true if Unicode is available, false otherwise. * ``is_jython`` - true if the interpreter is Jython, false otherwise. * ``TESTFN`` - a string that should always be used as the filename when you need to create a temp file. Also use ``try``/``finally`` to ensure that your temp files are deleted before your test completes. Note that you cannot unlink an open file on all operating systems, so also be sure to close temp files before trying to unlink them. * ``sortdict(dict)`` - acts like ``repr(dict.items())``, but sorts the items first. This is important when printing a dict value, because the order of items produced by ``dict.items()`` is not defined by the language. * ``findfile(file)`` - you can call this function to locate a file somewhere along sys.path or in the Lib/test tree - see test_linuxaudiodev.py for an example of its use. * ``fcmp(x,y)`` - you can call this function to compare two floating point numbers when you expect them to only be approximately equal withing a fuzz factor (``test_support.FUZZ``, which defaults to 1e-6). * ``check_syntax(statement)`` - make sure that the statement is *not* correct Python syntax. Python and C statement coverage results are currently available at http://www.musi-cal.com/~skip/python/Python/dist/src/ As of this writing (July, 2000) these results are being generated nightly. You can refer to the summaries and the test coverage output files to see where coverage is adequate or lacking and write test cases to beef up the coverage. Some Non-Obvious regrtest Features ================================== * Automagic test detection: When you create a new test file test_spam.py, you do not need to modify regrtest (or anything else) to advertise its existence. regrtest searches for and runs all modules in the test directory with names of the form test_xxx.py. * Miranda output: If, when running test_spam.py, regrtest does not find an expected-output file test/output/test_spam, regrtest pretends that it did find one, containing the single line test_spam This allows new tests that don't expect to print anything to stdout to not bother creating expected-output files. * Two-stage testing: To run test_spam.py, regrtest imports test_spam as a module. Most tests run to completion as a side-effect of getting imported. After importing test_spam, regrtest also executes ``test_spam.test_main()``, if test_spam has a ``test_main`` attribute. This is rarely required with the "traditional" Python tests, and you shouldn't create a module global with name test_main unless you're specifically exploiting this gimmick. This usage does prove useful with PyUnit-based tests as well, however; defining a ``test_main()`` which is run by regrtest and a script-stub in the test module ("``if __name__ == '__main__': test_main()``") allows the test to be used like any other Python test and also work with the unittest.py-as-a-script approach, allowing a developer to run specific tests from the command line.