Commit Graph

340 Commits

Author SHA1 Message Date
Senthil Kumaran 4a2ab120f3 Issue #17483: 3.3 Branch - Remove unreachable code in urllib.request 2013-04-04 19:34:02 -07:00
R David Murray c616604a15 Merge: Use repr when printing unknown url type in urlopen. 2013-04-03 07:01:07 -04:00
R David Murray d8a46969f7 Use repr when printing unknown url type in urlopen. 2013-04-03 06:58:34 -04:00
Antoine Pitrou 9a8d6934df Issue #17483: remove unreachable code in urlopen(). 2013-04-01 18:55:35 +02:00
R David Murray 9cc7d45571 #17485: Delete the Content-Length header if the data attribute is deleted.
This is a follow on to issue 16464.  Original patch by Daniel Wozniak.
2013-03-20 00:10:51 -04:00
Senthil Kumaran 41518b4af0 #17474 - Remove the various deprecated methods of Request class. 2013-03-18 18:06:00 -07:00
Serhiy Storchaka c12956ddf2 Issue #1285086: Get rid of the refcounting hack and speed up
urllib.parse.unquote() and urllib.parse.unquote_to_bytes().
2013-03-14 21:34:55 +02:00
Serhiy Storchaka a9d24e6766 Issue #1285086: Get rid of the refcounting hack and speed up
urllib.parse.unquote() and urllib.parse.unquote_to_bytes().
2013-03-14 21:33:35 +02:00
Serhiy Storchaka 8ea4616f16 Issue #1285086: Get rid of the refcounting hack and speed up
urllib.parse.unquote() and urllib.parse.unquote_to_bytes().
2013-03-14 21:31:37 +02:00
Andrew Svetlov f7a17b48d7 Replace IOError with OSError (#16715) 2012-12-25 16:47:37 +02:00
Senthil Kumaran 750909e618 Fix issue16713 - tel url parsing with params 2012-12-24 14:01:48 -08:00
Senthil Kumaran bd6667aae3 Fix issue16713 - tel url parsing with params 2012-12-24 14:01:13 -08:00
Senthil Kumaran ed30199e78 Fix issue16713 - tel url parsing with params 2012-12-24 14:00:20 -08:00
Senthil Kumaran 0a6b9eca68 merge from 3.2
Fix Issue15701 - HTTPError info method call raises AttributeError. Fix that to return headers correctly
2012-12-23 09:12:13 -08:00
Senthil Kumaran 41e66a26b0 Fix Issue15701 - HTTPError info method call raises AttributeError. Fix that to return headers correctly 2012-12-23 09:04:24 -08:00
Andrew Svetlov 2606a6f197 Issue #16719: Get rid of WindowsError. Use OSError instead
Patch by Serhiy Storchaka.
2012-12-19 14:33:35 +02:00
Andrew Svetlov 0832af6628 Issue #16717: get rid of socket.error, replace with OSError 2012-12-18 23:10:48 +02:00
Andrew Svetlov 3438fa496d Get rig of EnvironmentError (#16705) 2012-12-17 23:35:18 +02:00
Senthil Kumaran 5962cce050 Fix Issue15701 : add .headers attribute to urllib.error.HTTPError 2012-12-10 02:09:35 -08:00
Andrew Svetlov bff98fe536 Issue #16464: reset Request's Content-Length header on .data change.
It will be recalculated on sending request to HTTP server.

Patch by Alexey Kachayev
2012-11-27 23:06:19 +02:00
Antoine Pitrou df204be922 Issue #16423: urllib.request now has support for ``data:`` URLs.
Patch by Mathias Panzenböck.
2012-11-24 17:59:08 +01:00
Gregory P. Smith b696610c2d Fixes issue #16409: The reporthook callback made by the legacy
urllib.request.urlretrieve API now properly supplies a constant
non-zero block_size as it did in Python 3.2 and 2.7.  This matches the
behavior of urllib.request.URLopener.retrieve.
2012-11-10 13:44:50 -08:00
Gregory P. Smith 6b0bdab429 Fixes issue #16409: The reporthook callback made by the legacy
urllib.request.urlretrieve API now properly supplies a constant
non-zero block_size as it did in Python 3.2 and 2.7.  This matches the
behavior of urllib.request.URLopener.retrieve.
2012-11-10 13:43:44 -08:00
Senthil Kumaran cc2f0421c7 Issue #16250: Fix URLError invocation with proper args 2012-10-27 02:48:21 -07:00
Senthil Kumaran cad7b31467 Issue #16250: Fix URLError invocation with proper args. 2012-10-27 02:26:46 -07:00
Senthil Kumaran 40d8078f41 Issue #16301: Fix the localhost verification in urllib/request.py for file://. Modify tests to use localhost for local temp files, which could make Windows Buildbot (#16300) happy 2012-10-22 09:43:04 -07:00
Senthil Kumaran 3ebef36eea Issue #16250: Fix the invocations of URLError which had misplaced filename attribute for exception 2012-10-21 18:31:25 -07:00
Senthil Kumaran f577686fd3 Issue #10836: Fix exception raised when file not found in urlretrieve 2012-10-21 13:30:02 -07:00
Nadeem Vawda bd26b5463e Issue #12692: Fix resource leak in urllib.request. 2012-10-21 17:37:43 +02:00
Giampaolo Rodola' 2d51f687e1 Fix issue #16270: urllib may hang when used for retrieving files via FTP by using a context manager. 2012-10-19 13:40:28 +02:00
Giampaolo Rodola' b0cc91290c Fix issue #16270: urllib may hang when used for retrieving files via FTP by using a context manager. 2012-10-19 13:34:32 +02:00
Giampaolo Rodola' 89e92854b6 Fix issue #16270: urllib may hang when used for retrieving files via FTP by using a context manager. 2012-10-19 13:25:17 +02:00
Georg Brandl 491b1dc79e Closes #9374: merge with 3.2 2012-08-24 18:15:46 +02:00
Georg Brandl a61b09f406 Closes #9374: add back now-unused module attributes; removing them is a backward compatibility issue, since they have a public-seeming name. 2012-08-24 18:15:29 +02:00
Senthil Kumaran 612a815820 revert the changes done for issue14826 - quoting witin Request is not desirable. 2012-07-08 18:00:47 -07:00
Senthil Kumaran 168456df11 revert the changes done for issue14826 - quoting witin Request is not desirable. 2012-07-08 17:47:25 -07:00
Senthil Kumaran 25bfb529bd issue 14826 - Address the buildbot failure quote of url is the required change ( explanation msg164973) 2012-07-08 02:16:08 -07:00
Senthil Kumaran 45ce4dc73e issue 14826 - Address the buildbot failure ( explanation msg164973) 2012-07-08 02:08:48 -07:00
Senthil Kumaran 540715a369 Fix issue14826 - make urllib.request.Request quoted url consistent with URLOpener open method.
Patch contributed by Stephen Thorne.
2012-07-07 17:15:52 -07:00
Senthil Kumaran b7451cecad Fix issue14826 - make urllib.request.Request quoted url consistent with URLOpener open method.
Patch contributed by Stephen Thorne.
2012-07-07 17:11:44 -07:00
Senthil Kumaran a1632e65fa urllib.parse cleanup. rename keywords used as variables 2012-06-29 11:08:51 -07:00
Senthil Kumaran eda29f4718 urllib.parse cleanup. rename keywords used as variables 2012-06-29 11:08:20 -07:00
Georg Brandl 496660c56b Partial backport of 612f34e31270: fix spacing error in exception message. 2012-06-24 20:01:05 +02:00
Georg Brandl fcbdbf22e3 urllib.request: fix spacing errors in exception/warning messages. 2012-06-24 19:56:31 +02:00
Senthil Kumaran 4322c178b9 Issue #14920: Fix the help(urllib.parse) failure on locale C terminals. Just have ascii in help msg 2012-05-26 09:55:28 +08:00
Senthil Kumaran ffa4b2c037 Issue #14920: Fix the help(urllib.parse) failure on locale C terminals. Just have ascii in help msg 2012-05-26 09:53:32 +08:00
Senthil Kumaran 4715ca5600 Issue #14036: return None when port in urlparse cross 65535 2012-05-24 21:57:38 +08:00
Senthil Kumaran 2fc5a50809 Issue #14036: return None when port in urlparse cross 65535 2012-05-24 21:56:17 +08:00
Ezio Melotti ed1183db8b #14072: merge with 3.2. 2012-05-19 17:16:22 +03:00
Ezio Melotti 6709b7d5d1 #14072: Fix parsing of tel URIs in urlparse by making the check for ports stricter. 2012-05-19 17:15:19 +03:00
Senthil Kumaran 15e848b076 Issue9374 - Generic parsing of query and fragment portion of urls for any scheme 2012-05-19 08:12:46 +08:00
Senthil Kumaran 1be320ebdd Issue9374 - Generic parsing of query and fragment portion of urls for any scheme 2012-05-19 08:12:00 +08:00
Antoine Pitrou de9ac6c2e5 Issue #14780: urllib.request.urlopen() now has a `cadefault` argument to use the default certificate store.
Initial patch by James Oakley.
2012-05-16 21:40:01 +02:00
Senthil Kumaran 92a5bf0c0a Issue12541 - Add UserWarning for unquoted realms 2012-05-16 00:03:29 +08:00
Senthil Kumaran 0ea91cb5c6 Issue12541 - Add UserWarning for unquoted realms 2012-05-15 23:59:42 +08:00
Senthil Kumaran b26fe2f313 merge from 3.2 - Issue #12541: Be lenient with quotes around Realm field of HTTP Basic Authentation in urllib2. 2012-05-15 22:39:17 +08:00
Senthil Kumaran 34f3fcc269 Issue #12541: Be lenient with quotes around Realm field of HTTP Basic Authentation in urllib2.
G: changed Misc/NEWS
2012-05-15 22:30:25 +08:00
Senthil Kumaran e53d977e80 Explain the use of charset parameter with Content-Type header: issue11082 2012-03-15 18:15:34 -07:00
Senthil Kumaran 6b3434ae04 Explain the use of charset parameter with Content-Type header. Issue11082 2012-03-15 18:11:16 -07:00
Senthil Kumaran 3270d11d8a port from 3.2 - Fix the urllib closing issue which hangs on particular ftp urls/ftp servers. closes issue11199 2012-03-15 13:28:27 -07:00
Senthil Kumaran 73277fe0eb closes Issue #11199: Fix the with urllib which hangs on particular ftp urls. 2012-03-15 13:26:12 -07:00
Senthil Kumaran 38b968b913 deprecated the old urllib primitives in 3.3 urllib package - issue 10050 2012-03-14 13:43:53 -07:00
Senthil Kumaran e24f96a059 Issue10050 - urlretrieve uses newer urlopen. reporthook of urlretrieve takes, block number, block read size, file_size 2012-03-13 19:29:33 -07:00
Senthil Kumaran 3242577a08 merge from 3.2 2012-01-21 11:55:40 +08:00
Senthil Kumaran 3800ea9f65 Fix Issue6631 - Disallow relative file paths in urllib urlopen 2012-01-21 11:52:48 +08:00
Senthil Kumaran 4479577388 merge from 3.2 - Fix Issue #13642: Unquote before b64encoding user:password during Basic Authentication. 2012-01-14 19:12:28 +08:00
Senthil Kumaran c5c5a14577 Fix Issue #13642: Unquote before b64encoding user:password during Basic Authentication. 2012-01-14 19:09:04 +08:00
Senthil Kumaran 6497aa3e00 Issue13696 - Fix 302 Redirection for Relative urls. 2012-01-04 13:46:59 +08:00
Charles-François Natali cf53ae2171 Issue #8035: urllib: Fix a bug where the client could remain stuck after a
redirection or an error.
2011-12-18 16:05:07 +01:00
Senthil Kumaran 239a0429fd merge from 3.2 2012-01-04 14:47:30 +08:00
Charles-François Natali 3c4dcea712 Issue #8035: urllib: Fix a bug where the client could remain stuck after a
redirection or an error.
2011-12-18 16:08:33 +01:00
Jason R. Coombs 0612e8c2a2 Merged fix for #13211 from 3.2 2011-12-03 09:39:58 -05:00
Berker Peksag e88dd1c32c Issue #2202: Fix UnboundLocalError in AbstractDigestAuthHandler.get_algorithm_impls
Raise ValueError if algorithm is not MD5 or SHA.

Initial patch by Mathieu Dupuy.
2016-03-06 16:16:40 +02:00
Martin Panter a03702252f Issue #12923: Reset FancyURLopener's redirect counter even on exception
Based on patches by Brian Brazil and Daniel Rocco.
2016-02-04 06:01:35 +00:00
Senthil Kumaran d4e51f45a9 Remove unnecessary test case comment in urllib.parse.py. These are asserted as test cases. 2016-01-25 18:53:34 -08:00
Robert Collins 1f9a29f31b Issue #24021: docstring for urllib.urlcleanup.
Patch from Daniel Andrade Groppe and Peter Lovett
2015-08-04 12:52:43 +12:00
R David Murray c17686f071 Issue #13866: add *quote_via* argument to urlencode.
Patch by samwyse, completed by Arnon Yaari, and reviewed by
Martin Panter.
2015-05-17 20:44:50 -04:00
Facundo Batista 244afcf26c Issue #23887: urllib.error.HTTPError now has a proper repr() representation. 2015-04-22 18:35:54 -03:00
R David Murray 4c7f995e80 #7159: generalize urllib prior auth support.
This fix is a superset of the functionality introduced by the issue #19494
enhancement, and supersedes that fix.  Instead of a new handler, we have a new
password manager that tracks whether we should send the auth for a given uri.
This allows us to say "always send", satisfying #19494, or track that we've
succeeded in auth and send the creds right away on every *subsequent* request.
The support for using the password manager is added to AbstractBasicAuth,
which means the proxy handler also now can handle prior auth if passed
the new password manager.

Patch by Akshit Khurana, docs mostly by me.
2015-04-16 16:36:18 -04:00
Berker Peksag 20416f7994 Issue #23703: Fix a regression in urljoin() introduced in 901e4e52b20a.
Patch by Demian Brecht.
2015-04-16 02:31:14 +03:00
Serhiy Storchaka 2116b12da5 Issue #23865: close() methods in multiple modules now are idempotent and more
robust at shutdown. If needs to release multiple resources, they are released
even if errors are occured.
2015-04-10 13:29:28 +03:00
Serhiy Storchaka 1515450440 Issue #23411: Added DefragResult, ParseResult, SplitResult, DefragResultBytes,
ParseResultBytes, and SplitResultBytes to urllib.parse.__all__.
Patch by Martin Panter.
2015-04-07 19:09:01 +03:00
Victor Stinner a9dd680d23 (Merge 3.4) Issue #23881: urllib.request.ftpwrapper constructor now closes the
socket if the FTP connection failed to fix a ResourceWarning.
2015-04-07 12:50:24 +02:00
Serhiy Storchaka 44eceb6e2a Issue #23563: Optimized utility functions in urllib.parse. 2015-03-03 20:21:35 +02:00
R David Murray 3ab6ba4744 Merge: #23040: Clarify treatment of encoding and errors when component is bytes. 2014-12-24 21:24:07 -05:00
Benjamin Peterson 074b95da48 merge 3.4 2014-12-07 13:47:39 -05:00
Nick Coghlan c216c48699 Close #19494: add urrlib.request.HTTPBasicPriorAuthHandler
This auth handler adds the Authorization header to the first
HTTP request rather than waiting for a HTTP 401 Unauthorized
response from the server as the default HTTPBasicAuthHandler
does.

This allows working with websites like https://api.github.com which do
not follow the strict interpretation of RFC, but more the dicta in the
end of section 2 of RFC 2617:

    > A client MAY preemptively send the corresponding Authorization
    > header with requests for resources in that space without receipt
    > of another challenge from the server.  Similarly, when a client
    > sends a request to a proxy, it may reuse a userid and password in
    > the Proxy-Authorization header field without receiving another
    > challenge from the proxy server. See section 4 for security
    > considerations associated with Basic authentication.

Patch by Matej Cepl.
2014-11-12 23:33:50 +10:00
Senthil Kumaran a66e3885fb Issue #22278: Fix urljoin problem with relative urls, a regression observed
after changes to issue22118 were submitted.

Patch contributed by Demian Brecht and reviewed by Antoine Pitrou.
2014-09-22 15:49:16 +08:00
Senthil Kumaran a5c85b3f5f Issue #22366: urllib.request.urlopen will accept a context object (SSLContext)
as an argument which will then used be for HTTPS connection.

Patch by Alex Gaynor.
2014-09-19 15:23:30 +08:00
Serhiy Storchaka 91453026ff Issue #19524: Fixed resource leak in the HTTP connection when an invalid
response is received.  Patch by Martin Panter.
2014-09-06 21:43:49 +03:00
Antoine Pitrou 55ac5b3f7b Issue #22118: Switch urllib.parse to use RFC 3986 semantics for the resolution of relative URLs, rather than RFCs 1808 and 2396.
Patch by Demian Brecht.
2014-08-21 19:16:17 -04:00
Senthil Kumaran 2b7ccbda90 merge from 3.4
Fix Issue #8797: Raise HTTPError on failed Basic Authentication immediately. Initial patch by Sam Bull.
2014-08-20 07:55:53 +05:30
Senthil Kumaran e2953e5146 merge 3.4; backout changeset 3435c5865cfc due to buildbot failures. Ref #8797 2014-08-16 22:54:24 +05:30
Senthil Kumaran 39e6c07beb merge from 3.4
Fix Issue #8797: Raise HTTPError on failed Basic Authentication immediately. Initial patch by Sam Bull.
2014-08-16 14:19:09 +05:30
Serhiy Storchaka 465e60e654 Issue #22033: Reprs of most Python implemened classes now contain actual
class name instead of hardcoded one.
2014-07-25 23:36:00 +03:00
Senthil Kumaran 284a4a1bb0 Merge 3.4
Fix localhost checking in FileHandler. Raised in #21970.
2014-07-22 00:16:18 -07:00
Benjamin Peterson edb07d28fb merge 3.4 (#21463) 2014-06-07 15:09:36 -07:00
Raymond Hettinger 38acd4c028 Issue 21469: Minor code modernization (convert and/or expression to an if/else expression).
Suggested by: Tal Einat
2014-05-12 22:22:46 -07:00
Jason R. Coombs aa204dbe9c Issue #13211: Add .reason attribute to HTTPError to implement parent class (URLError) interface. 2011-11-07 10:50:32 -05:00
Senthil Kumaran 4c875a986f 'HTTPSHandler' and not the type. 2011-11-01 23:57:57 +08:00