cpython

Commit Graph

Author	SHA1	Message	Date
Petr Viktorin	664e96a98f	gh-93649: Split heaptype tests from _testcapimodule.c (GH-95386) This removes the unused negative_dictoffset function: the type this function would create is available as _testcapi.HeapCTypeWithNegativeDict	2022-08-01 15:04:14 +02:00
Oleg Iarygin	fc21a43b1f	gh-93649: Fix linkage of _PyTestCapi_Init_Vectorcall (#94702 )	2022-07-13 13:22:45 +02:00
Petr Viktorin	be862b4e55	gh-93649: Split vectorcall testing from _testcapimodule.c (GH-94549) The `_testcapimodule.c` file is getting too large to work with effectively. This PR lays out a general structure of how tests can be split up, with more splitting to come later if the structure is OK. Vectorcall tests aren't the biggest issue -- it's just an area I want to work on next, so I'm starting here. An issue specific to vectorcall tests is that it wasn't clear that e.g. `MethodDescriptor2` is related to testing vectorcall: the `/* Test PEP 590 */` section had an ambiguous end. Separate file should make things like this much clearer. OTOH, for some pieces it might not be clear where they should be -- I left `meth_fastcall` with tests of the other calling conventions. IMO, even with the ambiguity it's still worth it to split the huge file up. I'm not sure about the buildsystem changes, hopefully CI will tell me what's wrong. @vstinner, @markshannon: Do you think this is a good idea? Automerge-Triggered-By: GH:encukou	2022-07-08 08:56:26 -07:00

Author

SHA1

Message

Date

Petr Viktorin

664e96a98f

gh-93649: Split heaptype tests from _testcapimodule.c (GH-95386)

This removes the unused negative_dictoffset function:
the type this function would create is available as
    _testcapi.HeapCTypeWithNegativeDict

2022-08-01 15:04:14 +02:00

Oleg Iarygin

fc21a43b1f

gh-93649: Fix linkage of _PyTestCapi_Init_Vectorcall (#94702 )

2022-07-13 13:22:45 +02:00

Petr Viktorin

be862b4e55

gh-93649: Split vectorcall testing from _testcapimodule.c (GH-94549)

The `_testcapimodule.c` file is getting too large to work with effectively.
This PR lays out a general structure of how tests can be split up, with more splitting to come later if the structure is OK.

Vectorcall tests aren't the biggest issue -- it's just an area I want to work on next, so I'm starting here.
An issue specific to vectorcall tests is that it wasn't clear that e.g. `MethodDescriptor2` is related to testing vectorcall: the `/* Test PEP 590 */` section had an ambiguous end. Separate file should make things like this much clearer.
OTOH, for some pieces it might not be clear where they should be -- I left `meth_fastcall` with tests of the other calling conventions. IMO, even with the ambiguity it's still worth it to split the huge file up.

I'm not sure about the buildsystem changes, hopefully CI will tell me what's wrong.

@vstinner, @markshannon: Do you think this is a good idea?

Automerge-Triggered-By: GH:encukou

2022-07-08 08:56:26 -07:00

1 2

53 Commits