Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity
123,676 Commits 6 Branches 593 Tags 2.8 GiB
Commit Graph

18 Commits

Author SHA1 Message Date
Kumar Aditya 03f5abf15a
gh-123089: Make weakref.WeakSet safe against concurrent mutations while it is being iterated (#123279) 
* Make `weakref.WeakSet` safe against concurrent mutations while it is being iterated.

`_IterationGuard` is no longer used for `WeakSet`, it now relies on copying the underlying set which is an atomic operation while iterating so that it can be modified by other threads.
 2024-08-27 13:04:03 +00:00
Serhiy Storchaka 884eba3c76
bpo-26579: Add object.__getstate__(). (GH-2821) 
Copying and pickling instances of subclasses of builtin types
bytearray, set, frozenset, collections.OrderedDict, collections.deque,
weakref.WeakSet, and datetime.tzinfo now copies and pickles instance attributes
implemented as slots.
 2022-04-06 20:00:14 +03:00
Thomas Grainger 206b21ed9f
bpo-44962: Fix a race in WeakKeyDict, WeakValueDict and WeakSet when two threads attempt to commit the last pending removal (GH-27921) 
Fixes:
Traceback (most recent call last):
  File "/home/graingert/projects/asyncio-demo/demo.py", line 36, in <module>
    sys.exit(main())
  File "/home/graingert/projects/asyncio-demo/demo.py", line 30, in main
    test_all_tasks_threading()
  File "/home/graingert/projects/asyncio-demo/demo.py", line 24, in test_all_tasks_threading
    results.append(f.result())
  File "/usr/lib/python3.10/concurrent/futures/_base.py", line 438, in result
    return self.__get_result()
  File "/usr/lib/python3.10/concurrent/futures/_base.py", line 390, in __get_result
    raise self._exception
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 52, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.10/asyncio/runners.py", line 47, in run
    _cancel_all_tasks(loop)
  File "/usr/lib/python3.10/asyncio/runners.py", line 56, in _cancel_all_tasks
    to_cancel = tasks.all_tasks(loop)
  File "/usr/lib/python3.10/asyncio/tasks.py", line 53, in all_tasks
    tasks = list(_all_tasks)
  File "/usr/lib/python3.10/_weakrefset.py", line 60, in __iter__
    with _IterationGuard(self):
  File "/usr/lib/python3.10/_weakrefset.py", line 33, in __exit__
    w._commit_removals()
  File "/usr/lib/python3.10/_weakrefset.py", line 57, in _commit_removals
    discard(l.pop())
IndexError: pop from empty list

Also fixes:
Exception ignored in: weakref callback <function WeakKeyDictionary.__init__.<locals>.remove at 0x00007fe82245d2e0>
Traceback (most recent call last):
  File "/usr/lib/pypy3/lib-python/3/weakref.py", line 390, in remove
    del self.data[k]
KeyError: <weakref at 0x00007fe76e8d8180; dead>
Exception ignored in: weakref callback <function WeakKeyDictionary.__init__.<locals>.remove at 0x00007fe82245d2e0>
Traceback (most recent call last):
  File "/usr/lib/pypy3/lib-python/3/weakref.py", line 390, in remove
    del self.data[k]
KeyError: <weakref at 0x00007fe76e8d81a0; dead>
Exception ignored in: weakref callback <function WeakKeyDictionary.__init__.<locals>.remove at 0x00007fe82245d2e0>
Traceback (most recent call last):
  File "/usr/lib/pypy3/lib-python/3/weakref.py", line 390, in remove
    del self.data[k]
KeyError: <weakref at 0x000056548f1e24a0; dead>

See: https://github.com/agronholm/anyio/issues/362#issuecomment-904424310
See also: https://bugs.python.org/issue29519

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
 2021-08-28 19:07:37 +02:00
Ethan Smith 8ef875028a
bpo-39481: Make weakref and WeakSet generic (GH-19497) 2020-04-13 21:54:40 -07:00
Batuhan Taşkaya 5ae1c84bcd bpo-36949: Implement __repr__ on WeakSet (GH-13415) 2019-05-20 10:01:07 -07:00
Jon Dufresne 3972628de3 bpo-30296 Remove unnecessary tuples, lists, sets, and dicts (#1489) 
* Replaced list(<generator expression>) with list comprehension
* Replaced dict(<generator expression>) with dict comprehension
* Replaced set(<list literal>) with set literal
* Replaced builtin func(<list comprehension>) with func(<generator
  expression>) when supported (e.g. any(), all(), tuple(), min(), &
  max())
 2017-05-18 07:35:54 -07:00
Serhiy Storchaka 5affd23e6f bpo-29762: More use "raise from None". (#569) 
This hides unwanted implementation details from tracebacks.
 2017-04-05 09:37:24 +03:00
Antoine Pitrou 320b39158e Issue #20006: Fix sporadic failures in test_weakset. 2013-12-18 00:28:36 +01:00
Meador Inge 653f932eff Issue #14195: Make WeakSet.__lt__ and WeakSet.__gt__ irreflexive. 2012-03-04 22:15:38 -06:00
Antoine Pitrou 9c47ac05d1 Fix some set algebra methods of WeakSet objects. 2012-03-04 20:47:05 +01:00
Antoine Pitrou de89d4b097 Port 2.7 fix for sporadic failure in test_weakset. 2012-03-04 20:20:34 +01:00
Antoine Pitrou bbe2f60b3c Issue #14159: Fix the len() of weak containers (WeakSet, WeakKeyDictionary, WeakValueDictionary) to return a better approximation when some objects are dead or dying. 
Moreover, the implementation is now O(1) rather than O(n).
Thanks to Yury Selivanov for reporting.
 2012-03-01 16:26:35 +01:00
Georg Brandl f8de3fea12 #10360: catch TypeError in WeakSet.__contains__, just like WeakKeyDictionary does. 2010-12-03 07:55:44 +00:00
Antoine Pitrou c1baa601e2 Issue #7105: Make WeakKeyDictionary and WeakValueDictionary robust against 
the destruction of weakref'ed objects while iterating.
 2010-01-08 17:54:23 +00:00
Robert Schuppenies 4ad1d6f81a Issue 5964: Fixed WeakSet __eq__ comparison to handle non-WeakSet objects. 2009-05-17 17:32:20 +00:00
Georg Brandl 9dba5d9764 Add a test suite for WeakSet mostly derived from test_set and fix some 
issues in the weakset implementation discovered with it.
 2008-05-18 16:27:29 +00:00
Georg Brandl bf93b0470a Fix two issues in the weak set implementation. 2008-05-18 07:46:13 +00:00
Raymond Hettinger 93fa608626 Moved WeakSet into a bootstap module use by abc.py. 
This makes it possible to use ABCs in weakref.py
(which will be done in a later checkin).
 2008-02-05 00:20:01 +00:00