ffd9753a94
bpo-39245: Switch to public API for Vectorcall (GH-18460)
...
The bulk of this patch was generated automatically with:
for name in \
PyObject_Vectorcall \
Py_TPFLAGS_HAVE_VECTORCALL \
PyObject_VectorcallMethod \
PyVectorcall_Function \
PyObject_CallOneArg \
PyObject_CallMethodNoArgs \
PyObject_CallMethodOneArg \
;
do
echo $name
git grep -lwz _$name | xargs -0 sed -i "s/\b_$name\b/$name/g"
done
old=_PyObject_FastCallDict
new=PyObject_VectorcallDict
git grep -lwz $old | xargs -0 sed -i "s/\b$old\b/$new/g"
and then cleaned up:
- Revert changes to in docs & news
- Revert changes to backcompat defines in headers
- Nudge misaligned comments
2020-02-11 17:46:57 +01:00
3368f3c6ae
bpo-38140: Make dict and weakref offsets opaque for C heap types ( #16076 )
...
* Make dict and weakref offsets opaque for C heap types
* Add news
2019-09-19 17:29:05 +01:00
2ec7010206
bpo-37752: Delete redundant Py_CHARMASK in normalizestring() (GH-15095)
2019-09-10 17:04:08 +01:00
4f384af067
bpo-38076: Make struct module PEP-384 compatible ( #15805 )
...
* PEP-384 _struct
* More PEP-384 fixes for _struct
Summary: Add a couple of more fixes for `_struct` that were previously missed such as removing `tp_*` accessors and using `PyBytesWriter` instead of calling `PyBytes_FromStringAndSize` with `NULL`. Also added a test to confirm that `iter_unpack` type is still uninstantiable.
* 📜 🤖 Added by blurb_it.
2019-09-10 03:18:37 -07:00
c4cacc8c5e
Fix typos in comments, docs and test names ( #15018 )
...
* Fix typos in comments, docs and test names
* Update test_pyparse.py
account for change in string length
* Apply suggestion: splitable -> splittable
Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>
* Apply suggestion: splitable -> splittable
Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>
* Apply suggestion: Dealloccte -> Deallocate
Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>
* Update posixmodule checksum.
* Reverse idlelib changes.
2019-07-30 18:16:13 -04:00
196a530e00
bpo-37483: add _PyObject_CallOneArg() function ( #14558 )
2019-07-04 19:31:34 +09:00
530f506ac9
bpo-36974: tp_print -> tp_vectorcall_offset and tp_reserved -> tp_as_async (GH-13464)
...
Automatically replace
tp_print -> tp_vectorcall_offset
tp_compare -> tp_as_async
tp_reserved -> tp_as_async
2019-05-30 19:13:39 -07:00
a24107b04c
bpo-35459: Use PyDict_GetItemWithError() instead of PyDict_GetItem(). (GH-11112)
2019-02-25 17:59:46 +02:00
32d96a2b5b
bpo-23867: Argument Clinic: inline parsing code for a single positional parameter. (GH-9689)
2018-12-25 13:23:47 +02:00
62be74290a
bpo-33012: Fix invalid function cast warnings with gcc 8. (GH-6749)
...
Fix invalid function cast warnings with gcc 8
for method conventions different from METH_NOARGS, METH_O and
METH_VARARGS excluding Argument Clinic generated code.
2018-11-27 13:27:31 +02:00
55edd0c185
bpo-33012: Fix invalid function cast warnings with gcc 8 for METH_NOARGS. (GH-6030)
...
METH_NOARGS functions need only a single argument but they are cast
into a PyCFunction, which takes two arguments. This triggers an
invalid function cast warning in gcc8 due to the argument mismatch.
Fix this by adding a dummy unused argument.
2018-04-29 21:59:33 +03:00
c10b288f34
bpo-30249: Improve struct.unpack_from() error messages (GH-6059)
2018-03-11 02:58:52 +08:00
a5552f023e
bpo-32240: Add the const qualifier to declarations of PyObject* array arguments. ( #4746 )
2017-12-15 13:11:11 +02:00
c3e97d9d98
bpo-30246: fix several error messages which only mention bytes in struct ( #1421 )
2017-09-14 10:33:26 +08:00
a6296d34a4
bpo-31095: fix potential crash during GC (GH-2974)
2017-08-24 14:55:17 +09:00
6969eaf468
bpo-29464: Rename METH_FASTCALL to METH_FASTCALL|METH_KEYWORDS and make ( #1955 )
...
the bare METH_FASTCALL be used for functions with positional-only
parameters.
2017-07-03 21:20:15 +03:00
f87b85f808
bpo-21071: struct.Struct.format type is now str ( #845 )
2017-06-23 15:11:12 +02:00
96c7c06850
bpo-20627: Fix error message when keyword arguments are used ( #2115 )
2017-06-15 18:05:23 +03:00
aead53b6ee
bpo-30245: Fix possible overflow when organize struct.pack_into error message ( #1682 )
2017-06-02 14:33:04 +08:00
981096f98b
bpo-30242: resolve some undefined behaviours in struct ( #1418 )
2017-05-15 12:04:26 +08:00
96f5028567
bpo-30224: remove outdated checks in struct ( #1374 )
2017-05-15 11:53:51 +08:00
40db90c1ce
bpo-29802: Fix reference counting in module-level struct functions ( #1213 )
...
when pass arguments of wrong type.
2017-04-20 21:19:31 +03:00
f78b119364
bpo-29649: Improve struct.pack_into() boundary error messages ( #424 )
2017-04-04 13:46:25 +03:00
a5a55902c1
Issue #29300 : Use Argument Clinic for getting struct object from the format.
2017-02-04 11:14:52 +02:00
c0f59ad145
Rename struct.unpack() 2nd parameter to "buffer"
...
Issue #29300 : Rename struct.unpack() second parameter from "inputstr" to
"buffer", and use the Py_buffer type.
Fix also unit tests on struct.unpack() which passed a Unicode string instead of
a bytes string as struct.unpack() second parameter. The purpose of
test_trailing_counter() is to test invalid format strings, not to test the
buffer parameter.
2017-02-02 14:24:16 +01:00
3f2d10132d
Issue #29300 : Convert _struct module to Argument Clinic
...
* The struct module now requires contiguous buffers.
* Convert most functions and methods of the _struct module to Argument Clinic
* Use "Py_buffer" type for the "buffer" argument. Argument Clinic is
responsible to create and release the Py_buffer object.
* Use "PyStructObject *" type for self to avoid explicit conversions.
* Add an unit test on the _struct.Struct.unpack_from() method to test passing
arguments as keywords.
* Rephrase docstrings.
* Rename "fmt" argument to "format" in docstrings and the documentation.
As a side effect, functions and methods which used METH_VARARGS calling
convention like struct.pack() now use the METH_FASTCALL calling convention
which avoids the creation of temporary tuple to pass positional arguments and
so is faster. For example, struct.pack("i", 1) becomes 1.56x faster (-36%)::
$ ./python -m perf timeit \
-s 'import struct; pack=struct.pack' 'pack("i", 1)' \
--compare-to=../default-ref/python
Median +- std dev: 119 ns +- 1 ns -> 76.8 ns +- 0.4 ns: 1.56x faster (-36%)
Significant (t=295.91)
Patch co-written with Serhiy Storchaka.
2017-02-02 12:09:30 +01:00
5ab81d787f
Issue #28959 : Added private macro PyDict_GET_SIZE for retrieving the size of dict.
2016-12-16 16:18:57 +02:00
de4ae3d486
Backed out changeset b9c9691c72c5
...
Issue #28858 : The change b9c9691c72c5 introduced a regression. It seems like
_PyObject_CallArg1() uses more stack memory than
PyObject_CallFunctionObjArgs().
2016-12-04 22:59:09 +01:00
27580c1fb5
Replace PyObject_CallFunctionObjArgs() with fastcall
...
* PyObject_CallFunctionObjArgs(func, NULL) => _PyObject_CallNoArg(func)
* PyObject_CallFunctionObjArgs(func, arg, NULL) => _PyObject_CallArg1(func, arg)
PyObject_CallFunctionObjArgs() allocates 40 bytes on the C stack and requires
extra work to "parse" C arguments to build a C array of PyObject*.
_PyObject_CallNoArg() and _PyObject_CallArg1() are simpler and don't allocate
memory on the C stack.
This change is part of the fastcall project. The change on listsort() is
related to the issue #23507 .
2016-12-01 14:43:22 +01:00
99f11b48cd
Closes #21124 , #28337 : Call PyType_Ready on unpackiter_type.
...
Patch by Masayuki Yamamoto.
2016-10-04 01:20:21 -05:00
854adb1e01
Issue #21124 : Fix building _struct on Cygwin.
...
Patch by Masayuki Yamamoto.
2016-10-02 00:33:39 -05:00
e2e792d98f
merge 3.5 ( #28184 )
2016-09-19 22:17:16 -07:00
a9296e7f3b
require C99 bool
2016-09-07 11:06:17 -07:00
af580dff4a
replace PY_LONG_LONG with long long
2016-09-06 10:46:49 -07:00
ed4aa83ff7
require a long long data type ( closes #27961 )
2016-09-05 17:44:18 -07:00
7c4e409d07
Issue #11734 : Add support for IEEE 754 half-precision floats to the struct module. Original patch by Eli Stevens.
2016-09-03 17:21:29 +01:00
b0c6380640
merge heads
2016-04-15 16:47:32 -07:00
b030991a5f
Issue #26535 : Correct docs regarding the struct buffer size
2016-04-15 23:03:54 +00:00
ec39756960
Issue #22570 : Renamed Py_SETREF to Py_XSETREF.
2016-04-06 09:50:03 +03:00
48842714b9
Issue #22570 : Renamed Py_SETREF to Py_XSETREF.
2016-04-06 09:45:48 +03:00
bdb908ea54
Issue #20440 : Applied yet one patch for using Py_SETREF.
...
The patch is automatically generated, it replaces the code that uses Py_CLEAR.
2015-12-27 12:38:28 +02:00
4a1e70fc31
Issue #20440 : Applied yet one patch for using Py_SETREF.
...
The patch is automatically generated, it replaces the code that uses Py_CLEAR.
2015-12-27 12:36:18 +02:00
ef1585eb9a
Issue #25923 : Added more const qualifiers to signatures of static and private functions.
2015-12-25 20:01:53 +02:00
2d06e84455
Issue #25923 : Added the const qualifier to static constant arrays.
2015-12-25 19:53:18 +02:00
5c4064e8bd
Issue #25421 : __sizeof__ methods of builtin types now use dynamic basic size.
...
This allows sys.getsize() to work correctly with their subclasses with
__slots__ defined.
2015-12-19 20:05:25 +02:00
3dd3e26680
Issue #22896 : Avoid to use PyObject_AsCharBuffer(), PyObject_AsReadBuffer()
...
and PyObject_AsWriteBuffer().
2015-02-03 01:25:42 +02:00
4fdb68491e
Issue #22896 : Avoid to use PyObject_AsCharBuffer(), PyObject_AsReadBuffer()
...
and PyObject_AsWriteBuffer().
2015-02-03 01:21:08 +02:00
706768c687
Issue #22156 : Fix some "comparison between signed and unsigned integers"
...
compiler warnings in the Modules/ subdirectory.
2014-08-16 01:03:39 +02:00
45e8e2f218
Issue #21490 : Add new C macros: Py_ABS() and Py_STRINGIFY()
...
Keep _Py_STRINGIZE() in PC/pyconfig.h to not introduce a dependency between
pyconfig.h and pymacros.h.
2014-05-14 17:24:35 +02:00
46c5deb130
- Modules/_struct.c (unpackiter_type): Define static.
2013-11-23 16:07:55 +01:00
46e1ce214b
Issue #18783 : Removed existing mentions of Python long type in docstrings,
...
error messages and comments.
2013-08-27 20:17:03 +03:00
9594942716
Issue #18783 : Removed existing mentions of Python long type in docstrings,
...
error messages and comments.
2013-08-27 19:40:23 +03:00
fff61f2cd3
Issue #14596 : The struct.Struct() objects now use more compact implementation.
2013-05-17 10:49:44 +03:00
9f14681959
Issue #17804 : New function ``struct.iter_unpack`` allows for streaming struct unpacking.
2013-04-27 00:20:04 +02:00
8ad5b07ccb
Issue #17173 : Remove uses of locale-dependent C functions (isalpha() etc.) in the interpreter.
...
I've left a couple of them in: zlib (third-party lib), getaddrinfo.c
(doesn't include Python.h, and probably obsolete), _sre.c (legitimate
use for the re.LOCALE flag), mpdecimal (needs to build without Python.h).
2013-02-09 23:16:51 +01:00
c73c561181
Issue #17173 : Remove uses of locale-dependent C functions (isalpha() etc.) in the interpreter.
...
I've left a couple of them in: zlib (third-party lib), getaddrinfo.c
(doesn't include Python.h, and probably obsolete), _sre.c (legitimate
use for the re.LOCALE flag), mpdecimal (needs to build without Python.h).
2013-02-09 23:14:42 +01:00
4de7457009
Issue #17173 : Remove uses of locale-dependent C functions (isalpha() etc.) in the interpreter.
...
I've left a couple of them in: zlib (third-party lib), getaddrinfo.c
(doesn't include Python.h, and probably obsolete), _sre.c (legitimate
use for the re.LOCALE flag).
2013-02-09 23:11:27 +01:00
f1380557e3
#14897 : Enhance error messages of struct.pack and struct.pack_into
...
Patch by Matti Mäki.
2012-10-29 21:26:56 +02:00
4648b4779a
#14897 : Enhance error messages of struct.pack and struct.pack_into
...
Patch by Matti Mäki.
2012-10-29 21:25:01 +02:00
92c28cace4
#14897 : Enhance error messages of struct.pack and struct.pack_into
...
Patch by Matti Mäki.
2012-10-29 21:24:07 +02:00
743e0cd6b5
Issue #16166 : Add PY_LITTLE_ENDIAN and PY_BIG_ENDIAN macros and unified
...
endianess detection and handling.
2012-10-17 23:52:17 +02:00
bb9b1c165d
Issue #15402 : Simplify Struct.__sizeof__ and make tests more precise.
2012-07-28 22:32:50 -05:00
90bc2dbcce
Issue #15402 : Simplify Struct.__sizeof__ and make tests more precise.
2012-07-28 22:16:39 -05:00
9f65899d19
Issue #15402 : Add a __sizeof__ method to struct.Struct.
...
Initial patch by Serhiy Storchaka.
2012-07-23 10:22:36 -05:00
b14d8c9bcf
Issue #15402 : Add a __sizeof__ method to struct.Struct.
...
Initial patch by Serhiy Storchaka.
2012-07-23 10:01:29 -05:00
45d9c91d4b
Issue #3163 : The struct module gets new format characters 'n' and 'N'
...
supporting C integer types `ssize_t` and `size_t`, respectively.
2011-10-06 15:27:40 +02:00
4969f709cc
#11515 : Merge with 3.1.
2011-03-15 05:59:46 +02:00
42da663e6f
#11515 : fix several typos. Patch by Piotr Kasprzyk.
2011-03-15 05:18:48 +02:00
da9ec995f6
Issue #10783 : struct.pack() doesn't encode implicitly unicode to UTF-8
...
* Replace "bytes" by "bytes object" in struct error messages
* Document the API change in What's new in Python 3.2
* Fix test_wave
* Remove also ugly implicit conversions in test_struct
2010-12-28 13:26:42 +00:00
71c23d4473
Include structseq.h in Python.h, and remove now-redundant includes in individual sources.
2010-11-30 09:30:54 +00:00
2da63cc338
Merged revisions 83239 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r83239 | mark.dickinson | 2010-07-29 22:41:59 +0100 (Thu, 29 Jul 2010) | 2 lines
Issue #9422 : Fix memory leak when re-initializing a struct.Struct object.
........
2010-07-29 21:43:24 +00:00
cf28b95800
Issue #9422 : Fix memory leak when re-initializing a struct.Struct object.
2010-07-29 21:41:59 +00:00
101d16cb14
Merged revisions 82941 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r82941 | mark.dickinson | 2010-07-18 08:29:02 +0100 (Sun, 18 Jul 2010) | 3 lines
Issue #9277 : Struct module: standard bool packing was incorrect if
char is unsigned. Thanks Stefan Krah for the patch.
........
2010-07-18 07:42:29 +00:00
eff5d8594b
Issue #9277 : Struct module: standard bool packing was incorrect if
...
char is unsigned. Thanks Stefan Krah for the patch.
2010-07-18 07:29:02 +00:00
f092c7c1d7
Merged revisions 82628,82630 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r82628 | benjamin.peterson | 2010-07-07 13:44:05 -0500 (Wed, 07 Jul 2010) | 1 line
this needn't be in the loop
........
r82630 | benjamin.peterson | 2010-07-07 13:54:59 -0500 (Wed, 07 Jul 2010) | 1 line
don't ignore exceptions from PyObject_IsTrue
........
2010-07-07 22:46:00 +00:00
de73c4587f
don't ignore exceptions from PyObject_IsTrue
2010-07-07 18:54:59 +00:00
1330507360
Merged revisions 81965 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r81965 | mark.dickinson | 2010-06-13 10:17:13 +0100 (Sun, 13 Jun 2010) | 1 line
Remove unnecessary brackets from docstring optional arguments.
........
2010-06-13 09:18:16 +00:00
c6f1396be0
Remove unnecessary brackets from docstring optional arguments.
2010-06-13 09:17:13 +00:00
d12dfe231e
Merged revisions 81961 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r81961 | alexander.belopolsky | 2010-06-12 20:36:28 +0100 (Sat, 12 Jun 2010) | 1 line
Issue #8973 : Expanded Struct.__doc__.
........
2010-06-12 19:44:22 +00:00
0bd003a55e
Issue #8973 : Expanded Struct.__doc__.
2010-06-12 19:36:28 +00:00
f9e091ae2d
Merged revisions 81947-81950,81955-81956 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r81947 | mark.dickinson | 2010-06-12 16:17:02 +0100 (Sat, 12 Jun 2010) | 3 lines
Issue #8973 : Add __all__ to struct module, so that help(struct) correctly
displays information for the struct.Struct class.
........
r81948 | mark.dickinson | 2010-06-12 16:19:23 +0100 (Sat, 12 Jun 2010) | 1 line
Remove accidental (yet-to-be-reviewed) docstring changes included in r81947.
........
r81949 | mark.dickinson | 2010-06-12 16:43:45 +0100 (Sat, 12 Jun 2010) | 1 line
Issue #8973 : Improve struct module docstrings.
........
r81950 | mark.dickinson | 2010-06-12 17:30:53 +0100 (Sat, 12 Jun 2010) | 1 line
More struct module docs and docstring tweaks.
........
r81955 | mark.dickinson | 2010-06-12 19:20:47 +0100 (Sat, 12 Jun 2010) | 1 line
Issue #8469 : add standard sizes to struct docs table.
........
r81956 | mark.dickinson | 2010-06-12 19:37:54 +0100 (Sat, 12 Jun 2010) | 2 lines
Issue #8469 : Reorder struct module sections for clarity; other minor tweaks.
........
2010-06-12 19:18:51 +00:00
fdb99f1563
More struct module docs and docstring tweaks.
2010-06-12 16:30:53 +00:00
aacfa95d2e
Issue #8973 : Improve struct module docstrings.
2010-06-12 15:43:45 +00:00
d80a8eefe6
Remove accidental (yet-to-be-reviewed) docstring changes included in r81947.
2010-06-12 15:19:23 +00:00
4b80ef5432
Issue #8973 : Add __all__ to struct module, so that help(struct) correctly
...
displays information for the struct.Struct class.
2010-06-12 15:17:02 +00:00
0681785d09
Remove unused variable.
2010-06-12 09:25:13 +00:00
bfd57618b5
Issue #8981 : Remove _struct.__version__.
2010-06-12 09:24:01 +00:00
4a3acca7c1
Merged revisions 81897-81898,81902 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r81897 | mark.dickinson | 2010-06-11 17:56:34 +0100 (Fri, 11 Jun 2010) | 1 line
Avoid possible undefined behaviour from signed overflow.
........
r81898 | mark.dickinson | 2010-06-11 20:05:08 +0100 (Fri, 11 Jun 2010) | 1 line
Fix an incorrect return type.
........
r81902 | mark.dickinson | 2010-06-11 20:50:30 +0100 (Fri, 11 Jun 2010) | 1 line
Fix more undefined-behaviour inducing overflow checks in struct module.
........
2010-06-11 20:08:36 +00:00
b72e6860d8
Fix more undefined-behaviour inducing overflow checks in struct module.
2010-06-11 19:50:30 +00:00
eac0e68c10
Fix an incorrect return type.
2010-06-11 19:05:08 +00:00
ab4096f2f9
Avoid possible undefined behaviour from signed overflow.
2010-06-11 16:56:34 +00:00
177e8530cb
Issue #3129 : Trailing digits in format string are no longer ignored.
2010-06-11 16:04:59 +00:00
7f14f0d8a0
Recorded merge of revisions 81032 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/branches/py3k
................
r81032 | antoine.pitrou | 2010-05-09 17:52:27 +0200 (dim., 09 mai 2010) | 9 lines
Recorded merge of revisions 81029 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk
........
r81029 | antoine.pitrou | 2010-05-09 16:46:46 +0200 (dim., 09 mai 2010) | 3 lines
Untabify C files. Will watch buildbots.
........
................
2010-05-09 16:14:21 +00:00
f95a1b3c53
Recorded merge of revisions 81029 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r81029 | antoine.pitrou | 2010-05-09 16:46:46 +0200 (dim., 09 mai 2010) | 3 lines
Untabify C files. Will watch buildbots.
........
2010-05-09 15:52:27 +00:00
414e737628
Merged revisions 79751 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r79751 | mark.dickinson | 2010-04-04 22:19:35 +0100 (Sun, 04 Apr 2010) | 1 line
A handful of whitespace fixes in Modules/_struct.c.
........
2010-04-04 21:23:57 +00:00
e9493a1872
Merged revisions 79745 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r79745 | mark.dickinson | 2010-04-04 09:43:04 +0100 (Sun, 04 Apr 2010) | 3 lines
Issue #8300 (__index__ handling in struct.pack): Remove redundant check
and improve test coverage. Thanks Meador Inge for the patch.
........
2010-04-04 08:52:51 +00:00
04e8bcb49a
add missing decrefs
2010-04-03 23:56:48 +00:00
c593577a4a
Merged revisions 79674 via svnmerge from
...
svn+ssh://pythondev@svn.python.org/python/trunk
........
r79674 | mark.dickinson | 2010-04-03 15:05:10 +0100 (Sat, 03 Apr 2010) | 3 lines
Issue #8300 : Let struct.pack use __index__ to convert and pack non-integers.
Based on a patch by Meador Inge.
........
2010-04-03 15:54:36 +00:00
055a3fbe3e
Internal refactoring in struct.pack: make all integer conversions go through get_pylong.
2010-04-03 15:26:31 +00:00
77e2b67971
Remove unused define.
2010-04-03 14:24:58 +00:00
Petr Viktorin
Eddie Elizondo
Jordon Xu
Dino Viehland
Min ho Kim
Jeroen Demeyer
Serhiy Storchaka
Siddhesh Poyarekar
Xiang Zhang
INADA Naoki
Victor Stinner
Sylvain
Johan Liu
Andrew Nester
Zachary Ware
Benjamin Peterson
Mark Dickinson
Gregory P. Smith
Martin Panter
doko@ubuntu.com
Antoine Pitrou
Petri Lehtinen
Christian Heimes
Meador Inge
Ezio Melotti
Victor Stinner
Georg Brandl
Alexander Belopolsky