Xtreak
7397cda997
bpo-21478: Record calls to parent when autospecced objects are used as child with attach_mock (GH 14688)
...
* Clear name and parent of mock in autospecced objects used with attach_mock
* Add NEWS entry
* Fix reversed order of comparison
* Test child and standalone function calls
* Use a helper function extracting mock to avoid code duplication and refactor tests.
2019-07-22 08:38:22 +01:00
Serhiy Storchaka
142566c028
[3.9] bpo-37116: Use PEP 570 syntax for positional-only parameters. (GH-12620)
...
Turn deprecation warnings added in 3.8 into TypeError.
2019-06-05 18:22:31 +03:00
Serhiy Storchaka
2085bd0877
bpo-37116: Use PEP 570 syntax for positional-only parameters. (GH-13700)
2019-06-01 11:00:15 +03:00
Andrew Svetlov
4dd3e3f9bb
bpo-32972: Async test case (GH-13386)
...
Add explicit `asyncSetUp` and `asyncTearDown` methods.
The rest is the same as for #13228
`AsyncTestCase` create a loop instance for every test for the sake of test isolation.
Sometimes a loop shared between all tests can speed up tests execution time a lot but it requires control of closed resources after every test finish. Basically, it requires nested supervisors support that was discussed with @1st1 many times. Sorry, asyncio supervisors have no chance to land on Python 3.8.
The PR intentionally does not provide API for changing the used event loop or getting the test loop: use `asyncio.set_event_loop_policy()` and `asyncio.get_event_loop()` instead.
The PR adds four overridable methods to base `unittest.TestCase` class:
```
def _callSetUp(self):
self.setUp()
def _callTestMethod(self, method):
method()
def _callTearDown(self):
self.tearDown()
def _callCleanup(self, function, /, *args, **kwargs):
function(*args, **kwargs)
```
It allows using asyncio facilities with minimal influence on the unittest code.
The last but not least: the PR respects contextvars. The context variable installed by `asyncSetUp` is available on test, `tearDown` and a coroutine scheduled by `addCleanup`.
https://bugs.python.org/issue32972
2019-05-29 02:33:59 -07:00
Xtreak
0ae022c6a4
bpo-37075: Fix string concatenation in assert_has_awaits error message (GH-13616)
...
* Fix the implicit string concatenation in `assert_has_awaits` error message.
* Use "await" instead of "call" in `assert_awaited_with` error message.
https://bugs.python.org/issue37075
2019-05-29 00:02:25 -07:00
Mario Corchero
04530812e9
bpo-32299: Return patched dict when using patch.dict as a context manager (GH-11062)
2019-05-28 08:53:30 -04:00
Xtreak
436c2b0d67
bpo-36996: Handle async functions when mock.patch is used as a decorator (GH-13562)
...
Return a coroutine while patching async functions with a decorator.
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
https://bugs.python.org/issue36996
2019-05-28 00:07:38 -07:00
Xtreak
ff6b2e66b1
bpo-37047: Refactor AsyncMock setup logic for autospeccing (GH-13574)
...
Handle late binding and attribute access in unittest.mock.AsyncMock
setup for autospeccing.
2019-05-27 14:56:23 +02:00
Damien Nadé
394119afc6
bpo-37008: make mock_open handle able to honor next() (GH-13492)
...
I've reported the issue on https://bugs.python.org/issue37008 and now I'm trying to bring a solution to this minor issue.
I think it could be trivially backported to 3.7 branch.
https://bugs.python.org/issue37008
2019-05-23 03:03:25 -07:00
Xtreak
e7cb23bf20
Fix RuntimeWarning in unittest.mock asyncio example (GH-13449)
...
* This PR fixes the `RuntimeWarning` in `inspect.isawaitable(mock())` where `mock()` was not awaited.
* Fix typo in asynctest project.
2019-05-21 01:47:17 -07:00
Lisa Roach
77b3b7701a
bpo-26467: Adds AsyncMock for asyncio Mock library support (GH-9296)
2019-05-20 09:19:53 -07:00
Ashwin Ramaswami
f665b96e92
Fix typo in test comment (GH-11442)
2019-05-18 21:17:47 -04:00
Zackery Spytz
b9b08cd948
bpo-24758: Improve the error msg for unittest.mock.Mock()'s unsafe mode ( #12991 )
...
* bpo-24758: Improve the error msg for unittest.mock.Mock()'s unsafe mode
* Make the requested changes.
2019-05-08 23:02:23 +05:30
Rémi Lapeyre
11a8832c98
bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) (GH-11521)
...
unittest.mock.mock_open() results now respects the argument of read([size])
Co-Authored-By: remilapeyre <remi.lapeyre@henki.fr>
2019-05-07 11:48:36 +01:00
Serhiy Storchaka
d53cf99dca
bpo-36542: Allow to overwrite the signature for Python functions. (GH-12705)
2019-05-06 22:40:27 +03:00
Chris Withers
adbf178e49
Mock 100% coverage (GH-13045)
...
This was achieved by:
* moving many pass statements in tests onto their own lines, so they pass line coverage and can match an easy ignore pattern if branch coverage is added later.
* removing code that cannot be reached.
* removing long-disabled tests.
* removing unused code.
* adding tests for uncovered code
It turned out that removing `if __name__ == '__main__'` blocks that run unittest.main() at the bottom of test files was surprisingly contentious, so they remain and can be filtered out with an appropriate .coveragerc.
2019-05-01 23:04:04 +01:00
Chris Withers
49e27f0afb
remove jython support from unittest.mock (GH#13033)
2019-05-01 08:48:44 +01:00
Mario Corchero
0df635c7f8
Don't report deleted attributes in __dir__ (GH#10148)
...
When an attribute is deleted from a Mock, a sentinel is added rather
than just deleting the attribute. This commit checks for such sentinels
when returning the child mocks in the __dir__ method as users won't
expect deleted attributes to appear when performing dir(mock).
2019-04-30 19:56:36 +01:00
Pablo Galindo
d5d2b45469
bpo-36751: Deprecate getfullargspec and report positional-only args as regular args (GH-13016)
...
* bpo-36751: Deprecate getfullargspec and report positional-only args as regular args
* Use inspect.signature in testhelpers
2019-04-30 02:01:14 +01:00
jkleint
39baace622
Document that TestCase.assertCountEqual() can take iterables (GH-686)
2019-04-23 01:34:29 -07:00
Xtreak
9b21856b0f
bpo-23078: Add support for {class,static}method to mock.create_autospec() (GH-11613)
...
Co-authored-by: Felipe <felipe.nospam.ochoa@gmail.com>
2019-04-22 05:30:23 +03:00
Xtreak
830b43d03c
bpo-36593: Fix isinstance check for Mock objects with spec executed under tracing (GH-12790)
...
In Python having a trace function in effect while mock is imported causes isinstance to be wrong for MagicMocks. This is due to the usage of super() in some class methods, as this sets the __class__ attribute. To avoid this, as a workaround, alias the usage of super .
2019-04-13 20:12:33 +01:00
Serhiy Storchaka
42a139ed88
bpo-36492: Deprecate passing some arguments as keyword arguments. (GH-12637)
...
Deprecated passing the following arguments as keyword arguments:
- "func" in functools.partialmethod(), weakref.finalize(),
profile.Profile.runcall(), cProfile.Profile.runcall(),
bdb.Bdb.runcall(), trace.Trace.runfunc() and
curses.wrapper().
- "function" in unittest.addModuleCleanup() and
unittest.TestCase.addCleanup().
- "fn" in the submit() method of concurrent.futures.ThreadPoolExecutor
and concurrent.futures.ProcessPoolExecutor.
- "callback" in contextlib.ExitStack.callback(),
contextlib.AsyncExitStack.callback() and
contextlib.AsyncExitStack.push_async_callback().
- "c" and "typeid" in the create() method of multiprocessing.managers.Server
and multiprocessing.managers.SharedMemoryServer.
- "obj" in weakref.finalize().
Also allowed to pass arbitrary keyword arguments (even "self" and "func")
if the above arguments are passed as positional argument.
2019-04-01 09:16:35 +03:00
Xtreak
02b84cb1b4
bpo-36366: Return None on stopping unstarted patch object (GH-12472)
...
Return None after calling unittest.mock.patch.object.stop() regardless of whether the object was started. This makes the method idempotent.
https://bugs.python.org/issue36366
2019-03-28 14:08:43 -07:00
Kumar Akshay
b0df45e55d
bpo-21269: Provide args and kwargs attributes on mock call objects GH11807
2019-03-22 08:10:40 +00:00
Xtreak
9c3f284de5
Autospec functions should propagate mock calls to parent GH-11273
2019-02-25 21:46:34 +00:00
Xtreak
a875ea58b2
bpo-35512: Resolve string target to patch.dict decorator during function call GH#12000
...
* Resolve string target to patch.dict during function call
* Add NEWS entry
* Remove unneeded call
* Restore original value for support.target and refactor assertions
* Add extra assertion to verify unpatched dict
2019-02-24 18:54:49 +00:00
Susan Su
2bdd5858e3
bpo-35500: align expected and actual calls on mock.assert_called_with error message. (GH-11804)
2019-02-13 18:22:29 -08:00
Jason Fried
fd628cf5ad
bpo-35767: Fix unittest.loader to allow partials as test_functions ( #11600 )
2019-01-23 21:57:25 +01:00
Pablo Galindo
222d303ade
bpo-20239: Allow repeated deletion of unittest.mock.Mock attributes ( #11057 )
...
* Allow repeated deletion of unittest.mock.Mock attributes
* fixup! Allow repeated deletion of unittest.mock.Mock attributes
* fixup! fixup! Allow repeated deletion of unittest.mock.Mock attributes
2019-01-21 08:57:46 +00:00
Xtreak
71f82a2f20
Fix mock_open docstring to use readline ( #11176 )
2018-12-20 16:00:21 +00:00
Victor Stinner
8db5b54463
bpo-35513, unittest: TextTestRunner uses time.perf_counter() (GH-11180)
...
TextTestRunner of unittest.runner now uses time.perf_counter() rather
than time.time() to measure the execution time of a test: time.time()
can go backwards, whereas time.perf_counter() is monotonic.
Similar change made in libregrtest, pprint and random.
2018-12-17 11:30:34 +01:00
Anthony Sottile
5a718e918d
Add test for double patching instance methods ( #11085 )
2018-12-12 07:56:35 +00:00
Xtreak
f7fa62ef44
bpo-17185: Add __signature__ to mock that can be used by inspect for signature (GH11048)
...
* Fix partial and partial method signatures in mock
* Add more calls
* Add NEWS entry
* Use assertEquals and fix markup in NEWS
* Refactor branching and add markup reference for functools
* Revert partial object related changes and fix pr comments
2018-12-12 07:54:54 +00:00
Mario Corchero
f05df0a4b6
bpo-35330: Don't call the wrapped object if `side_effect` is set (GH10973)
...
* tests: Further validate `wraps` functionality in `unittest.mock.Mock`
Add more tests to validate how `wraps` interacts with other features of
mocks.
* Don't call the wrapped object if `side_effect` is set
When a object is wrapped using `Mock(wraps=...)`, if an user sets a
`side_effect` in one of their methods, return the value of `side_effect`
and don't call the original object.
* Refactor what to be called on `mock_call`
When a `Mock` is called, it should return looking up in the following
order: `side_effect`, `return_value`, `wraps`. If any of the first two
return `mock.DEFAULT`, lookup in the next option.
It makes no sense to check for `wraps` returning default, as it is
supposed to be the original implementation and there is nothing to
fallback to.
2018-12-08 11:25:02 +00:00
Anirudha Bose
3cf74384b5
bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock tests (GH-8520)
2018-12-07 15:30:42 -08:00
Mario Corchero
20428527a7
Remove unused function in `testmock/support.py` (GH-10975)
...
The function is never imported and the implementation is actually buggy.
As `warnings.catch_warnings` is not imported here.
2018-12-06 17:05:46 +00:00
Andrew Dunai
e63e617ebb
bpo-35357: Add _mock_ prefix to name/parent/from_kall attributes of _Call/_MagicProxy. ( #10873 )
...
Fix minor typo in test function name.
2018-12-04 09:08:45 +00:00
Chris Withers
8ca0fa9d2f
bpo-35226: Fix equality for nested unittest.mock.call objects. ( #10555 )
...
Also refactor the call recording imolementation and add some notes
about its limitations.
2018-12-03 21:31:37 +00:00
Xtreak
c667b094ae
bpo-32153: Add unit test for create_autospec with partial function returned in getattr ( #10398 )
...
* Add create_autospec with partial function returned in getattr
* Use self.assertFalse instead of assert
* Use different names and remove object
2018-12-03 07:58:15 +00:00
Xtreak
edeca92c84
bpo-31177: Skip deleted attributes while calling reset_mock (GH-9302)
2018-12-01 11:03:54 +01:00
Xtreak
b2774c8e91
Use assertEqual to fix DeprecationWarning. (GH-10794)
2018-11-29 15:07:00 +02:00
Lisa Roach
0f221d09ca
bpo-24412: Adds cleanUps for setUpClass and setUpModule. (GH-9190)
2018-11-08 18:34:33 -08:00
Serhiy Storchaka
34fd4c2019
bpo-35133: Fix mistakes when concatenate string literals on different lines. (GH-10284)
...
Two kind of mistakes:
1. Missed space. After concatenating there is no space between words.
2. Missed comma. Causes unintentional concatenating in a list of strings.
2018-11-05 16:20:25 +02:00
Petter Strandmark
47d94241a3
bpo-35047, unittest.mock: Better error messages on assert_called_xxx failures (GH-10090)
...
unittest.mock now includes mock calls in exception messages if
assert_not_called, assert_called_once, or assert_called_once_with
fails.
2018-10-28 21:37:10 +01:00
Max Bélanger
6c83d9f4a7
bpo-35022: unittest.mock.MagicMock now also supports __fspath__ (GH-9960)
...
The MagicMock class supports many magic methods, but not __fspath__. To ease
testing with modules such as os.path, this function is now supported by default.
2018-10-25 23:48:58 +02:00
Mario Corchero
96200eb2ff
unittest.mock doc: Fix references to recursive seal of Mocks (GH-9028)
...
The docs in `library/unittest.mock` have been updated to remove
confusing terms about submock and be explicit about the behavior
expected.
2018-10-19 23:57:37 +02:00
Bruno Oliveira
da2bf9f66d
bpo-34900: Make TestCase.debug() work with subtests (GH-9707)
2018-10-12 13:35:55 +03:00
Tony Flury
2087023fde
bpo-32933: Implement __iter__ method on mock_open() (GH-5974)
2018-09-13 01:21:16 +03:00
Serhiy Storchaka
77d5781835
bpo-34318: Convert deprecation warnings to errors in assertRaises() etc. (GH-8623)
2018-08-19 10:00:11 +03:00
davidair
2b32da2fea
Improve error message when mock.assert_has_calls fails (GH-8205)
...
This makes the assertion error message more useful, aiding debugging.
Thanks @davidair!
2018-08-17 12:09:58 -07:00
Victor Stinner
fd8fbce495
bpo-33746: Fix test_unittest.testRegisterResult() in verbose mode (GH-7799)
...
Only make sure that the result is in unittest.signals._results, don't
check the full content of unittest.signals._results.
support._run_suite() uses TextTestRunner in verbose mode, but
TextTestRunner.run() calls registerResult(result) which made the test
fail with "odd object in result set".
Call also removeResult() to restore unittest.signals._results to
avoid test side effect.
2018-06-20 11:29:33 +02:00
Ned Deily
9d6d06e806
pypi.python.org -> pypi.org (GH-7613)
2018-06-11 00:45:50 -04:00
Tal Einat
4ab4695388
bpo-33748: fix tests altering sys.path and sys.modules (GH-7433)
2018-06-10 10:10:28 +03:00
John Reese
6c4fab0f4b
bpo-33516: Add support for __round__ in MagicMock (GH-6880)
...
unittest.mock.MagicMock now supports the __round__() magic method.
2018-05-22 22:01:10 +02:00
Leo Arias
c3d9508ff2
bpo-32746: Fix multiple typos (GH-5144)
...
Fix typos found by codespell in docs, docstrings, and comments.
2018-02-03 19:36:10 -05:00
Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి)
018e1b7aad
bpo-32360: unittest.util: Use Counter instead of custom count function (GH-4994)
2018-01-24 16:49:58 +09:00
Victor Stinner
13ff24582c
bpo-32593: Drop FreeBSD 9 and older support ( #5232 )
...
Drop support of FreeBSD 9 and older.
2018-01-22 18:32:50 +01:00
Mike
53f7a7c281
bpo-32297: Few misspellings found in Python source code comments. ( #4803 )
...
* Fix multiple typos in code comments
* Add spacing in comments (test_logging.py, test_math.py)
* Fix spaces at the beginning of comments in test_logging.py
2017-12-14 13:04:53 +02:00
Victor Stinner
747f48e2e9
bpo-32230: Set sys.warnoptions with -X dev ( #4820 )
...
Rather than supporting dev mode directly in the warnings module, this
instead adjusts the initialisation code to add an extra 'default'
entry to sys.warnoptions when dev mode is enabled.
This ensures that dev mode behaves *exactly* as if `-Wdefault` had
been passed on the command line, including in the way it interacts
with `sys.warnoptions`, and with other command line flags like `-bb`.
Fix also bpo-20361: have -b & -bb options take precedence over any
other warnings options.
Patch written by Nick Coghlan, with minor modifications of Victor Stinner.
2017-12-12 22:59:48 +01:00
Jonas Haag
4d193bcc25
bpo-32071: Fix regression and add What's New entry ( #4589 )
...
* bpo-32071: Fix an undocumented behaviour regression
* bpo-32071: Add 3.7 release note entry for unittest -k
2017-11-28 20:40:44 +01:00
Jonas Haag
5b48dc638b
bpo-32071: Add unittest -k option ( #4496 )
...
* bpo-32071: Add unittest -k option
2017-11-25 16:23:52 +01:00
luzpaz
a5293b4ff2
Fix miscellaneous typos ( #4275 )
2017-11-05 15:37:50 +02:00
Ron
032a6480e3
Update TestCase.assertAlmostEqual and assertNotAlmostEqual docstrings. (GH-3998)
...
The word "difference" from missing the sentence.
This clarifies that it compares the difference between the two objects.
2017-10-18 10:01:23 -07:00
Mario Corchero
552be9d7e6
bpo-30541: Add new method to seal mocks (GH61923)
...
The new method allows the developer to control when to stop the
feature of mocks that automagically creates new mocks when accessing
an attribute that was not declared before
Signed-off-by: Mario Corchero <mariocj89@gmail.com>
2017-10-17 04:35:11 -07:00
Serhiy Storchaka
0b5e61ddca
bpo-30397: Add re.Pattern and re.Match. ( #1646 )
2017-10-04 20:09:49 +03:00
Ville Skyttä
49b2734bf1
Spelling fixes ( #2902 )
2017-08-03 09:00:59 +03:00
Aaron Gallagher
856cbcc12f
bpo-29403: Fix mock's broken autospec behavior on method-bound builtin functions (GH-3)
...
Cython will, in the right circumstances, offer a MethodType instance
where im_func is a builtin function. Any instance of MethodType is
automatically assumed to be a Python-defined function (more
specifically, a function that has an inspectable signature), but
_set_signature was still conservative in its assumptions. As a result
_set_signature would return early with None instead of a mock since
the im_func had no inspectable signature. This causes problems
deeper inside mock, as _set_signature is assumed to _always_
return a mock, and nothing checked its return value.
In similar corner cases, autospec will simply not check the spec of the
function, so _set_signature is amended to now return early with the
original, not-wrapped mock object.
Patch by Aaron Gallagher.
2017-07-20 03:01:14 +03:00
Victor Stinner
e4f9a2d2be
bpo-30813: Fix unittest when hunting refleaks ( #2502 )
...
bpo-11798, bpo-16662, bpo-16935, bpo-30813: Skip
test_discover_with_module_that_raises_SkipTest_on_import() and
test_discover_with_init_module_that_raises_SkipTest_on_import() of
test_unittest when hunting reference leaks using regrtest.
2017-06-30 12:52:52 +02:00
Serhiy Storchaka
48fbe52ac7
bpo-30664: The description of a unittest subtest now preserves the ( #2265 )
...
order of keyword arguments of TestCase.subTest().
2017-06-23 21:47:39 +03:00
Giampaolo Rodola
c4750959ac
#30190 : fix invalid escape sequence warnings ( #1534 )
2017-05-10 20:13:20 +02:00
Giampaolo Rodola
5d7a8d0c13
bpo-30190: improved error msg for assertAlmostEqual(delta=...) ( #1331 )
...
* #30190 / unittest / assertAlmostEqual(delta=...) / error msg: show the difference between the 2 numbers in case of failure
* safe_repr() diff
* also show difference when passing 'places' argument
* refactoring
* update Misc/NEWS
2017-05-01 18:18:56 +02:00
Louie Lu
f7e62cf8ad
bpo-30078: Add an example of passing a path to unittest ( #1178 )
2017-04-20 06:46:59 +03:00
Serhiy Storchaka
55fe1ae970
bpo-30022: Get rid of using EnvironmentError and IOError (except test… ( #1051 )
2017-04-16 10:46:38 +03:00
Victor Stinner
bbd3cf8f1e
Fix ref cycles in TestCase.assertRaises() ( #193 )
...
bpo-23890: unittest.TestCase.assertRaises() now manually breaks a
reference cycle to not keep objects alive longer than expected.
2017-03-28 00:56:28 +02:00
Victor Stinner
d6debb24e0
bpo-29919: Remove unused imports found by pyflakes ( #137 )
...
Make also minor PEP8 coding style fixes on modified imports.
2017-03-27 16:05:26 +02:00
Berker Peksag
5aa3856b4f
bpo-28961: Address my comments from earlier code review ( #305 )
2017-02-26 15:04:11 +03:00
Arne de Laat
324c5d8ca6
bpo-28911: Clarify the behaviour of assert_called_once_with. ( #251 )
2017-02-23 15:57:25 +01:00
Serhiy Storchaka
19dea2c726
Issue #28735 : Fixed the comparison of mock.MagickMock with mock.ANY.
2017-01-21 23:17:25 +02:00
Serhiy Storchaka
a203360836
Issue #28735 : Fixed the comparison of mock.MagickMock with mock.ANY.
2017-01-21 23:15:18 +02:00
Serhiy Storchaka
362f058a89
Issue #28735 : Fixed the comparison of mock.MagickMock with mock.ANY.
2017-01-21 23:12:58 +02:00
Martin Panter
9722d7f142
Issue 29274: Merge doc fixes from 3.6
2017-01-18 12:11:42 +00:00
Martin Panter
4710935b11
Issue 29274: Merge doc fixes from 3.5
2017-01-18 12:11:12 +00:00
Martin Panter
37f183d43d
Issue #29274 : tests cases → test cases
2017-01-18 12:06:38 +00:00
Serhiy Storchaka
d9c956fb23
Issue #20804 : The unittest.mock.sentinel attributes now preserve their
...
identity when they are copied or pickled.
2017-01-11 20:13:03 +02:00
Victor Stinner
cd992bbe73
Merge 3.6
2017-01-06 18:16:07 +01:00
Victor Stinner
84b6fb0eea
Fix unittest.mock._Call: don't ignore name
...
Issue #28961 : Fix unittest.mock._Call helper: don't ignore the name parameter
anymore.
Patch written by Jiajun Huang.
2017-01-06 18:15:51 +01:00
Berker Peksag
161a4dd495
Issue #28919 : Simplify _copy_func_details() in unittest.mock
...
Patch by Jiajun Huang.
2016-12-15 05:21:44 +03:00
Gregory P. Smith
ac5084b6c7
Fixes issue28380: unittest.mock Mock autospec functions now properly support
...
assert_called, assert_not_called, and assert_called_once.
2016-10-06 14:31:23 -07:00
Berker Peksag
eadf443e9a
Issue #28303 : Merge from 3.5
2016-09-28 17:29:12 +03:00
Berker Peksag
aa5c2fdb7c
Issue #28303 : Fix grammar in unittest.__doc__, patch by Shlomi Fish
2016-09-28 17:28:41 +03:00
Berker Peksag
b3d4e7fe71
Issue #25651 : Merge from 3.5
2016-09-21 19:35:28 +03:00
Berker Peksag
16ea19fc66
Issue #25651 : Allow falsy values to be used for msg parameter of subTest()
2016-09-21 19:34:15 +03:00
Martin Panter
0be894b2f6
Issue #27895 : Spelling fixes (Contributed by Ville Skyttä).
2016-09-07 12:03:06 +00:00
R David Murray
44b548dda8
#27364 : fix "incorrect" uses of escape character in the stdlib.
...
And most of the tools.
Patch by Emanual Barry, reviewed by me, Serhiy Storchaka, and
Martin Panter.
2016-09-08 13:59:53 -04:00
Raymond Hettinger
15f44ab043
Issue #27895 : Spelling fixes (Contributed by Ville Skyttä).
2016-08-30 10:47:49 -07:00
Raymond Hettinger
f74c33ad5c
Merge
2016-08-25 21:12:16 -07:00
Raymond Hettinger
7ea386e56e
Issue 19504: Change "customise" to "customize" American spelling.
2016-08-25 21:11:50 -07:00
Gregory P. Smith
c35a32fe85
Issue #26750 : use inspect.isdatadescriptor instead of our own
...
_is_data_descriptor().
2016-08-15 23:56:32 -07:00
Gregory P. Smith
d4583d7fea
Issue #26750 : use inspect.isdatadescriptor instead of our own
...
_is_data_descriptor().
2016-08-15 23:23:40 -07:00
Gregory P. Smith
d0d24fd1ae
Issue #26750 : unittest.mock.create_autospec() now works properly for
...
subclasses of property() and other data descriptors. Removes the never
publicly used, never documented unittest.mock.DescriptorTypes tuple.
2016-08-07 09:06:27 -07:00
Gregory P. Smith
9854789efe
Issue #26750 : unittest.mock.create_autospec() now works properly
...
for subclasses of property() and other data descriptors.
2016-08-07 08:52:26 -07:00
Martin Panter
8bde911115
Issue #27626 : Merge spelling fixes from 3.5
2016-07-28 01:30:58 +00:00
Martin Panter
eb9957065a
Issue #27626 : Spelling fixes in docs, comments and internal names
...
Based on patch by Ville Skyttä.
2016-07-28 01:11:04 +00:00
Martin Panter
702f4f5d6f
Issue #23804 : Merge spelling and NEWS fixes from 3.5
2016-07-11 12:54:44 +00:00
Martin Panter
204bf0b9ae
English spelling and grammar fixes
2016-07-11 07:51:37 +00:00
Berker Peksag
a9e1ebb780
Issue #27430 : Merge from 3.5
2016-07-01 12:17:45 +03:00
Berker Peksag
e39682b076
Issue #27430 : Fix typos, patch by scop.
2016-07-01 12:17:05 +03:00
Serhiy Storchaka
6c85091b5b
Issue #23641 : Added __getnewargs_ex__ to the list of special mock attributes.
2016-06-19 18:32:07 +03:00
Serhiy Storchaka
5943ea76d5
Issue #23641 : Added __getnewargs_ex__ to the list of special mock attributes.
2016-06-19 18:30:43 +03:00
Kushal Das
9cd39a170b
Issue #21271 : Adds new keyword only parameters in reset_mock call
...
We now have two keyword only parameters in the reset_mock function to
selectively reset the return_value or the side_effects, or both.
2016-06-02 10:20:16 -07:00
Martin Panter
0b7d84de6b
Issue #27171 : Merge typo fixes from 3.5
2016-06-02 10:11:18 +00:00
Martin Panter
e26da7c03a
Issue #27171 : Fix typos in documentation, comments, and test function names
2016-06-02 10:07:09 +00:00
Martin Panter
3e04d5b306
Issue #27076 : Merge spelling from 3.5
2016-05-26 06:03:19 +00:00
Martin Panter
46f50726a0
Issue #27076 : Doc, comment and tests spelling fixes
...
Most fixes to Doc/ and Lib/ directories by Ville Skyttä.
2016-05-26 05:35:26 +00:00
Serhiy Storchaka
742206d95c
Issue #27063 : Some unittest loader tests were silently skipped.
2016-05-20 23:29:07 +03:00
Serhiy Storchaka
0dad755600
Issue #27063 : Some unittest loader tests were silently skipped.
2016-05-20 23:28:37 +03:00
Robert Collins
c85dd85f1a
Issue #26807 : mock_open 'files' no longer error on readline at end of file.
...
Patch from Yolanda Robla.
2016-05-16 15:22:45 +12:00
Robert Collins
9549a3e3d4
Issue #26807 : mock_open 'files' no longer error on readline at end of file.
...
Patch from Yolanda Robla.
2016-05-16 15:22:01 +12:00
Serhiy Storchaka
81e7f94076
Merge 3.5
2016-04-25 08:58:59 +03:00
Serhiy Storchaka
685fbed7f9
Issue #26837 : assertSequenceEqual() now correctly outputs non-stringified
...
differing items (like bytes in the -b mode). This affects assertListEqual()
and assertTupleEqual().
2016-04-25 08:58:25 +03:00
Serhiy Storchaka
e437a10d15
Issue #23277 : Remove unused imports in tests.
2016-04-24 21:41:02 +03:00
Berker Peksag
1e8ee9b380
Issue #23277 : Remove unused sys and os imports
...
Patch by Jon Dufresne.
2016-04-24 07:31:42 +03:00
Victor Stinner
6e722bc13f
Merge 3.5 (test_unittest)
2016-03-30 01:15:48 +02:00
Victor Stinner
9db2ae7263
Fix ResourceWarning in test_unittest when interrupted
2016-03-30 01:15:28 +02:00
Berker Peksag
5a6c018b57
Issue #25195 : Fix a regression in mock.MagicMock
...
_Call is a subclass of tuple (changeset 3603bae63c13 only works
for classes) so we need to implement __ne__ ourselves.
Patch by Andrew Plummer.
2016-03-28 00:30:40 +03:00
Berker Peksag
ce913877e4
Issue #25195 : Fix a regression in mock.MagicMock
...
_Call is a subclass of tuple (changeset 3603bae63c13 only works
for classes) so we need to implement __ne__ ourselves.
Patch by Andrew Plummer.
2016-03-28 00:30:02 +03:00
Robert Collins
bfef0be420
#25320 : Handle sockets in directories unittest discovery is scanning.
...
Patch from Victor van den Elzen.
2016-03-15 13:33:28 +13:00
Robert Collins
ecd5383891
#25320 : Handle sockets in directories unittest discovery is scanning.
...
Patch from Victor van den Elzen.
2016-03-15 13:29:17 +13:00
Victor Stinner
2c2a4e63d7
Add Mock.assert_called()
...
Issue #26323 : Add assert_called() and assert_called_once() methods to
unittest.mock.Mock.
2016-03-11 22:17:48 +01:00
Brett Cannon
43dab4bfcf
Merge 'used with permission' additions
2016-01-15 09:54:16 -08:00
Brett Cannon
07b954d148
Add some "used with permission" mentions where external resources are referenced.
...
Permission was validated prior to adding these markings.
2016-01-15 09:53:51 -08:00
Senthil Kumaran
121edbf7e2
Issue25347 - Format the error message output of mock's assert_has_calls method.
...
Patch contributed by Robert Zimmerman.
2016-01-12 06:18:32 -08:00
Senthil Kumaran
81bc927da7
Issue #22138 : Fix mock.patch behavior when patching descriptors. Restore
...
original values after patching.
Patch contributed by Sean McCully.
2016-01-08 23:43:29 -08:00
Martin Panter
d2ad5718ad
Issue #25523 : Further a-to-an corrections new in 3.5
2015-11-02 04:20:33 +00:00
Serhiy Storchaka
153627c111
Marked keystrokes with the :kbd: role.
...
Fixed the case of the "Ctrl-" prefixes.
2015-09-12 17:46:20 +03:00
Serhiy Storchaka
0424eaf753
Marked keystrokes with the :kbd: role.
...
Fixed the case of the "Ctrl-" prefixes.
2015-09-12 17:45:25 +03:00
Berker Peksag
29bf4d403d
Issue #24857 : Comparing call_args to a long sequence now correctly returns a
...
boolean result instead of raising an exception.
Patch by A Kaptur.
2015-09-09 23:39:45 +03:00
Berker Peksag
3fc536f1c9
Issue #24857 : Comparing call_args to a long sequence now correctly returns a
...
boolean result instead of raising an exception.
Patch by A Kaptur.
2015-09-09 23:35:25 +03:00
Robert Collins
079fc7faff
Issue #21112 : Fix regression in unittest.expectedFailure on subclasses.
...
Patch from Berker Peksag.
2015-08-28 10:35:14 +12:00
Robert Collins
ed599b7c84
Issue #21112 : Fix regression in unittest.expectedFailure on subclasses.
...
Patch from Berker Peksag.
2015-08-28 10:34:51 +12:00
Robert Collins
be6caca534
Issue #20362 : Honour TestCase.longMessage correctly in assertRegex.
...
Patch from Ilia Kurenkov.
2015-08-20 11:13:09 +12:00
Berker Peksag
86b34da5ef
Issue #23004 : mock_open() now reads binary data correctly when the type of read_data is bytes.
...
Initial patch by Aaron Hill.
2015-08-06 13:15:51 +03:00
Robert Collins
ca647ef60a
Issue #21750 : Further fixup to be styled like other mock APIs.
2015-07-24 03:48:20 +12:00
Robert Collins
92b3e06517
Typo fix in mock.patch.
...
Patch from https://github.com/testing-cabal/mock/issues/215
2015-07-17 21:58:36 +12:00
Robert Collins
5329aaa74b
Issue #21750 : mock_open.read_data can now be read from each instance, as it
...
could in Python 3.3.
2015-07-17 20:08:45 +12:00
Robert Collins
b37f43f94b
- Issue #18622 : unittest.mock.mock_open().reset_mock would recurse infinitely.
...
Patch from Nicola Palumbo and Laurent De Buyst.
2015-07-15 11:42:28 +12:00
Berker Peksag
abfaecdfdd
Issue #23004 : mock_open() now reads binary data correctly when the type of read_data is bytes.
...
Initial patch by Aaron Hill.
2015-08-06 13:16:52 +03:00
Robert Collins
88ba360c88
Issue #21750 : Further fixup to be styled like other mock APIs.
2015-07-24 03:48:45 +12:00
Robert Collins
1a80081272
Typo fix in mock.patch.
...
Patch from https://github.com/testing-cabal/mock/issues/215
2015-07-17 22:00:28 +12:00
Robert Collins
4838717b53
Issue #21750 : mock_open.read_data can now be read from each instance, as it
...
could in Python 3.3.
2015-07-17 20:10:23 +12:00
Robert Collins
76d508b5d4
- Issue #18622 : unittest.mock.mock_open().reset_mock would recurse infinitely.
...
Patch from Nicola Palumbo and Laurent De Buyst.
2015-07-15 11:49:43 +12:00
Robert Collins
f58f88c4c7
Issue #23661 : unittest.mock side_effects can now be exceptions again.
...
This was a regression vs Python 3.4. Patch from Ignacio Rossi
2015-07-14 13:51:40 +12:00
Serhiy Storchaka
041dd8eef1
Issue #15836 : assertRaises(), assertRaisesRegex(), assertWarns() and
...
assertWarnsRegex() assertments now check the type of the first argument
to prevent possible user error. Based on patch by Daniel Wagner-Hall.
2015-05-21 20:15:40 +03:00
Serhiy Storchaka
e98209c2b4
Issue #24245 : Eliminated senseless expect clauses that have no any effect.
...
Patch by Martin Panter.
2015-05-20 16:10:04 +03:00
Serhiy Storchaka
df573d6ad8
Issue #24134 : assertRaises(), assertRaisesRegex(), assertWarns() and
...
assertWarnsRegex() checks now emits a deprecation warning when callable is
None or keyword arguments except msg is passed in the context manager mode.
2015-05-16 16:29:50 +03:00
Serhiy Storchaka
fe373a5425
Fixed English in error message.
2015-05-06 19:22:55 +03:00
Serhiy Storchaka
4b5367c46d
Fixed English in error message.
2015-05-06 19:21:00 +03:00
Serhiy Storchaka
24d3b7f9df
Issue #24134 : assertRaises(), assertRaisesRegex(), assertWarns() and
...
assertWarnsRegex() checks are not longer successful if the callable is None.
Added tests for assertRaises().
2015-05-06 19:14:47 +03:00
Serhiy Storchaka
e130503c7b
Issue #24134 : assertRaises(), assertRaisesRegex(), assertWarns() and
...
assertWarnsRegex() checks are not longer successful if the callable is None.
Added tests for assertRaises().
2015-05-06 19:13:11 +03:00
Łukasz Langa
a468db9b0b
Issue #23310 : Fix MagicMock's initializer to work with __methods__.
...
Behavior equivalent to m.configure_mock(). Patch by Kasia Jachim.
2015-04-13 23:12:42 -07:00
Brett Cannon
f299abdafa
Issue #23731 : Implement PEP 488.
...
The concept of .pyo files no longer exists. Now .pyc files have an
optional `opt-` tag which specifies if any extra optimizations beyond
the peepholer were applied.
2015-04-13 14:21:02 -04:00
Łukasz Langa
5f6684efe0
Issue #23310 : Fix MagicMock's initializer to work with __methods__.
...
Behavior equivalent to m.configure_mock(). Patch by Kasia Jachim.
2015-04-14 00:12:57 -07:00
Serhiy Storchaka
a7d00c207f
Reverted issue #24134 changes (except new tests).
2015-05-16 16:25:43 +03:00
Antoine Pitrou
8eef6a9ad0
Issue #22903 : The fake test case created by unittest.loader when it fails importing a test module is now picklable.
2015-03-19 00:01:37 +01:00
Antoine Pitrou
d833779cea
Issue #22903 : The fake test case created by unittest.loader when it fails importing a test module is now picklable.
2015-03-18 23:56:46 +01:00
Berker Peksag
7aaa85932c
Issue #23568 : Add rdivmod support to MagicMock() objects.
...
Patch by Håkan Lövdahl.
2015-03-15 01:57:38 +02:00
Berker Peksag
a785dece57
Issue #23568 : Add rdivmod support to MagicMock() objects.
...
Patch by Håkan Lövdahl.
2015-03-15 01:51:56 +02:00
Berker Peksag
9bd8af788d
Issue #23581 : Add matmul support to MagicMock.
...
Patch by Håkan Lövdahl.
2015-03-12 20:42:48 +02:00
Robert Collins
f0c819acd0
Issue #22936 : Allow showing local variables in unittest errors.
2015-03-06 13:46:35 +13:00
Robert Collins
7e28df94ec
unittest: Trivial typo fix.
2015-03-06 11:35:29 +13:00
Serhiy Storchaka
08448a1f4d
Issue #23326 : Removed __ne__ implementations. Since fixing default __ne__
...
implementation in issue #21408 they are redundant.
2015-01-31 12:05:05 +02:00
Serhiy Storchaka
34af5023fc
Issue #21408 : The default __ne__() now returns NotImplemented if __eq__()
...
returned NotImplemented. Removed incorrect implementations of __ne__().
2015-01-26 10:04:15 +02:00
Serhiy Storchaka
f4b7a02e93
Issue #21408 : The default __ne__() now returns NotImplemented if __eq__()
...
returned NotImplemented. Removed incorrect implementations of __ne__().
2015-01-26 09:57:07 +02:00
Antoine Pitrou
18f22989dd
Issue #22894 : TestCase.subTest() would cause the test suite to be stopped when in failfast mode, even in the absence of failures.
2014-11-23 15:55:11 +01:00
Victor Stinner
eb1a995a7c
Issue #22823 : Fix typo in unittest/mock.py
2014-12-11 22:25:49 +01:00
Serhiy Storchaka
c02d188a84
Issue #22823 : Use set literals instead of creating a set from a list.
...
Fixed an output of sets in examples.
2014-12-11 10:28:14 +02:00
Antoine Pitrou
b9079c81dd
Issue #22894 : TestCase.subTest() would cause the test suite to be stopped when in failfast mode, even in the absence of failures.
2014-11-23 15:56:41 +01:00
Robert Collins
68b11d129d
Fix regression in issue 22457 fix.
...
When used in the real world it can under some situations trigger
" assert not _relpath.startswith('..'), "Path must be within the project"
AssertionError: Path must be within the project
"
Because _get_name_from_path was not expecting to be called with the top level
directory.
2014-11-05 03:43:36 +13:00
Robert Collins
bf2bda3c97
Close #22457 : Honour load_tests in the start_dir of discovery.
...
We were not honouring load_tests in a package/__init__.py when that was the
start_dir parameter, though we do when it is a child package. The fix required
a little care since it introduces the possibility of infinite recursion.
2014-11-05 03:09:01 +13:00
Robert Collins
659dd625b4
Close #7559 : ImportError when loading a test now shown as ImportError.
...
Previously the ImportError was only shown if the top level containing
package failed to import, with other ImportErrors showing up as
AttributeError - hiding the real cause. As part of this,
`TestLoader.loadTestsFromNames` now captures errors to self.errors.
2014-10-30 08:27:27 +13:00
Robert Collins
c134584020
Close #22756 : Improve the test output for some assertEqual tests.
...
These tests were undebuggable as written, and there's no testing fallacy
involved in using the method we're testing to test the output of that method,
so switch to that.
2014-10-30 08:16:28 +13:00
Robert Collins
f920c2122b
Close #19746 : expose unittest discovery errors on TestLoader.errors
...
This makes it possible to examine the errors from unittest discovery
without executing the test suite - important when the test suite may
be very large, or when enumerating the test ids from a test suite.
2014-10-20 13:24:05 +13:00
Berker Peksag
1ed2e69a4a
Issue #22186 : Fix typos in Lib/.
...
Patch by Févry Thibault.
2014-10-19 18:07:05 +03:00
Berker Peksag
f23530f569
Issue #22186 : Fix typos in Lib/.
...
Patch by Févry Thibault.
2014-10-19 18:04:38 +03:00
Benjamin Peterson
e87b7eafe4
fix windows tests ( #16662 )
...
From Robert Collins.
2014-09-29 21:54:28 -04:00
Kushal Das
a37b958d65
Closes #21270 : We now override tuple methods in mock.call objects.
2014-09-16 18:33:37 +05:30
Barry Warsaw
bb1e3f1ebe
A few tweaks for issue16662 based on feedback from Robert Collins.
2014-09-08 17:29:02 -04:00
Barry Warsaw
d78742a260
- Issue #16662 : load_tests() is now unconditionally run when it is present in
...
a package's __init__.py. TestLoader.loadTestsFromModule() still accepts
use_load_tests, but it is deprecated and ignored. A new keyword-only
attribute `pattern` is added and documented. Patch given by Robert Collins,
tweaked by Barry Warsaw.
2014-09-08 14:21:37 -04:00
Ezio Melotti
869778e520
#22092 : merge with 3.4.
2014-08-07 03:28:26 +03:00
Ezio Melotti
1241c47aa2
#22092 : use absolute imports in unittest tests. Patch by Vajrasky Kok.
2014-08-07 03:20:22 +03:00
Serhiy Storchaka
521e5860a5
Issue #22032 : __qualname__ instead of __name__ is now always used to format
...
fully qualified class names of Python implemented classes.
2014-07-22 15:00:37 +03:00
R David Murray
130a566a13
Suppress a couple more DeprecationWarnings in the test suite.
2014-06-11 17:09:43 -04:00
Kushal Das
047f14c3c6
Closes #21256 : Printout of keyword args in deterministic order in mock calls.
...
Printout of keyword args should be in deterministic order in
a mock function call. This will help to write better doctests.
2014-06-09 13:45:56 +05:30
Antoine Pitrou
b1e58440f8
Issue #9815 : assertRaises now tries to clear references to local variables in the exception's traceback.
2014-04-29 01:25:07 +02:00
Antoine Pitrou
9681022f1e
Issue #9815 : assertRaises now tries to clear references to local variables in the exception's traceback.
2014-04-29 01:23:50 +02:00
Ethan Furman
7b9ff0e6da
Issue8297: module attribute lookup failures now include module name in error message.
2014-04-24 14:47:47 -07:00
Michael Foord
ebc1a30d55
Closes issue 21239. unittest.mock.patch.stopall() did not work deterministically when the same name was patched multiple times.
2014-04-15 17:21:08 -04:00
Kushal Das
484f8a875b
Closes Issue 21222.
...
Passing name keyword argument to mock.create_autospec now works.
2014-04-16 01:05:50 +05:30
Mark Dickinson
d12290654a
Fix typo in test method name.
2014-04-18 16:08:47 +01:00