Commit Graph

24 Commits

Author SHA1 Message Date
Peter Eisentraut 0e0bc4e221 Fix misleading mentions of tp_size in comments (GH-9093)
Many type object initializations labeled a field "tp_size" in the
comment, but the name of that field is tp_basicsize.
2018-09-10 09:46:08 -07:00
Serhiy Storchaka f1d36d8efa
bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346)
* help(hashlib) didn't work because of incorrect module name in blake2b and
  blake2s classes.
* Constructors blake2*(), sha3_*(), shake_*() and keccak_*() incorrectly
  accepted keyword argument "string" for binary data, but documented as
  accepting the "data" keyword argument. Now this parameter is positional-only.
* Keyword-only parameters in blake2b() and blake2s() were not documented as
  keyword-only.
* Default value for some parameters of blake2b() and blake2s() was None,
  which is not acceptable value.
* The length argument for shake_*.digest() was wrapped out to 32 bits.
* The argument for shake_128.digest() and shake_128.hexdigest() was not
  positional-only as intended.
* TypeError messages for incorrect arguments in all constructors sha3_*(),
  shake_*() and keccak_*() incorrectly referred to sha3_224.

Also made the following enhancements:

* More accurately specified input and result types for strings, bytes and
  bytes-like objects.
* Unified positional parameter names for update() and constructors.
* Improved formatting.
2018-07-31 09:50:16 +03:00
Antoine Pitrou a6a4dc816d bpo-31370: Remove support for threads-less builds (#3385)
* Remove Setup.config
* Always define WITH_THREAD for compatibility.
2017-09-07 18:56:24 +02:00
Serhiy Storchaka 228b12edcc Issue #28999: Use Py_RETURN_NONE, Py_RETURN_TRUE and Py_RETURN_FALSE wherever
possible.  Patch is writen with Coccinelle.
2017-01-23 09:47:21 +02:00
Christian Heimes b00e00c339 Don't define PY_WITH_KECCAK 2016-09-21 14:36:44 +02:00
Christian Heimes c71ec8aef3 sha3: let's keep it simple and always allocate enough extra space for uint64_t[20]. 2016-09-08 15:04:38 +02:00
Christian Heimes cf45ee10fb Issue #16113: SHA3: allocate extra memory for lane extraction and check return value of PyModule_Create() 2016-09-08 13:35:00 +02:00
Christian Heimes b205fe9791 Issue #16113: KeccakP-1600-opt64 does not support big endian platforms yet. 2016-09-07 12:42:47 +02:00
Christian Heimes 6fe2a75b64 Issue #16113: Add SHA-3 and SHAKE support to hashlib module. 2016-09-07 11:58:24 +02:00
Martin v. Löwis 24e43308b7 * Issue #16113: Remove sha3 module again.
Patch by Christian Heimes, with modifications.
2014-01-03 14:05:06 +01:00
Christian Heimes 327dd732ce Issue #18742: Expose the internal hash type object for ABCs. 2013-10-22 15:05:23 +02:00
Christian Heimes 0ce642ebca yet another WITH_THREADS typo 2013-07-31 13:32:40 +02:00
Christian Heimes 6ffa5ce1f3 Fix _sha3 module to actually release the GIL around its update function.
gcov is great.
2013-07-31 11:58:18 +02:00
Christian Heimes 75e923fcf2 Issue #16847: Fixed improper use of _PyUnicode_CheckConsistency() in
non-pydebug builds. Several extension modules now compile cleanly when
assert()s are enabled in standard builds (-DDEBUG flag).
2013-01-03 09:22:41 +01:00
Christian Heimes 743e0cd6b5 Issue #16166: Add PY_LITTLE_ENDIAN and PY_BIG_ENDIAN macros and unified
endianess detection and handling.
2012-10-17 23:52:17 +02:00
Christian Heimes 7707f6fd32 Issue #16234: Modify sha3's block_size method to return NotImplemented.
This makes the sha3 types unusable from the hmac module. HMAC-SHA3 hasn't been specified yet.
2012-10-14 22:16:27 +02:00
Christian Heimes 1f476504fe Update comment: SPARC requires proper alignment 2012-10-14 14:36:09 +02:00
Christian Heimes 12e6a53b99 get 64bit platforms without uint64 right again 2012-10-14 04:17:50 +02:00
Christian Heimes 784fde7cb4 Force 32bit Keccak implementation on SPARC. It look like the Solaris CC compiler doesn't like the address alignment. 2012-10-14 02:52:01 +02:00
Christian Heimes 8836eefb1e brg_endian.h is back again 2012-10-07 23:38:44 +02:00
Christian Heimes dbc573ff29 re-add brg_endian.h to debug issue in big endian SPARC machine 2012-10-07 22:44:41 +02:00
Christian Heimes 2649105cdd remove #warning from sha3module.c 2012-10-06 15:44:29 +02:00
Christian Heimes c018f57186 fix possible memory leak, dealloc newobj 2012-10-06 15:09:06 +02:00
Christian Heimes 4a0270d82b Issue #16113: integrade SHA-3 (Keccak) patch from http://hg.python.org/sandbox/cheimes 2012-10-06 02:23:36 +02:00