56423e5762
Fix segfault when doing string formatting on subclasses of long if
...
__oct__, __hex__ don't return a string.
Klocwork 308
2006-08-13 18:11:08 +00:00
b09f4f578f
Handle a whole lot of failures from PyString_FromInternedString().
...
Should fix most of Klocwork 234-272.
2006-08-13 18:10:28 +00:00
1872b1c01f
Fix a couple of bugs exposed by the new __index__ code. The 64-bit buildbots
...
were failing due to inappropriate clipping of numbers larger than 2**31
with new-style classes. (typeobject.c) In reviewing the code for classic
classes, there were 2 problems. Any negative value return could be returned.
Always return -1 if there was an error. Also make the checks similar
with the new-style classes. I believe this is correct for 32 and 64 bit
boxes, including Windows64.
Add a test of classic classes too.
2006-08-12 18:44:06 +00:00
8a87f5d37e
Patch #1538606 , Patch to fix __index__() clipping.
...
I modified this patch some by fixing style, some error checking, and adding
XXX comments. This patch requires review and some changes are to be expected.
I'm checking in now to get the greatest possible review and establish a
baseline for moving forward. I don't want this to hold up release if possible.
2006-08-12 17:03:09 +00:00
b88cfad318
Check return of PyMem_MALLOC (garbage) is non-NULL.
...
Check seq in both portions of if/else.
Klocwork #289-290.
2006-08-12 03:16:54 +00:00
421c1319ad
Whoops, how did that get in there. :-) Revert all the parts of 51227 that were not supposed to go it. Only Modules/_ctypes/cfields.c was supposed to be changed
2006-08-12 02:12:30 +00:00
6b4953fd3d
Check returned pointer is valid.
...
Klocwork #233
2006-08-12 02:06:34 +00:00
6f5ff3f3eb
Klocwork made another run and found a bunch more problems.
...
This is the first batch of fixes that should be easy to verify based on context.
This fixes problem numbers: 220 (ast), 323-324 (symtable),
321-322 (structseq), 215 (array), 210 (hotshot), 182 (codecs), 209 (etree).
2006-08-12 01:43:40 +00:00
51fc8c456e
Fix and test for an infinite C recursion.
2006-08-09 14:55:26 +00:00
ab2f8f7bd5
__hash__ may now return long int; the final hash
...
value is obtained by invoking hash on the long int.
Fixes #1536021 .
2006-08-09 07:57:39 +00:00
ab1049c046
memcmp() can return values other than -1, 0, and +1 but tp_compare
...
must not.
2006-08-08 17:37:00 +00:00
b0061c8e93
Remove "non-mapping" and "non-sequence" from TypeErrors raised by
...
PyMapping_Size and PySequence_Size.
Because len() tries first sequence, then mapping size, it will always
raise a "non-mapping object has no len" error which is confusing.
2006-08-08 11:56:21 +00:00
0067b5fa2b
Typo fixes
2006-08-04 20:37:43 +00:00
e9462c72bd
Change fix for segfaulting property(), add a NEWS entry and a test.
2006-08-04 18:03:37 +00:00
45381938e9
Fix bug caused by first decrefing, then increfing.
2006-08-04 06:03:53 +00:00
7a36f5f344
SF patch #1534048 (bug #1531003 ): fix typo in error message
2006-08-04 05:17:21 +00:00
c5e060dee6
_PyWeakref_GetWeakrefCount() now returns a Py_ssize_t instead of long.
2006-08-02 06:14:22 +00:00
5a51bf50b8
typo fix
2006-08-01 16:24:30 +00:00
a7edb11122
Whitespace normalization
2006-07-30 06:59:13 +00:00
f71ec5a0ac
Bug #1515471 : string.replace() accepts character buffers again.
...
Pass the char* and size around rather than PyObject's.
2006-07-30 06:57:04 +00:00
52740be425
[Bug #1414697 ] Change docstring of set/frozenset types to specify that the contents are unique. Raymond, please feel free to edit or revert.
2006-07-29 15:10:32 +00:00
101bac205d
Closure can't be NULL at this point since we know it's a tuple.
...
Reported by Klocwork # 74.
2006-07-27 03:55:39 +00:00
c09efa8444
Move the initialization of size_a down below the check for a being NULL.
...
Reported by Klocwork #106
2006-07-23 07:53:14 +00:00
e1fdb32ff2
Handle allocation failures gracefully. Found with failmalloc.
...
Many (all?) of these could be backported.
2006-07-21 05:32:28 +00:00
1adbb50701
Move the initialization of some pointers earlier. The problem is
...
that if we call Py_DECREF(frame) like we do if allocating locals fails,
frame_dealloc() will try to use these bogus values and crash.
2006-07-21 05:31:02 +00:00
48808a1d6c
Add some asserts that we got good params passed
2006-07-21 05:29:58 +00:00
04e39ec815
otherset is known to be non-NULL based on checks before and DECREF after.
...
DECREF otherset rather than XDECREF in error conditions too.
Reported by Klockwork #154 .
2006-07-17 00:57:15 +00:00
b337bb541b
Stop INCREFing name, then checking if it's NULL. name (f_name) should never
...
be NULL so assert it. Fix one place where we could have passed NULL.
Reported by Klocwork #66 .
2006-07-17 00:55:45 +00:00
ee4cc698ca
PyFunction_SetDefaults() is documented as taking None or a tuple.
...
A NULL would crash the PyTuple_Check(). Now make NULL return a SystemError.
Reported by Klocwork #73 .
2006-07-16 02:35:47 +00:00
fc28e0de58
Handle a NULL name properly.
...
Reported by Klocwork #67
2006-07-16 02:32:03 +00:00
4b0a315c31
Use sizeof(buffer) instead of duplicating the constants to ensure they won't
...
be wrong.
The real change is to pass (bufsz - 1) to PyOS_ascii_formatd and 1
to strncat. strncat copies n+1 bytes from src (not dest).
Reported by Klocwork #58 .
2006-07-16 02:22:30 +00:00
ef02b9e144
a & b were dereffed above, so they are known to be valid pointers.
...
z is known to be NULL, nothing to DECREF.
Reported by Klockwork, #107 .
2006-07-16 02:00:32 +00:00
7e49c6eee8
Fix uninitialized memory read reported by Valgrind when running doctest.
...
This could happen if size == 0.
2006-07-12 05:27:46 +00:00
74c3ea0a0f
Fix build problems with the platform SDK on windows. It is not sufficient to test for the C compiler version when determining if we have the secure CRT from microsoft. Must test with an undocumented macro, __STDC_SECURE_LIB__ too.
2006-07-03 14:59:05 +00:00
d5cfa5491a
Put method-wrappers into trashcan. Fixes #927248 .
2006-07-03 13:47:40 +00:00
0f415dc57f
Another problem reported by Coverity. Backport candidate.
2006-06-30 07:32:46 +00:00
b114984225
Fix refleak
2006-06-23 03:32:44 +00:00
53c1692f6a
Fix for an obscure bug introduced by revs 46806 and 46808, with a test.
...
The problem of checking too eagerly for recursive calls is the
following: if a RuntimeError is caused by recursion, and if code needs
to normalize it immediately (as in the 2nd test), then
PyErr_NormalizeException() needs a call to the RuntimeError class to
instantiate it, and this hits the recursion limit again... causing
PyErr_NormalizeException() to never finish.
Moved this particular recursion check to slot_tp_call(), which is not
involved in instantiating built-in exceptions.
Backport candidate.
2006-06-21 21:58:50 +00:00
0f2783cb4c
Use Py_ssize_t
2006-06-19 05:40:44 +00:00
ccff785258
Patch #1507676 : improve exception messages in abstract.c, object.c and typeobject.c.
2006-06-18 22:17:29 +00:00
d825143be1
Patch #1455898 : Incremental mode for "mbcs" codec.
2006-06-14 05:21:04 +00:00
ea3912b0da
If a classic class defined a __coerce__() method that just returned its two
...
arguments in reverse, the interpreter would infinitely recourse trying to get a
coercion that worked. So put in a recursion check after a coercion is made and
the next call to attempt to use the coerced values.
Fixes bug #992017 and closes crashers/coerce.py .
2006-06-13 21:46:41 +00:00
de4c78a1d7
Initialize the type object so pychecker can't crash the interpreter.
2006-06-13 08:28:19 +00:00
f608317061
Fix the CRT argument error handling for VisualStudio .NET 2005. Install a CRT error handler and disable the assertion for debug builds. This causes CRT to set errno to EINVAL.
...
This update fixes crash cases in the test suite where the default CRT error handler would cause process exit.
2006-06-12 15:45:12 +00:00
b9845e72f9
Get rid of f_restricted too. Doc the other 4 ints that were already removed
...
at the NeedForSpeed sprint.
2006-06-12 02:11:18 +00:00
a00c0b97bf
Don't leak the list object if there's an error allocating the item storage. Backport candidate
2006-06-12 02:08:41 +00:00
7d5b6e8991
f_code can't be NULL based on Frame_New and other code that derefs it.
...
So there doesn't seem to be much point to checking here.
2006-06-11 05:48:14 +00:00
8e6675a7dc
Update doc to make it agree with code.
...
Bottom factor out some common code.
2006-06-11 05:47:14 +00:00
9a8ae8f46b
Suppress warning on MacOSX about possible use before set of proc.
2006-06-10 22:38:13 +00:00
0e8bd7e1cc
Patch #1495999 : Part two of Windows CE changes.
...
- update header checks, using autoconf
- provide dummies for getenv, environ, and GetVersion
- adjust MSC_VER check in socketmodule.c
2006-06-10 12:23:46 +00:00
Neal Norwitz
Armin Rigo
Martin v. Löwis
Thomas Heller
Georg Brandl
Andrew M. Kuchling
Fred Drake
Kristján Valur Jónsson
Brett Cannon
Skip Montanaro