Commit Graph

57630 Commits

Author SHA1 Message Date
Gregory P. Smith 9504b13145 Code style fixup: No need for double ((parenthesis)) and use {} on an if else. 2012-12-10 20:20:20 -08:00
Gregory P. Smith a82fe52acc null merge, no change needed in 3.3. 2012-12-10 18:34:29 -08:00
Gregory P. Smith a6be61ec71 Keep y a Py_hash_t instead of Py_uhash_t as it is compared with == -1 and the
compiler logic will do the right thing with just x as a Py_uhash_t.  This
matches what was already done in the 3.3 version.

cleanup only - no functionality or hash values change.
2012-12-10 18:34:09 -08:00
Gregory P. Smith c2176e46d7 Fix the internals of our hash functions to used unsigned values during hash
computation as the overflow behavior of signed integers is undefined.

NOTE: This change is smaller compared to 3.2 as much of this cleanup had
already been done.  I added the comment that my change in 3.2 added so that the
code would match up.  Otherwise this just adds or synchronizes appropriate UL
designations on some constants to be pedantic.

In practice we require compiling everything with -fwrapv which forces overflow
to be defined as twos compliment but this keeps the code cleaner for checkers
or in the case where someone has compiled it without -fwrapv or their
compiler's equivalent.

Found by Clang trunk's Undefined Behavior Sanitizer (UBSan).

Cleanup only - no functionality or hash values change.
2012-12-10 18:32:53 -08:00
Gregory P. Smith 27cbcd6241 Fix the internals of our hash functions to used unsigned values during hash
computation as the overflow behavior of signed integers is undefined.

In practice we require compiling everything with -fwrapv which forces overflow
to be defined as twos compliment but this keeps the code cleaner for checkers
or in the case where someone has compiled it without -fwrapv or their
compiler's equivalent.

Found by Clang trunk's Undefined Behavior Sanitizer (UBSan).

Cleanup only - no functionality or hash values change.
2012-12-10 18:15:46 -08:00
Gregory P. Smith c0dd80e439 1 << 31 is invalid for signed integers, fix it by making 1 unsigned.
Found by Clang trunk's Undefined-Behavior Sanitizer.  [more to come]
2012-12-10 17:45:03 -08:00
Gregory P. Smith 90555d0f0d 1 << 31 is invalid for signed integers, fix it by making 1 unsigned.
Found by Clang trunk's Undefined-Behavior Sanitizer.  [more to come]
2012-12-10 17:44:44 -08:00
Hynek Schlawack c474c4e749 #15872: Some more Windows related tuning to shutil.rmtree tests
Turns out, the snakebite bots behave also their peculiarities.

I'm really not proud of this stream of commits. :(
2012-12-10 16:33:41 +01:00
Hynek Schlawack 87f9b46f15 #15872: Some more Windows related tuning to shutil.rmtree tests
Turns out, the snakebite bots behave also their peculiarities.

I'm really not proud of this stream of commits. :(
2012-12-10 16:29:57 +01:00
Hynek Schlawack f29b4937f7 #15872: Be flexible with appending *.* in shutil.rmtree test case
The Windows buildbots seem to be unable to agree whether they need them or not.
2012-12-10 12:02:26 +01:00
Hynek Schlawack b9e9f3e70d #15872: Be flexible with appending *.* in shutil.rmtree test case
The Windows buildbots seem to be unable to agree whether they need them or not.
2012-12-10 12:01:28 +01:00
Hynek Schlawack 9d5e0cca85 #15872: More shutil test fixes for Windows 2012-12-10 11:08:59 +01:00
Hynek Schlawack 9a4a750673 #15872: More shutil test fixes for Windows 2012-12-10 11:08:09 +01:00
Hynek Schlawack b57b094077 #15872: Fix shutil.rmtree error tests for Windows 2012-12-10 10:08:41 +01:00
Hynek Schlawack 9e8ac56e35 #15872: Fix shutil.rmtree error tests for Windows 2012-12-10 10:07:11 +01:00
Hynek Schlawack b550110f64 #15872: Fix 3.3 regression introduced by the new fd-based shutil.rmtree
It caused rmtree to not ignore certain errors when ignore_errors was set.

Patch by Alessandro Moura and Serhiy Storchaka.
2012-12-10 09:11:25 +01:00
Hynek Schlawack d16eacba48 #15872: Add tests for a 3.3 regression in the new fd-based shutil.rmtree
It cause shutil.rmtree not ignore all errors. Also add a test ensuring that
rmtree fails when being called on a symlink. Patch by Serhiy Storchaka.
2012-12-10 09:00:09 +01:00
Chris Jerdonek af72f9ea9c Issue #16629: Merge IDLE test fix from 3.2. 2012-12-09 18:19:54 -08:00
Chris Jerdonek 175196886e Issue #16629: Fix IDLE idlelib.CallTips test. Patch by Roger Serwy.
This commit updates a test broken by the change made for issue #14783.
2012-12-09 18:17:27 -08:00
Andrew Svetlov 14857cf8fa Issue #16582: use int exit code in tkinter._exit 2012-12-10 00:03:39 +02:00
Andrew Svetlov 806bfad457 Issue #16582: use int exit code in tkinter._exit 2012-12-10 00:02:31 +02:00
Senthil Kumaran 50cdd55af9 merge from 3.2 - reason attribute for urllib.error.HTTPError 2012-12-09 13:52:31 -08:00
Senthil Kumaran 2e72831369 Fix issue13211 - Document the reason attribute for urllib.error.HTTPError 2012-12-09 13:51:05 -08:00
Benjamin Peterson 4b7743a3ef merge 3.2 2012-12-09 10:16:46 -05:00
Benjamin Peterson 4ee03fa4d5 merge 3.1 2012-12-09 10:14:42 -05:00
Antoine Pitrou 373528f6b1 Issue #16248: Disable code execution from the user's home directory by tkinter when the -E flag is passed to Python.
Patch by Zachary Ware.
2012-12-09 14:46:46 +01:00
Antoine Pitrou 7ec3a32360 Issue #16248: Disable code execution from the user's home directory by tkinter when the -E flag is passed to Python.
Patch by Zachary Ware.
2012-12-09 14:46:18 +01:00
Antoine Pitrou 0ee20ebbff Issue #16248: Disable code execution from the user's home directory by tkinter when the -E flag is passed to Python.
Patch by Zachary Ware.
2012-12-09 14:46:18 +01:00
Nick Coghlan 0eee97cce6 Issue #15209: Fix typo and some additional wording tweaks 2012-12-09 16:21:46 +10:00
Éric Araujo 3f7c0e4036 Merge fixes for #13614, #13512 and #7719 from 3.2 2012-12-08 22:53:43 -05:00
Éric Araujo 24457c9ad3 Branch merge 2012-12-08 22:47:03 -05:00
Éric Araujo 8b503c0a4e Fix setup.py register failure with invalid rst in description (#13614).
Original patch by Julien Courteau and Pierre Paul Lefebvre.
2012-12-08 22:41:11 -05:00
Éric Araujo 9bc9ab5f85 Fix a few markup/grammar nits 2012-12-08 18:35:31 -05:00
Antoine Pitrou f93ed3fa67 Issue #16602: When a weakref's target was part of a long deallocation chain, the object could remain reachable through its weakref even though its refcount had dropped to zero.
Thanks to Eugene Toder for diagnosing and reporting the issue.
2012-12-08 21:17:03 +01:00
Antoine Pitrou 62a0d6ea40 Issue #16602: When a weakref's target was part of a long deallocation chain, the object could remain reachable through its weakref even though its refcount had dropped to zero.
Thanks to Eugene Toder for diagnosing and reporting the issue.
2012-12-08 21:15:26 +01:00
Éric Araujo d61926e6be Create ~/.pypirc securely (#13512).
There was a window between the write and the chmod where the user’s
password would be exposed, depending on default permissions.  Philip
Jenvey’s patch fixes it.
2012-12-08 14:51:47 -05:00
Éric Araujo 3e4a3dcb23 Ignore .nfs* files in distutils (#7719).
These files are created by some NFS clients a file is edited and removed
concurrently (see added link in doc for more info).  If such a file is
removed between distutils calls listdir and copy, it will get confused.
Other special files are ignored in sdist (namely VCS directories), but
this has to be filtered out earlier.
2012-12-08 14:21:51 -05:00
Andrew Svetlov a7129d38ed Drop double newlines printed in some file iteration examples.
Patch by Steven Kryskalla.
2012-12-08 17:59:23 +02:00
Andrew Svetlov 09974b4e9e Drop double newlines printed in some file iteration examples.
Patch by Steven Kryskalla.
2012-12-08 17:59:03 +02:00
Nick Coghlan cea27be888 Close issue #16267: better docs for @abstractmethod composition 2012-12-08 22:56:02 +10:00
Nick Coghlan 8e18fc8c0b Issue #15209: Clarify exception chaining description
- not allowed when implicitly re-raised the current exception
- last exception raised is always displayed last
- attempt to make it clearer when/if cause and context are shown
2012-12-08 21:39:24 +10:00
Ezio Melotti c990f3b167 Merge debug output removal with 3.2. 2012-12-08 12:30:44 +02:00
Ezio Melotti 5a2e2b8ff7 Remove debug output from example. 2012-12-08 12:29:40 +02:00
Antoine Pitrou 12f33df4a2 Issue #16628: Fix a memory leak in ctypes.resize(). 2012-12-08 11:07:16 +01:00
Antoine Pitrou 305e1a749f Issue #16628: Fix a memory leak in ctypes.resize(). 2012-12-08 11:05:50 +01:00
Andrew Svetlov f04d1bb170 Specify which I/O ABC methods have implementations in the docs. 2012-12-06 12:21:12 +02:00
Andrew Svetlov ed636a84b9 Specify which I/O ABC methods have implementations in the docs. 2012-12-06 12:20:56 +02:00
Andrew Svetlov c37cfd6709 Update comment: SAVE_EXC_STATE and SWAP_EXC_STATE macroses are saave_exc_state and swap_exc_state functions now. 2012-12-05 17:59:10 +02:00
Andrew Svetlov f0eb7adc7f Merge: skip pdb test for #13120 if threading is not available. 2012-12-05 15:06:54 +02:00
Andrew Svetlov 96bc04369a Skip pdb test for #13120 if threading is not available. 2012-12-05 15:06:23 +02:00