cpython

Commit Graph

Author	SHA1	Message	Date
Pablo Galindo	2ab2afd387	bpo-35426: Eliminate race condition in test_interprocess_signal (GH-11087) The test only except SIGUSR1Exception inside wait_signal(), but the signal can be sent during subprocess_send_signal() call.	2018-12-11 11:32:12 +00:00
Victor Stinner	9abee722d4	bpo-31479: Always reset the signal alarm in tests (#3588 ) * bpo-31479: Always reset the signal alarm in tests Use "try: ... finally: signal.signal(0)" pattern to make sure that tests don't "leak" a pending fatal signal alarm. * Move two more alarm() calls into the try block Fix also typo: replace signal.signal(0) with signal.alarm(0) * Move another signal.alarm() into the try block	2017-09-19 09:36:54 -07:00
Victor Stinner	32eb840a42	Issue #26566 : Rewrite test_signal.InterProcessSignalTests * Add Lib/test/signalinterproctester.py * Don't disable the garbage collector anymore * Don't use os.fork() with a subprocess to not inherit existing signal handlers or threads: start from a fresh process * Don't use UNIX kill command to send a signal but Python os.kill() * Use a timeout of 10 seconds to wait for the signal instead of 1 second * Always use signal.pause(), instead of time.wait(1), to wait for a signal * Use context manager on subprocess.Popen * remove code to retry on EINTR: it's no more needed since the PEP 475 * remove unused function exit_subprocess() * Cleanup the code	2016-03-15 11:12:35 +01:00

Author

SHA1

Message

Date

Pablo Galindo

2ab2afd387

bpo-35426: Eliminate race condition in test_interprocess_signal (GH-11087)

The test only except SIGUSR1Exception inside wait_signal(), but the signal can be sent during subprocess_send_signal() call.

2018-12-11 11:32:12 +00:00

Victor Stinner

9abee722d4

bpo-31479: Always reset the signal alarm in tests (#3588 )

* bpo-31479: Always reset the signal alarm in tests

Use "try: ... finally: signal.signal(0)" pattern to make sure that
tests don't "leak" a pending fatal signal alarm.

* Move two more alarm() calls into the try block

Fix also typo: replace signal.signal(0) with signal.alarm(0)

* Move another signal.alarm() into the try block

2017-09-19 09:36:54 -07:00

Victor Stinner

32eb840a42

Issue #26566 : Rewrite test_signal.InterProcessSignalTests

* Add Lib/test/signalinterproctester.py
* Don't disable the garbage collector anymore
* Don't use os.fork() with a subprocess to not inherit existing signal handlers
  or threads: start from a fresh process
* Don't use UNIX kill command to send a signal but Python os.kill()
* Use a timeout of 10 seconds to wait for the signal instead of 1 second
* Always use signal.pause(), instead of time.wait(1), to wait for a signal
* Use context manager on subprocess.Popen
* remove code to retry on EINTR: it's no more needed since the PEP 475
* remove unused function exit_subprocess()
* Cleanup the code

2016-03-15 11:12:35 +01:00

3 Commits