Commit Graph

19 Commits

Author SHA1 Message Date
Guido van Rossum 47b9ff6ba1 Restructure comparison dramatically. There is no longer a default
*ordering* between objects; there is only a default equality test
(defined by an object being equal to itself only).  Read the comment
in object.c.  The current implementation never uses a three-way
comparison to compute a rich comparison, but it does use a rich
comparison to compute a three-way comparison.  I'm not quite done
ripping out all the calls to PyObject_Compare/Cmp, or replacing
tp_compare implementations with tp_richcompare implementations;
but much of that has happened (to make most unit tests pass).

The following tests still fail, because I need help deciding
or understanding:

test_codeop -- depends on comparing code objects
test_datetime -- need Tim Peters' opinion
test_marshal -- depends on comparing code objects
test_mutants -- need help understanding it

The problem with test_codeop and test_marshal is this: these tests
compare two different code objects and expect them to be equal.
Is that still a feature we'd like to support?  I've temporarily
removed the comparison and hash code from code objects, so they
use the default (equality by pointer only) comparison.

For the other two tests, run them to see for yourself.
(There may be more failing test with "-u all".)

A general problem with getting lots of these tests to pass is
the reality that for object types that have a natural total ordering,
implementing __cmp__ is much more convenient than implementing
__eq__, __ne__, __lt__, and so on.  Should we go back to allowing
__cmp__ to provide a total ordering?  Should we provide some other
way to implement rich comparison with a single method override?
Alex proposed a __key__() method; I've considered a __richcmp__()
method.  Or perhaps __cmp__() just shouldn't be killed off...
2006-08-24 00:41:19 +00:00
Just van Rossum 2dae7646c3 On second thought: "Errors should never pass silently", so barf when a
string contains control chars that are illegal for XML
2004-11-12 09:36:12 +00:00
Just van Rossum b84330d368 - \f is not a valid XML character
- reformatted regex pattern, use r"" consistently
2004-11-12 08:14:49 +00:00
Just van Rossum 26e811abd5 reordered a couple of things 2004-11-12 08:02:35 +00:00
Just van Rossum 1f74ef0fa3 Made <data> output match Apple's exactly. To do that I had to add a custom
version of base64.encodestring() so I could control the line length of the
base64 output.
2004-10-26 10:30:55 +00:00
Just van Rossum 8b8decea21 also escape '>', to closer match Apple's plist output 2004-10-26 10:11:00 +00:00
Just van Rossum 368c0b22f8 Deprecating Dict class; going through a few hoops to get the warnings right. 2004-10-26 07:38:16 +00:00
Just van Rossum 7c9448755b - Removed Date class. We don't really need it for b/w compatibility since
a) the functionality depended on PyXML before and b) hardly worked to
  begin with.
- Instead, output and require upon input datetime.datetime objects.
2004-10-26 07:20:26 +00:00
Just van Rossum c6fdd1b398 - added two more convenience functions: readPlistFromString() and
writePlistToString()
- use these two in the resource functions.
- Tweaked module doc string.
2004-10-26 06:50:50 +00:00
Just van Rossum 15cf4f0100 Updated doc strings. 2004-10-25 16:10:53 +00:00
Just van Rossum 86ca902eed Deprecate Plist class 2004-10-25 16:09:10 +00:00
Just van Rossum 10e52dbe28 Removed superfluous **kwargs constructor cruft: this class predates
the dict(**kwargs) feature.
2004-10-25 16:04:20 +00:00
Just van Rossum 95387a1895 Patch from Bob Ippolito, slighly edited:
[ 1052399 ] plistlib: add plst resource functionality, fix bugs
2004-10-25 15:10:42 +00:00
Just van Rossum 2cdd608601 removed 2.2 support 2004-10-02 14:06:56 +00:00
Just van Rossum 4c3d054d3d Which reminds me, I've had a much improved plistlib.py lying around for
ages. The main improvements are:
- a much more convenient API: readPlist() and writePlist()
- support non-dict top-level objects
2004-10-02 08:40:47 +00:00
Just van Rossum 87316ec962 don't optimize empty strings 2003-07-10 14:26:06 +00:00
Just van Rossum 94af32e244 - replaced a couple of asserts with proper exceptions
- use isinstance instead of flaky file-detection code
2003-07-01 20:15:38 +00:00
Jack Jansen 0ae3220736 Detabbed. 2003-04-09 13:25:43 +00:00
Jack Jansen 60087fb450 Moved most of Mac/Lib hierarchy to Lib/plat-mac: it can be used both
in MacPython-OS9 and MacPython-OSX (or the equivalent unix Python on
Mac OS X). The only items remaining in Mac/Lib are modules that are
meaningful only for MacPython-OS9 (CFM stuff, MacPython preferences
in resources, etc).
2002-12-30 22:04:23 +00:00