Commit Graph

19389 Commits

Author SHA1 Message Date
Berker Peksag 5f59ddddcd Issue #28229: lzma module now supports pathlib 2016-10-04 20:41:20 +03:00
Serhiy Storchaka a854090c13 Issue #28321: Fixed writing non-BMP characters with binary format in plistlib. 2016-10-04 20:08:59 +03:00
Serhiy Storchaka db8d6265fa Issue #28321: Fixed writing non-BMP characters with binary format in plistlib. 2016-10-04 20:08:29 +03:00
Serhiy Storchaka 7338ebc4ba Issue #28321: Fixed writing non-BMP characters with binary format in plistlib. 2016-10-04 20:04:30 +03:00
Steven D'Aprano fae2829c7a Issue #27181 remove geometric_mean and defer for 3.7. 2016-10-05 03:24:45 +11:00
Serhiy Storchaka 7fd9f4b458 Merge heads 2016-10-04 18:23:55 +03:00
Serhiy Storchaka a67e5cad1d Issue #28350: String constants with null character no longer interned. 2016-10-04 18:21:53 +03:00
Serhiy Storchaka e81b0d335b Issue #28350: String constants with null character no longer interned. 2016-10-04 18:21:25 +03:00
Serhiy Storchaka 09f3d080fe Issue #28350: String constants with null character no longer interned. 2016-10-04 18:17:22 +03:00
Benjamin Peterson b983b8de9d merge 3.6 (#26617) 2016-10-04 00:00:35 -07:00
Benjamin Peterson 804480912c merge 3.5 (#26617) 2016-10-04 00:00:23 -07:00
Benjamin Peterson 8f657c35b9 ensure gc tracking is off when invoking weakref callbacks (closes #26617) 2016-10-04 00:00:02 -07:00
Steve Dower cc30fc72c6 Add myself to the ACKS file. 2016-10-03 11:16:17 -07:00
Steve Dower 4a8ff9ef60 Issue #28217: Adds _testconsole module to test console input. 2016-10-03 09:12:42 -07:00
Steve Dower 312cef7452 Issue #28217: Adds _testconsole module to test console input. Fixes some issues found by the tests. 2016-10-03 09:04:58 -07:00
Berker Peksag f63f12b479 Issue #28225: Merge from 3.6 2016-10-02 20:07:38 +03:00
Berker Peksag 8bdd4480c4 Issue #28225: bz2 module now supports pathlib
Initial patch by Ethan Furman.
2016-10-02 20:07:06 +03:00
Berker Peksag c8ce8434e0 Issue #28227: Merge from 3.6 2016-10-02 13:49:05 +03:00
Berker Peksag 03020cfa97 Issue #28227: gzip now supports pathlib
Patch by Ethan Furman.
2016-10-02 13:47:58 +03:00
Serhiy Storchaka 6a7d3480fc Issue #28332: Deprecated silent truncations in socket.htons and socket.ntohs.
Original patch by Oren Milman.
2016-10-02 12:34:40 +03:00
Serhiy Storchaka 2e84de3638 Issue #27358: Optimized merging var-keyword arguments and improved error
message when pass a non-mapping as a var-keyword argument.
2016-10-02 11:07:29 +03:00
Serhiy Storchaka e036ef8fa2 Issue #27358: Optimized merging var-keyword arguments and improved error
message when pass a non-mapping as a var-keyword argument.
2016-10-02 11:06:43 +03:00
Serhiy Storchaka 775a0ea0da Issue #28257: Improved error message when pass a non-iterable as
a var-positional argument.  Added opcode BUILD_TUPLE_UNPACK_WITH_CALL.
2016-10-02 10:34:46 +03:00
Serhiy Storchaka 7344285c19 Issue #28257: Improved error message when pass a non-iterable as
a var-positional argument.  Added opcode BUILD_TUPLE_UNPACK_WITH_CALL.
2016-10-02 10:33:46 +03:00
Serhiy Storchaka 18c5e8e86f Issue #28322: Fixed possible crashes when unpickle itertools objects from
incorrect pickle data.  Based on patch by John Leitch.
2016-10-02 09:17:08 +03:00
Serhiy Storchaka 8f0f205649 Issue #28322: Fixed possible crashes when unpickle itertools objects from
incorrect pickle data.  Based on patch by John Leitch.
2016-10-02 09:13:14 +03:00
Serhiy Storchaka 85c3f268f4 Issue #28322: Fixed possible crashes when unpickle itertools objects from
incorrect pickle data.  Based on patch by John Leitch.
2016-10-02 08:34:53 +03:00
Zachary Ware 854adb1e01 Issue #21124: Fix building _struct on Cygwin.
Patch by Masayuki Yamamoto.
2016-10-02 00:33:39 -05:00
Ned Deily 14b4b41cdc Issue #28325: Remove vestigal MacOS 9 macurl2path module and its tests. 2016-10-01 22:05:07 -04:00
Zachary Ware 3839d99b79 Issue #13756: Fix building extensions modules on Cygwin
Patch by Roumen Petrov, based on original patch by Jason Tishler.
2016-10-01 16:15:09 -05:00
Zachary Ware 6a6967e827 Issue #21085: add configure check for siginfo_t.si_band
Patch by Masayuki Yamamoto, reviewed and rebased by Erik Bray.

This is a first step on the long road toward resupporting Cygwin, which does
not provide siginfo_t.si_band.
2016-10-01 00:47:27 -05:00
Martin Panter efd1bf4434 Issue #28275: Merge bz2 fix from 3.6 2016-10-01 03:21:22 +00:00
Martin Panter 55c9239af6 Issue #28275: Merge bz2 fix from 3.5 into 3.6 2016-10-01 03:11:04 +00:00
Martin Panter 38317d3318 Issue #28275: Clean up to avoid use-after-free after bzip decompress failure 2016-10-01 02:45:17 +00:00
Berker Peksag c4bd96cce2 Issue #28228: Merge from 3.6 2016-10-01 05:02:22 +03:00
Berker Peksag ef223a19f7 Issue #28228: imghdr now supports pathlib 2016-10-01 05:01:54 +03:00
Berker Peksag 31f63da2e8 Issue #28226: Merge from 3.6 2016-10-01 00:54:55 +03:00
Berker Peksag 812a2b65af Issue #28226: compileall now supports pathlib 2016-10-01 00:54:18 +03:00
Terry Jan Reedy 36925001e6 Merge with 3.6 2016-09-30 15:39:22 -04:00
Terry Jan Reedy b4b55eb582 Merge with 3.5 2016-09-30 15:39:05 -04:00
Terry Jan Reedy 30eee4deec Issue #28815: Change '?' to '<module>' in some doc examples.
Patch by Mariatta Wijaya.
2016-09-30 15:38:48 -04:00
Serhiy Storchaka be9cddb302 Issue #27942: String constants now interned recursively in tuples and frozensets. 2016-09-30 10:36:15 +03:00
Serhiy Storchaka 3738c2d8ae Issue #27942: String constants now interned recursively in tuples and frozensets. 2016-09-30 10:23:01 +03:00
Serhiy Storchaka 00a0fc1144 Issue #27942: String constants now interned recursively in tuples and frozensets. 2016-09-30 10:07:26 +03:00
Victor Stinner 701fb4ba9a Merge 3.6 2016-09-29 22:14:02 +02:00
Victor Stinner 84d8baadbe Fix xml.etree.ElementTree.Element.getiterator()
Issue #28314: Fix function declaration (C flags) for the getiterator() method
of xml.etree.ElementTree.Element.
2016-09-29 22:12:35 +02:00
Serhiy Storchaka cf6d2d90c5 Issue #28258: Fixed build with Estonian locale (python-config and distclean
targets in Makefile).  Patch by Arfrever Frehtes Taifersar Arahesis.
2016-09-29 20:39:45 +03:00
Serhiy Storchaka 80bc7dc59e Issue #28258: Fixed build with Estonian locale (python-config and distclean
targets in Makefile).  Patch by Arfrever Frehtes Taifersar Arahesis.
2016-09-29 20:29:23 +03:00
Benjamin Peterson 095e32bfc5 merge 3.5 (#1703178) 2016-09-28 23:17:04 -07:00
Benjamin Peterson 4254e8c548 build_ext: correctly parse the link_objects user option (closes #1703178)
Patch by Valerie Lambert.
2016-09-28 23:13:58 -07:00
Terry Jan Reedy 6c58c34dd3 IDLE NEWS item and ack. 2016-09-28 21:55:55 -04:00
Alexander Belopolsky 3b7cfd4ffe Issue #28148: Added a NEWS entry. 2016-09-28 17:39:29 -04:00
Alexander Belopolsky 3e7a3cb903 Issue #28148: Stop using localtime() and gmtime() in the time module.
Introduced platform independent _PyTime_localtime API that is similar
to POSIX localtime_r, but available on all platforms.  Patch by Ed
Schouten.
2016-09-28 17:31:35 -04:00
Serhiy Storchaka e9e44484a5 Issue #28289: ImportError.__init__ now resets not specified attributes. 2016-09-28 07:53:32 +03:00
Serhiy Storchaka 2e8c939e3d Issue #28258: Fixed build with Estonian locale (python-config and distclean
targets in Makefile).  Patch by Arfrever Frehtes Taifersar Arahesis.
2016-09-29 20:46:08 +03:00
Benjamin Peterson 6224b67865 merge 3.6 (#1703178) 2016-09-28 23:17:12 -07:00
Alexander Belopolsky dc336f28db Merged from 3.6 2016-09-28 17:40:25 -04:00
Alexander Belopolsky 9f518cd01a Merged from 3.6 2016-09-28 17:32:31 -04:00
Alexander Belopolsky 1dc7aa4d2e Issue #28253: Added a NEWS entry. 2016-09-27 20:34:17 -04:00
Alexander Belopolsky 0c6974d934 Issue #28253: Added a NEWS entry. 2016-09-27 20:34:11 -04:00
Alexander Belopolsky f2a913e53b Issue #28253: Added a NEWS entry. 2016-09-27 20:33:58 -04:00
Serhiy Storchaka a6f035ee8d Issue #21578: Fixed misleading error message when ImportError called with
invalid keyword args.
2016-09-27 20:51:27 +03:00
Serhiy Storchaka 389ef9dcda Issue #21578: Fixed misleading error message when ImportError called with
invalid keyword args.
2016-09-27 20:51:04 +03:00
Serhiy Storchaka 47dee11ba7 Issue #21578: Fixed misleading error message when ImportError called with
invalid keyword args.
2016-09-27 20:45:35 +03:00
Serhiy Storchaka be43f2019f Issue #28275: Fixed possible use adter free in LZMADecompressor.decompress().
Original patch by John Leitch.
2016-09-27 20:24:19 +03:00
Serhiy Storchaka a12e7842a5 Issue #28275: Fixed possible use adter free in LZMADecompressor.decompress().
Original patch by John Leitch.
2016-09-27 20:23:41 +03:00
Serhiy Storchaka c0b7037d4f Issue #28275: Fixed possible use adter free in LZMADecompressor.decompress().
Original patch by John Leitch.
2016-09-27 20:14:26 +03:00
Raymond Hettinger b87e8f7d0a merge 2016-09-26 21:46:26 -07:00
Raymond Hettinger 9016f2864a Issue #18844: Make the number of selections a keyword-only argument for random.choices(). 2016-09-26 21:45:57 -07:00
Serhiy Storchaka 9204a20452 Issue #27897: Fixed possible crash in sqlite3.Connection.create_collation()
if pass invalid string-like object as a name.  Patch by Xiang Zhang.
2016-09-27 00:16:25 +03:00
Serhiy Storchaka 22805ca54e Issue #27897: Fixed possible crash in sqlite3.Connection.create_collation()
if pass invalid string-like object as a name.  Patch by Xiang Zhang.
2016-09-27 00:14:24 +03:00
Serhiy Storchaka 407ac47690 Issue #27897: Fixed possible crash in sqlite3.Connection.create_collation()
if pass invalid string-like object as a name.  Patch by Xiang Zhang.
2016-09-27 00:10:03 +03:00
Berker Peksag 37dd202f14 Issue #18893: Merge from 3.6 2016-09-26 23:07:58 +03:00
Berker Peksag 11179b2ed7 Issue #18893: Merge from 3.5 2016-09-26 23:07:38 +03:00
Berker Peksag 8b6b50814e Issue #18893: Fix invalid exception handling in Lib/ctypes/macholib/dyld.py
Patch by Madison May.
2016-09-26 23:06:32 +03:00
Serhiy Storchaka 06c6eeec51 Issue #27611: Fixed support of default root window in the tkinter.tix module.
Added the master parameter in the DisplayStyle constructor.
2016-09-25 16:54:17 +03:00
Serhiy Storchaka 1aca3899fb Issue #27611: Fixed support of default root window in the tkinter.tix module.
Added the master parameter in the DisplayStyle constructor.
2016-09-25 16:52:13 +03:00
Serhiy Storchaka e6f0199c19 Issue #27611: Fixed support of default root window in the tkinter.tix module. 2016-09-25 16:46:10 +03:00
Mark Dickinson 3992d6e5e1 Issue #28203: Merge from 3.6 2016-09-24 15:29:07 +01:00
Mark Dickinson 6997946ec4 Issue #28203: Merge from 3.5 2016-09-24 15:28:34 +01:00
Mark Dickinson 613f8e513c Issue #28203: Fix incorrect type in error message from complex(1.0, {2:3}). Patch by Soumya Sharma. 2016-09-24 15:26:36 +01:00
Steve Dower 3e7d93dc70 Issue #28251: Improvements to help manuals on Windows. 2016-09-22 17:11:53 -07:00
Steve Dower 765285337a Issue #28251: Improvements to help manuals on Windows. 2016-09-22 17:09:56 -07:00
Steve Dower fb4a96a58f Issue #28251: Improvements to help manuals on Windows. 2016-09-22 17:07:56 -07:00
Serhiy Storchaka f02f93ecca Issue #28086: Single var-positional argument of tuple subtype was passed
unscathed to the C-defined function.  Now it is converted to exact tuple.
2016-09-22 19:43:38 +03:00
Serhiy Storchaka 63dc548109 Issue #28086: Single var-positional argument of tuple subtype was passed
unscathed to the C-defined function.  Now it is converted to exact tuple.
2016-09-22 19:41:20 +03:00
Martin Panter 2e610df572 Merge socketserver fixes from 3.6 2016-09-22 10:34:50 +00:00
Martin Panter 21efc0bbf8 Issue #27348: Merge exception formatting fix from 3.6 2016-09-22 10:34:25 +00:00
Martin Panter 3217b1243e Merge socketserver fixes from 3.5 into 3.6 2016-09-22 10:33:51 +00:00
Martin Panter f3b0639417 Issue #27348: Merge exception formatting fix from 3.5 into 3.6 2016-09-22 10:33:21 +00:00
Martin Panter 463ef2b3cf Fix references to Python 3’s socketserver (lowercase) module 2016-09-22 09:37:56 +00:00
Martin Panter bb8b1cb6af Issue #27348: Restore “Exception: None” formatting in traceback module
This fixes a regression caused by revision 73afda5a4e4c. Also reverts the
decimal test workaround added in revision 5f3dd0a2b1ab.

Remove test_without_exception(). According to revision ecaafc32c500, this was
added in Python 2 so that print_exc() would output “None” when called with no
exception set. However print_exc() never worked like this in Python 3, and
the use case is not documented.

Restore TracebackCases class name (instead of SyntaxTracebackCases), because
the class also tests other exceptions.
2016-09-22 09:37:39 +00:00
Berker Peksag c96629953b Issue #25651: Merge from 3.6 2016-09-21 19:35:54 +03:00
Berker Peksag b3d4e7fe71 Issue #25651: Merge from 3.5 2016-09-21 19:35:28 +03:00
Berker Peksag 16ea19fc66 Issue #25651: Allow falsy values to be used for msg parameter of subTest() 2016-09-21 19:34:15 +03:00
Serhiy Storchaka cf4fb40b9d Issue #28214: Now __set_name__ is looked up on the class instead of the
instance.
2016-09-21 15:55:49 +03:00
Serhiy Storchaka afd02a439f Issue #28214: Now __set_name__ is looked up on the class instead of the
instance.
2016-09-21 15:54:59 +03:00
Victor Stinner b6f3c0dca1 Merge 3.6 (os.getrandom) 2016-09-20 23:01:22 +02:00
Victor Stinner ec2319c46d Fix memleak in os.getrandom()
Issue #27778: Fix a memory leak in os.getrandom() when the getrandom() is
interrupted by a signal and a signal handler raises a Python exception.

Modify also os_getrandom_impl() to avoid the temporary buffer, use directly a
Python bytes object.
2016-09-20 23:00:59 +02:00
Victor Stinner 6b405d2f2b Merge 3.6 2016-09-20 22:50:11 +02:00
Victor Stinner 75024c6589 (Merge 3.5) Catch EPERM error in py_getrandom()
Issue #27955: Fallback on reading /dev/urandom device when the getrandom()
syscall fails with EPERM, for example when blocked by SECCOMP.
2016-09-20 22:49:52 +02:00
Victor Stinner 6d8bc46cc0 Catch EPERM error in py_getrandom()
Issue #27955: Fallback on reading /dev/urandom device when the getrandom()
syscall fails with EPERM, for example when blocked by SECCOMP.
2016-09-20 22:46:02 +02:00
Benjamin Peterson adaa56ac35 merge 3.6 (closes #28184) 2016-09-19 22:17:44 -07:00
Benjamin Peterson e2e792d98f merge 3.5 (#28184) 2016-09-19 22:17:16 -07:00
Benjamin Peterson 918aa89483 remove trailing whitespace 2016-09-19 22:16:36 -07:00
Victor Stinner 822675b82e Merge 3.6 2016-09-19 11:56:06 +02:00
Victor Stinner 26c03bd7d5 Fix memory leak in path_converter()
Issue #28200: Replace PyUnicode_AsWideCharString() with
PyUnicode_AsUnicodeAndSize().
2016-09-19 11:55:44 +02:00
Raymond Hettinger 7eb1becc25 Issue #28189: dictitems_contains no longer swallows compare errors.
(Patch by Xiang Zhang)
2016-09-18 21:45:11 -07:00
Berker Peksag 76ab4164e5 Issue #25400: Merge from 3.6 2016-09-18 20:18:35 +03:00
Berker Peksag 9a7bbb2e3f Issue #25400: RobotFileParser now correctly returns default values for crawl_delay and request_rate
Initial patch by Peter Wirtz.
2016-09-18 20:17:58 +03:00
Christian Heimes aa630e051b Issue #26661: setup.py now detects system libffi with multiarch wrapper. 2016-09-18 14:35:39 +02:00
Christian Heimes 85c98bf968 Issue #26661: setup.py now detects system libffi with multiarch wrapper. 2016-09-18 14:34:13 +02:00
Christian Heimes 96b2dd5997 Issue #26661: setup.py now detects system libffi with multiarch wrapper. 2016-09-18 14:33:30 +02:00
Steve Dower 5f9c3926cc Issue #27932: Prevent memory leak in win32_ver(). 2016-09-17 17:28:45 -07:00
Steve Dower 74f4af7ac3 Issue #27932: Prevent memory leak in win32_ver(). 2016-09-17 17:27:48 -07:00
Steve Dower 1ec262be80 Issue #27932: Prevent memory leak in win32_ver(). 2016-09-17 17:25:42 -07:00
Steve Dower f4fc1d12ec Issue #28110: launcher.msi has different product codes between 32-bit and 64-bit 2016-09-17 16:14:14 -07:00
Steve Dower 7358efa50b Issue #28110: launcher.msi has different product codes between 32-bit and 64-bit 2016-09-17 16:13:59 -07:00
Steve Dower 1c75c18ed2 Issue #28110: launcher.msi has different product codes between 32-bit and 64-bit 2016-09-17 16:12:55 -07:00
Steve Dower b401d723ac Issue #28161: Opening CON for write access fails
Issue #28162: WindowsConsoleIO readall() fails if first line starts with Ctrl+Z
Issue #28163: WindowsConsoleIO fileno() passes wrong flags to _open_osfhandle
Issue #28164: _PyIO_get_console_type fails for various paths
2016-09-17 13:51:32 -07:00
Steve Dower 27f26ad962 Issue #28161: Opening CON for write access fails
Issue #28162: WindowsConsoleIO readall() fails if first line starts with Ctrl+Z
Issue #28163: WindowsConsoleIO fileno() passes wrong flags to _open_osfhandle
Issue #28164: _PyIO_get_console_type fails for various paths
2016-09-17 13:51:23 -07:00
Berker Peksag ce4adc30de Issue #26384: Merge from 3.6 2016-09-17 23:23:35 +03:00
Berker Peksag 5d625cff07 Issue #26384: Merge from 3.5 2016-09-17 23:23:13 +03:00
Berker Peksag bcfb35f80d Issue #26384: Fix UnboundLocalError in socket._sendfile_use_sendfile 2016-09-17 23:22:06 +03:00
Steve Dower 64566db065 Merge with 3.6 2016-09-17 12:57:03 -07:00
Steve Dower ed51b26858 Issue #28137: Renames Windows path file to ._pth
Issue #28138: Windows ._pth file should allow import site
2016-09-17 12:54:06 -07:00
Mark Dickinson fba121fe9d Issue #27441: Remove some redundant assignments to ob_size in longobject.c. Thanks Oren Milman. 2016-09-17 19:44:13 +01:00
Mark Dickinson 92ca535626 Issue #27222: various cleanups in long_rshift. Thanks Oren Milman. 2016-09-17 17:50:50 +01:00
Berker Peksag 6adb223831 Issue #28075: Merge from 3.6 2016-09-17 15:51:43 +03:00
Berker Peksag 052e4f18c4 Issue #28075: Merge from 3.5 2016-09-17 15:51:14 +03:00
Berker Peksag 0b4dc4846b Issue #28075: Check for ERROR_ACCESS_DENIED in Windows implementation of os.stat()
Patch by Eryk Sun.
2016-09-17 15:49:59 +03:00
Zachary Ware f40d4ddff3 Closes #27979: Remove bundled copy of libffi
An installed copy of libffi is now required for building _ctypes on
any platform but OSX and Windows.
2016-09-17 01:25:24 -05:00
Serhiy Storchaka 48ab735ca5 Issue #22493: Warning message emitted by using inline flags in the middle of
regular expression now contains a (truncated) regex pattern.
Patch by Tim Graham.
2016-09-17 01:30:48 +03:00
Serhiy Storchaka abf275af58 Issue #22493: Warning message emitted by using inline flags in the middle of
regular expression now contains a (truncated) regex pattern.
Patch by Tim Graham.
2016-09-17 01:29:58 +03:00
Alexander Belopolsky b3788aadb6 Added proper spelling for the name Elazar. 2016-09-16 13:54:05 -04:00
Berker Peksag 0d850ba861 Issue #25270: Merge from 3.6 2016-09-16 17:32:32 +03:00
Berker Peksag 7b4bcd2004 Issue #25270: Merge from 3.5 2016-09-16 17:32:06 +03:00
Berker Peksag 4a72a7b6c4 Issue #25270: Prevent codecs.escape_encode() from raising SystemError when an empty bytestring is passed 2016-09-16 17:31:06 +03:00
Christian Heimes b33b02e1c9 Issue #28181: Add Kaartic Sivaraam to Misc/ACKS. 2016-09-16 13:50:17 +02:00
Christian Heimes fafda38727 Issue #28181: Get antigravity over HTTPS. Patch by Kaartic Sivaraam. 2016-09-16 13:49:29 +02:00
Christian Heimes de3f48ae9a Issue #28181: Get antigravity over HTTPS. Patch by Kaartic Sivaraam. 2016-09-16 13:49:16 +02:00
Christian Heimes a4961e555b Issue #28181: Get antigravity over HTTPS. Patch by Kaartic Sivaraam. 2016-09-16 13:48:10 +02:00
Berker Peksag f670c83443 Issue #25895: Merge from 3.6 2016-09-16 14:45:57 +03:00
Berker Peksag f8479eeb34 Issue #25895: Merge from 3.5 2016-09-16 14:45:15 +03:00
Berker Peksag f676748a05 Issue #25895: Enable WebSocket URL schemes in urllib.parse.urljoin
Patch by Gergely Imreh and Markus Holtermann.
2016-09-16 14:43:58 +03:00
Martin Panter 3aba2223c8 Issue #28145: Merge spelling fixes from 3.6 2016-09-16 00:56:15 +00:00
Martin Panter 355bbb0a2a Issue #28145: Merge spelling fixes from 3.5 into 3.6 2016-09-16 00:55:27 +00:00
Martin Panter 2dc77f0e19 Issue #28145: Spelling fixes 2016-09-16 00:46:05 +00:00
Yury Selivanov 2e5b56e101 Merge 3.6 (issue #27759) 2016-09-15 19:31:50 -04:00
Yury Selivanov 993b6f5c7b Merge 3.5 (issue #27759) 2016-09-15 19:31:33 -04:00