Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-48330: address review comments to PR-12271 (#103209) 

address review comments to PR-12271

Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
This commit is contained in:
Giampaolo Rodola 2023-04-17 00:19:44 +02:00 committed by GitHub
parent a210cac776
commit ff3303e49c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Doc/library/unittest.rst
View File

@ -2191,10 +2191,6 @@ Loading and running tests
.. versionadded:: 3.12
Added *durations* keyword argument.
.. versionchanged:: 3.12
Subclasses should accept ``**kwargs`` to ensure compatibility as the
interface changes.
.. data:: defaultTestLoader
Instance of the :class:`TestLoader` class intended to be shared. If no

12
Lib/test/test_unittest/test_runner.py
View File

@ -1367,7 +1367,7 @@ class Test_TextTestRunner(unittest.TestCase):
self.assertTrue(runner.stream.stream is f)
def test_durations(self):
def run(test, expect_durations):
def run(test, *, expect_durations=True):
stream = BufferedWriter()
runner = unittest.TextTestRunner(stream=stream, durations=5, verbosity=2)
result = runner.run(test)
@ -1389,21 +1389,21 @@ class Test_TextTestRunner(unittest.TestCase):
def test_1(self):
pass
run(Foo('test_1'), True)
run(Foo('test_1'), expect_durations=True)
# failure
class Foo(unittest.TestCase):
def test_1(self):
self.assertEqual(0, 1)
run(Foo('test_1'), True)
run(Foo('test_1'), expect_durations=True)
# error
class Foo(unittest.TestCase):
def test_1(self):
1 / 0
run(Foo('test_1'), True)
run(Foo('test_1'), expect_durations=True)
# error in setUp and tearDown
@ -1414,7 +1414,7 @@ class Test_TextTestRunner(unittest.TestCase):
def test_1(self):
pass
run(Foo('test_1'), True)
run(Foo('test_1'), expect_durations=True)
# skip (expect no durations)
class Foo(unittest.TestCase):
@ -1422,7 +1422,7 @@ class Test_TextTestRunner(unittest.TestCase):
def test_1(self):
pass
run(Foo('test_1'), False)
run(Foo('test_1'), expect_durations=False)

6
Lib/unittest/result.py
View File

@ -159,7 +159,11 @@ class TestResult(object):
self.unexpectedSuccesses.append(test)
def addDuration(self, test, elapsed):
"""Called when a test finished to run, regardless of its outcome."""
"""Called when a test finished to run, regardless of its outcome.
*test* is the test case corresponding to the test method.
*elapsed* is the time represented in seconds, and it includes the
execution of cleanup functions.
"""
# support for a TextTestRunner using an old TestResult class
if hasattr(self, "collectedDurations"):
self.collectedDurations.append((test, elapsed))