Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

merge

This commit is contained in:
Raymond Hettinger 2014-06-15 14:50:39 -07:00
parent 354bffaec4 92a4055343
commit f46933a42f
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Lib/test/test_minidom.py
View File

@ -1531,6 +1531,13 @@ class MinidomTest(unittest.TestCase):
num_children_after = len(doc.childNodes) num_children_after = len(doc.childNodes)
self.assertTrue(num_children_after == num_children_before - 1) self.assertTrue(num_children_after == num_children_before - 1)
def testProcessingInstructionNameError(self):
# wrong variable in .nodeValue property will
# lead to "NameError: name 'data' is not defined"
doc = parse(tstfile)
pi = doc.createProcessingInstruction("y", "z")
pi.nodeValue = "crash"
def test_main(): def test_main():
run_unittest(MinidomTest) run_unittest(MinidomTest)

2
Lib/xml/dom/minidom.py
View File

@ -976,7 +976,7 @@ class ProcessingInstruction(Childless, Node):
def _get_nodeValue(self): def _get_nodeValue(self):
return self.data return self.data
def _set_nodeValue(self, value): def _set_nodeValue(self, value):
self.data = data self.data = value
nodeValue = property(_get_nodeValue, _set_nodeValue) nodeValue = property(_get_nodeValue, _set_nodeValue)
# nodeName is an alias for target # nodeName is an alias for target