From f326665fe7d89df3617b142749c195187ba56d0e Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Thu, 19 Dec 2013 13:24:49 +0100 Subject: [PATCH] Fix os.listdir(): _Py_dup() already raises an exception on error, no need to raise a new exception --- Modules/posixmodule.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index a64285e9551..ec70948e220 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -3746,10 +3746,8 @@ _posix_listdir(path_t *path, PyObject *list) if (path->fd != -1) { /* closedir() closes the FD, so we duplicate it */ fd = _Py_dup(path->fd); - if (fd == -1) { - list = posix_error(); - goto exit; - } + if (fd == -1) + return NULL; return_str = 1;