From f2b34b8b9669598d4294488cf3bb8ab4465b7097 Mon Sep 17 00:00:00 2001 From: Ross Lagerwall Date: Fri, 24 Aug 2012 13:25:59 +0200 Subject: [PATCH] Issue 15777: Fix a refleak in _posixsubprocess. It was exposed by 03c98d05b140 and dbbf3ccf72e8. --- Misc/NEWS | 2 ++ Modules/_posixsubprocess.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Misc/NEWS b/Misc/NEWS index ae2ce66732c..0d76a6e3552 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -109,6 +109,8 @@ Core and Builtins Library ------- +- Issue #15777: Fix a refleak in _posixsubprocess. + - Issue #15199: Fix JavaScript's default MIME type to application/javascript. Patch by Bohuslav Kabrda. diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c index c93f5377f95..59673f4969f 100644 --- a/Modules/_posixsubprocess.c +++ b/Modules/_posixsubprocess.c @@ -566,8 +566,10 @@ subprocess_fork_exec(PyObject* self, PyObject *args) } exec_array = _PySequence_BytesToCharpArray(executable_list); - if (!exec_array) + if (!exec_array) { + Py_XDECREF(gc_module); return NULL; + } /* Convert args and env into appropriate arguments for exec() */ /* These conversions are done in the parent process to avoid allocating