From f032a002711083610bf732bdfc5034e3af739ebe Mon Sep 17 00:00:00 2001 From: Eric Smith Date: Sat, 19 Jul 2008 00:24:05 +0000 Subject: [PATCH] Fix issue 3411: default float format spec fails on negative numbers. --- Lib/test/test_types.py | 6 ++++++ Python/pystrtod.c | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/Lib/test/test_types.py b/Lib/test/test_types.py index 03f2ff88d37..10ad6346c4e 100644 --- a/Lib/test/test_types.py +++ b/Lib/test/test_types.py @@ -570,6 +570,12 @@ class TypesTests(unittest.TestCase): test(0.01, '', '0.01') test(0.01, 'g', '0.01') + # test for issue 3411 + test(1.23, '1', '1.23') + test(-1.23, '1', '-1.23') + test(1.23, '1g', '1.23') + test(-1.23, '1g', '-1.23') + test( 1.0, ' g', ' 1') test(-1.0, ' g', '-1') test( 1.0, '+g', '+1') diff --git a/Python/pystrtod.c b/Python/pystrtod.c index 01c1c42770d..302e01298a4 100644 --- a/Python/pystrtod.c +++ b/Python/pystrtod.c @@ -302,6 +302,10 @@ ensure_decimal_point(char* buffer, size_t buf_size) /* search for the first non-digit character */ char *p = buffer; + if (*p == '-' || *p == '+') + /* Skip leading sign, if present. I think this could only + ever be '-', but it can't hurt to check for both. */ + ++p; while (*p && isdigit(Py_CHARMASK(*p))) ++p;