Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Rewrite the list_inline_repeat overflow check slightly differently.

This commit is contained in:
Guido van Rossum 2008-01-25 19:42:36 +00:00
parent 1c4282b41b
commit ee6bab06d3
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Objects/listobject.c
View File

@ -490,7 +490,7 @@ list_repeat(PyListObject *a, Py_ssize_t n)
if (n && size/n != a->ob_size) if (n && size/n != a->ob_size)
return PyErr_NoMemory(); return PyErr_NoMemory();
if (size == 0) if (size == 0)
return PyList_New(0); return PyList_New(0);
np = (PyListObject *) PyList_New(size); np = (PyListObject *) PyList_New(size);
if (np == NULL) if (np == NULL)
return NULL; return NULL;
@ -672,10 +672,11 @@ list_inplace_repeat(PyListObject *self, Py_ssize_t n)
return (PyObject *)self; return (PyObject *)self;
} }
p = size*n; if (size > SSIZE_MAX / n) {
if (p/n != size)
return PyErr_NoMemory(); return PyErr_NoMemory();
if (list_resize(self, p) == -1) }
if (list_resize(self, size*n) == -1)
return NULL; return NULL;
p = size; p = size;