Fix possible "file already exists" error when running the tests in parallel.

This is a perfect example of LBYL going wrong: that code could be executed
by several workers in parallel, and os.mkdir() attempted on the same
path by multiple processes.
This commit is contained in:
Antoine Pitrou 2011-04-16 18:53:59 +02:00
parent 1d827ff43d
commit ee4293400c
2 changed files with 7 additions and 1 deletions

View File

@ -162,6 +162,7 @@ import re
import io
import sys
import time
import errno
import traceback
import warnings
import unittest
@ -1511,8 +1512,11 @@ def _make_temp_dir_for_build(TEMPDIR):
if sysconfig.is_python_build():
TEMPDIR = os.path.join(sysconfig.get_config_var('srcdir'), 'build')
TEMPDIR = os.path.abspath(TEMPDIR)
if not os.path.exists(TEMPDIR):
try:
os.mkdir(TEMPDIR)
except OSError as e:
if e.errno != errno.EEXIST:
raise
# Define a writable temp dir that will be used as cwd while running
# the tests. The name of the dir includes the pid to allow parallel

View File

@ -269,6 +269,8 @@ Extensions
Tests
-----
- Fix possible "file already exists" error when running the tests in parallel.
- Issue #11719: Fix message about unexpected test_msilib skip on non-Windows
platforms. Patch by Nadeem Vawda.