Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Don't use sscanf(s, "%x", &c) to parse \xX... escapes; hardcode it.

This commit is contained in:
Guido van Rossum 1997-10-20 23:24:07 +00:00
parent f6a84db034
commit ed1100f3b6
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Python/compile.c
View File

@ -36,7 +36,6 @@ PERFORMANCE OF THIS SOFTWARE.
XXX (it's currently the first item of the co_const tuple)
XXX Generate simple jump for break/return outside 'try...finally'
XXX Allow 'continue' inside try-finally
XXX New 1-byte opcode for loading None
XXX New opcode for loading the initial index for a for loop
XXX other JAR tricks?
*/
@ -922,11 +921,19 @@ parsestr(s)
break;
case 'x':
if (isxdigit(Py_CHARMASK(*s))) {
sscanf(s, "%x", &c);
*p++ = c;
unsigned int x = 0;
do {
c = Py_CHARMASK(*s);
s++;
x = (x<<4) & ~0xF;
if (isdigit(c))
x += c - '0';
else if (islower(c))
x += 10 + c - 'a';
else
x += 10 + c - 'A';
} while (isxdigit(Py_CHARMASK(*s)));
*p++ = x;
break;
}
/* FALLTHROUGH */