Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-88118: Fix some test_multiprocessing flakiness. (#116434) 

Fix some test_multiprocessing flakiness.

Potentially introduced by https://github.com/python/cpython/pull/25845

not joining that thread likely leads to recently observed "environment
changed" logically passing but overall failing tests seen on some
buildbots similar to:

```
1 test altered the execution environment (env changed):
    test.test_multiprocessing_fork.test_processes

2 re-run tests:
    test.test_multiprocessing_fork.test_processes
    test.test_multiprocessing_forkserver.test_processes
```
This commit is contained in:
Gregory P. Smith 2024-03-06 13:39:06 -08:00 committed by GitHub
parent c62144a02c
commit ea1803e608
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Lib/test/_test_multiprocessing.py
View File

@ -3513,15 +3513,20 @@ class _TestListener(BaseTestCase):
client = self.connection.Client(addr, authkey=authkey)
client.send(1729)
key = b""
key = b''
with self.connection.Listener(authkey=key) as listener:
threading.Thread(target=run, args=(listener.address, key)).start()
thread = threading.Thread(target=run, args=(listener.address, key))
thread.start()
try:
with listener.accept() as d:
self.assertEqual(d.recv(), 1729)
finally:
thread.join()
if self.TYPE == 'processes':
self.assertRaises(OSError, listener.accept)
with self.assertRaises(OSError):
listener.accept()
@unittest.skipUnless(util.abstract_sockets_supported,
"test needs abstract socket support")