Patch #1966: Break infinite loop in httplib when the servers

implements the chunked encoding incorrectly.
2008-02-12 18:48:23 +00:00 · 2008-02-12 18:48:23 +00:00 · e9c996c14d
parent cab74c8398
commit e9c996c14d
2 changed files with 7 additions and 0 deletions
--- a/Lib/httplib.py
+++ b/Lib/httplib.py
@ -571,6 +571,10 @@ class HTTPResponse:
        ### note: we shouldn't have any trailers!
        while True:
            line = self.fp.readline()
+            if not line:
+                # a vanishingly small number of sites EOF without
+                # sending the trailer
+                break
            if line == '\r\n':
                break

--- a/Misc/NEWS
+++ b/Misc/NEWS
@ -83,6 +83,9 @@ Core and builtins
 Library
 -------

+- Patch #1966: Break infinite loop in httplib when the servers
+  implements the chunked encoding incorrectly.
+
 - tarfile.py: Fix reading of xstar archives.

 - #2021: Allow tempfile.NamedTemporaryFile to be used in with statements