Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Add a comment for some code I don't understand. Why would needsfree 

be true if we didn't malloc the code?  Seems like the code is wrong
or could use comments.

Also verify if the buildbots are working properly for the 2.5 branch.
This commit is contained in:
Neal Norwitz 2007-01-18 07:16:31 +00:00
parent eb68188a0d
commit e962300d0c
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Modules/_ctypes/_ctypes.c
View File

@ -2199,6 +2199,7 @@ static void CData_MallocBuffer(CDataObject *obj, StgDictObject *dict)
if ((size_t)dict->size <= sizeof(obj->b_value)) { if ((size_t)dict->size <= sizeof(obj->b_value)) {
/* No need to call malloc, can use the default buffer */ /* No need to call malloc, can use the default buffer */
obj->b_ptr = (char *)&obj->b_value; obj->b_ptr = (char *)&obj->b_value;
/* XXX(nnorwitz): shouldn't b_needsfree be 0? */
obj->b_needsfree = 1; obj->b_needsfree = 1;
} else { } else {
/* In python 2.4, and ctypes 0.9.6, the malloc call took about /* In python 2.4, and ctypes 0.9.6, the malloc call took about