Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Issue #27073: Removed redundant checks in long_add and long_sub. 

Patch by Oren Milman.
This commit is contained in:
Serhiy Storchaka 2016-06-04 00:06:45 +03:00
parent 11aaa42d1c
commit e63e5d60ee
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Objects/longobject.c
View File

@ -3022,9 +3022,15 @@ long_add(PyLongObject *a, PyLongObject *b)
if (Py_SIZE(a) < 0) { if (Py_SIZE(a) < 0) {
if (Py_SIZE(b) < 0) { if (Py_SIZE(b) < 0) {
z = x_add(a, b); z = x_add(a, b);
if (z != NULL && Py_SIZE(z) != 0) if (z != NULL) {
/* x_add received at least one multiple-digit int,
and thus z must be a multiple-digit int.
That also means z is not an element of
small_ints, so negating it in-place is safe. */
assert(Py_REFCNT(z) == 1);
Py_SIZE(z) = -(Py_SIZE(z)); Py_SIZE(z) = -(Py_SIZE(z));
} }
}
else else
z = x_sub(b, a); z = x_sub(b, a);
} }
@ -3054,9 +3060,11 @@ long_sub(PyLongObject *a, PyLongObject *b)
z = x_sub(a, b); z = x_sub(a, b);
else else
z = x_add(a, b); z = x_add(a, b);
if (z != NULL && Py_SIZE(z) != 0) if (z != NULL) {
assert(Py_SIZE(z) == 0 || Py_REFCNT(z) == 1);
Py_SIZE(z) = -(Py_SIZE(z)); Py_SIZE(z) = -(Py_SIZE(z));
} }
}
else { else {
if (Py_SIZE(b) < 0) if (Py_SIZE(b) < 0)
z = x_add(a, b); z = x_add(a, b);