Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-44022: Improve the regression test. (GH-26503) 

It wasn't actually detecting the regression due to the
assertion being too lenient.
This commit is contained in:
Gregory P. Smith 2021-06-02 20:43:38 -07:00 committed by GitHub
parent adef445dc3
commit e60ab843cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Lib/test/test_httplib.py
View File

@ -1186,7 +1186,12 @@ class BasicTest(TestCase):
'r\n' * 32768 'r\n' * 32768
) )
resp = client.HTTPResponse(FakeSocket(body)) resp = client.HTTPResponse(FakeSocket(body))
self.assertRaises(client.HTTPException, resp.begin) with self.assertRaises(client.HTTPException) as cm:
resp.begin()
# We must assert more because other reasonable errors that we
# do not want can also be HTTPException derived.
self.assertIn('got more than ', str(cm.exception))
self.assertIn('headers', str(cm.exception))
def test_overflowing_chunked_line(self): def test_overflowing_chunked_line(self):
body = ( body = (