Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-33363: raise SyntaxError for async for/with outside async functions (#6616)

This commit is contained in:
Zsolt Dollenstein 2018-04-27 08:58:56 -07:00 committed by Yury Selivanov
parent 078c4e3519
commit e239650660
3 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Lib/test/test_coroutines.py
View File

@ -362,7 +362,22 @@ class AsyncBadSyntaxTest(unittest.TestCase):
"""def foo():
async def bar():
pass\nawait a
"""]
""",
"""def foo():
async for i in arange(2):
pass
""",
"""def foo():
async with resource:
pass
""",
"""async with resource:
pass
""",
"""async for i in arange(2):
pass
""",
]
for code in samples:
with self.subTest(code=code), self.assertRaises(SyntaxError):

2
Misc/NEWS.d/next/Core and Builtins/2018-04-26-22-48-28.bpo-33363.8RCnN2.rst Normal file
View File

@ -0,0 +1,2 @@
Raise a SyntaxError for ``async with`` and ``async for`` statements outside
of async functions.

7
Python/compile.c
View File

@ -2447,6 +2447,10 @@ static int
compiler_async_for(struct compiler *c, stmt_ty s)
{
basicblock *start, *except, *end;
if (c->u->u_scope_type != COMPILER_SCOPE_ASYNC_FUNCTION) {
return compiler_error(c, "'async for' outside async function");
}
start = compiler_new_block(c);
except = compiler_new_block(c);
end = compiler_new_block(c);
@ -4262,6 +4266,9 @@ compiler_async_with(struct compiler *c, stmt_ty s, int pos)
withitem_ty item = asdl_seq_GET(s->v.AsyncWith.items, pos);
assert(s->kind == AsyncWith_kind);
if (c->u->u_scope_type != COMPILER_SCOPE_ASYNC_FUNCTION) {
return compiler_error(c, "'async with' outside async function");
}
block = compiler_new_block(c);
finally = compiler_new_block(c);