Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Disallow function calls like foo(None=1). 

Backport from py3k rev. 55708 by Guido.
This commit is contained in:
Georg Brandl 2007-06-07 13:23:24 +00:00
parent ab8e279ba6
commit e06cf4534f
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Lib/test/test_compile.py
View File

@ -36,6 +36,9 @@ class TestSpecifics(unittest.TestCase):
def test_syntax_error(self): def test_syntax_error(self):
self.assertRaises(SyntaxError, compile, "1+*3", "filename", "exec") self.assertRaises(SyntaxError, compile, "1+*3", "filename", "exec")
def test_none_keyword_arg(self):
self.assertRaises(SyntaxError, compile, "f(None=1)", "<string>", "exec")
def test_duplicate_global_local(self): def test_duplicate_global_local(self):
try: try:
exec 'def f(a): global a; a = 1' exec 'def f(a): global a; a = 1'

4
Python/ast.c
View File

@ -1869,6 +1869,10 @@ ast_for_call(struct compiling *c, const node *n, expr_ty func)
return NULL; return NULL;
} }
key = e->v.Name.id; key = e->v.Name.id;
if (!strcmp(PyString_AS_STRING(key), "None")) {
ast_error(CHILD(ch, 0), "assignment to None");
return NULL;
}
e = ast_for_expr(c, CHILD(ch, 2)); e = ast_for_expr(c, CHILD(ch, 2));
if (!e) if (!e)
return NULL; return NULL;