Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-38912: fix close before connect callback in test_asyncio SSL tests (GH-22691) 

Reduces the rate at which the ENV CHANGED failure occurs in test_asyncio SSL tests (due to unclosed transport), but does not 100% resolve it.
This commit is contained in:
Justin Turner Arthur 2020-10-19 20:18:57 -05:00 committed by GitHub
parent 23c0fb8edd
commit de73d432bb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/test/test_asyncio/test_events.py
View File

@ -1076,6 +1076,7 @@ class EventLoopTestsMixin:
ssl=sslcontext_client, ssl=sslcontext_client,
server_hostname='localhost') server_hostname='localhost')
client, pr = self.loop.run_until_complete(f_c) client, pr = self.loop.run_until_complete(f_c)
self.loop.run_until_complete(proto.connected)
# close connection # close connection
proto.transport.close() proto.transport.close()
@ -1101,6 +1102,7 @@ class EventLoopTestsMixin:
ssl=sslcontext_client, ssl=sslcontext_client,
server_hostname='localhost') server_hostname='localhost')
client, pr = self.loop.run_until_complete(f_c) client, pr = self.loop.run_until_complete(f_c)
self.loop.run_until_complete(proto.connected)
# extra info is available # extra info is available
self.check_ssl_extra_info(client, peername=(host, port), self.check_ssl_extra_info(client, peername=(host, port),

1
Misc/ACKS
View File

@ -70,6 +70,7 @@ Alexandru Ardelean
Emmanuel Arias Emmanuel Arias
Alicia Arlen Alicia Arlen
Jeffrey Armstrong Jeffrey Armstrong
Justin Turner Arthur
Jason Asbahr Jason Asbahr
David Ascher David Ascher
Ammar Askar Ammar Askar