Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Issue #24377: Fix a ref leak in OrderedDict.__repr__.

This commit is contained in:
Eric Snow 2015-06-03 11:09:48 -06:00
parent 4c72918a59
commit db4061cb9d
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Misc/NEWS
View File

@ -25,6 +25,8 @@ Library
- Issue #24362: Simplify the C OrderedDict fast nodes resize logic. - Issue #24362: Simplify the C OrderedDict fast nodes resize logic.
- Issue #24377: Fix a ref leak in OrderedDict.__repr__.
What's New in Python 3.5.0 beta 2? What's New in Python 3.5.0 beta 2?
================================== ==================================

2
Objects/odictobject.c
View File

@ -1578,7 +1578,7 @@ odict_repr(PyODictObject *self)
if (value == NULL) { if (value == NULL) {
if (!PyErr_Occurred()) if (!PyErr_Occurred())
PyErr_SetObject(PyExc_KeyError, key); PyErr_SetObject(PyExc_KeyError, key);
return NULL; goto Done;
} }
pair = PyTuple_Pack(2, key, value); pair = PyTuple_Pack(2, key, value);
if (pair == NULL) if (pair == NULL)