mirror of https://github.com/python/cpython
bpo-45755: [typing] Reveal class attributes of generic in generic aliases in `dir()` (GH-29962)
This commit is contained in:
parent
4506bbede1
commit
d6e1374716
|
@ -5040,6 +5040,17 @@ class SpecialAttrsTests(BaseTestCase):
|
|||
loaded = pickle.loads(s)
|
||||
self.assertIs(SpecialAttrsP, loaded)
|
||||
|
||||
def test_genericalias_dir(self):
|
||||
class Foo(Generic[T]):
|
||||
def bar(self):
|
||||
pass
|
||||
baz = 3
|
||||
# The class attributes of the original class should be visible even
|
||||
# in dir() of the GenericAlias. See bpo-45755.
|
||||
self.assertIn('bar', dir(Foo[int]))
|
||||
self.assertIn('baz', dir(Foo[int]))
|
||||
|
||||
|
||||
class AllTests(BaseTestCase):
|
||||
"""Tests for __all__."""
|
||||
|
||||
|
|
|
@ -991,6 +991,9 @@ class _BaseGenericAlias(_Final, _root=True):
|
|||
raise TypeError("Subscripted generics cannot be used with"
|
||||
" class and instance checks")
|
||||
|
||||
def __dir__(self):
|
||||
return list(set(super().__dir__()
|
||||
+ [attr for attr in dir(self.__origin__) if not _is_dunder(attr)]))
|
||||
|
||||
# Special typing constructs Union, Optional, Generic, Callable and Tuple
|
||||
# use three special attributes for internal bookkeeping of generic types:
|
||||
|
|
|
@ -0,0 +1,3 @@
|
|||
:mod:`typing` generic aliases now reveal the class attributes of the
|
||||
original generic class when passed to ``dir()``. This was the behavior up to
|
||||
Python 3.6, but was changed in 3.7-3.9.
|
Loading…
Reference in New Issue