Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-83004: Clean up refleak in _pickle initialisation (#98841)

This commit is contained in:
Shantanu 2022-11-06 06:05:13 -08:00 committed by GitHub
parent 31f2f6568d
commit d3b82b4463
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Misc/NEWS.d/next/Library/2022-11-02-05-53-25.gh-issue-83004.qc_KHr.rst Normal file
View File

@ -0,0 +1 @@
Clean up refleaks on failed module initialisation in in :mod:`_pickle`

13
Modules/_pickle.c
View File

@ -7986,16 +7986,15 @@ PyInit__pickle(void)
if (st->UnpicklingError == NULL) if (st->UnpicklingError == NULL)
return NULL; return NULL;
Py_INCREF(st->PickleError); if (PyModule_AddObjectRef(m, "PickleError", st->PickleError) < 0) {
if (PyModule_AddObject(m, "PickleError", st->PickleError) < 0)
return NULL; return NULL;
Py_INCREF(st->PicklingError); }
if (PyModule_AddObject(m, "PicklingError", st->PicklingError) < 0) if (PyModule_AddObjectRef(m, "PicklingError", st->PicklingError) < 0) {
return NULL; return NULL;
Py_INCREF(st->UnpicklingError); }
if (PyModule_AddObject(m, "UnpicklingError", st->UnpicklingError) < 0) if (PyModule_AddObjectRef(m, "UnpicklingError", st->UnpicklingError) < 0) {
return NULL; return NULL;
}
if (_Pickle_InitState(st) < 0) if (_Pickle_InitState(st) < 0)
return NULL; return NULL;