Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-44562: Remove invalid PyObject_GC_Del from error path of types.GenericAlias … (GH-27016)

This commit is contained in:
Ken Jin 2021-07-05 00:47:38 +08:00 committed by GitHub
parent bc39614856
commit d33943a6c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Misc/NEWS.d/next/Core and Builtins/2021-07-04-23-38-51.bpo-44562.QdeRQo.rst Normal file
View File

@ -0,0 +1,2 @@
Remove uses of :c:func:`PyObject_GC_Del` in error path when initializing
:class:`types.GenericAlias`.

6
Objects/genericaliasobject.c
View File

@ -603,7 +603,7 @@ ga_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
return NULL;
}
if (!setup_ga(self, origin, arguments)) {
type->tp_free((PyObject *)self);
Py_DECREF(self);
return NULL;
}
return (PyObject *)self;
@ -650,10 +650,10 @@ Py_GenericAlias(PyObject *origin, PyObject *args)
if (alias == NULL) {
return NULL;
}
_PyObject_GC_TRACK(alias);
if (!setup_ga(alias, origin, args)) {
PyObject_GC_Del((PyObject *)alias);
Py_DECREF(alias);
return NULL;
}
_PyObject_GC_TRACK(alias);
return (PyObject *)alias;
}